【发布时间】:2012-04-03 21:07:49
【问题描述】:
这是我的功能
public List<String[]> comparableListsAreTheSame(List<String> baseList, List<String> resultList, int type)
{
if (type == 1) { }
List<String> baseListCopy = baseList;
List<String> resultListCopy = resultList;
bool sameLength = (baseListCopy.Count == resultList.Count); // are 2 lists have the same length?
List<String> Base = baseListCopy.Except(resultListCopy, StringComparer.InvariantCultureIgnoreCase).ToList(); //Keep unique values
List<String> Result = resultListCopy.Except(baseListCopy, StringComparer.InvariantCultureIgnoreCase).ToList(); //Keep unique values
List<String[]> blocksComparisonSet1 = new List<String[]>(); //we add blocks based on list1; so we could output them to excel
List<String[]> blocksComparisonSet2 = new List<String[]>(); //we add blocks based on list2; so we could output them to excel
List<String[]> blocksComparisonFinal = new List<String[]>(); //we combine list1 and list
//-----------------------------------------------------------------
if (Result.Count > 0 || Base.Count > 0)
{
foreach (String resultLine in Result) //loop over all lines in list 1
{
bool found = false; //if element in base i
String[] resultLineArray = resultLine.Split('*'); //get array from the string
foreach (String baseLine in Base)
{
String[] baseLineArray = baseLine.Split('*');
if (resultLineArray[0].Equals(baseLineArray[0]) && resultLineArray[1].Equals(baseLineArray[1]) && resultLineArray[2].Equals(baseLineArray[2]) && resultLineArray[3].Equals(baseLineArray[3]))
{
String[] NA = new String[2]; //keep results
NA[0] = baseLine; //[0] for base
NA[1] = resultLine; //[1] for result
blocksComparisonSet1.Add(NA);
found = true;
}
}
if (!found)
{
String[] NA = new String[2]; //keep results
NA[0] = "N/A"; //[0] for base
NA[1] = resultLine; //[1] for result
blocksComparisonSet1.Add(NA);
}
}
//-----------------------------------------------------------------
foreach (String baseLine in Base) //loop over all lines in list 2
{
bool found = false; //if element in base i
String[] baseLineArray = baseLine.Split('*'); //get array from the string
foreach (String resultLine in Result)
{
String[] resultLineArray = resultLine.Split('*');
if (resultLineArray[0].Equals(baseLineArray[0]) && resultLineArray[1].Equals(baseLineArray[1]) && resultLineArray[2].Equals(baseLineArray[2]) && resultLineArray[3].Equals(baseLineArray[3]))
{
String[] NA = new String[2]; //keep results
NA[0] = baseLine; //[0] for base
NA[1] = resultLine; //[1] for result
blocksComparisonSet2.Add(NA);
found = true;
}
}
if (!found)
{
String[] NA = new String[2]; //keep results
NA[0] = baseLine; //[0] for base
NA[1] = "N/A"; //[1] for result
blocksComparisonSet2.Add(NA);
}
}
}
//-----------------------------------------------------------------
if (blocksComparisonSet1.Any() || blocksComparisonSet2.Any()) //check if we have any values in out differences lists. if we do, merge them
{
blocksComparisonFinal.AddRange(blocksComparisonSet1); //add records from one list to final list
blocksComparisonFinal.AddRange(blocksComparisonSet2); //add records from second list to final list
HashSet<String[]> s = new HashSet<String[]>(blocksComparisonFinal);
blocksComparisonFinal = s.ToList();
}
blocksComparisonFinal = blocksComparisonSet1.Union(blocksComparisonSet2, new ArrayEqualityComparer<string>()).ToList();
return blocksComparisonFinal;
}
我是 C# 和一般编程的新手,我做了多个循环并以非常粗俗的方式匹配所有内容。我可以更专业地处理它,并且做得更干净、更正确吗?
【问题讨论】:
-
定义列表“平等”的含义。
-
可能更适合 codereview.stackexchange.com
-
type参数是干什么用的?一般来说,您可以创建一个实现IEqualityComparer<List<string[]>>的类和/或一个实现IEqualityComparer<string[]>的类,以大大简化您的代码。 -
看起来您要做的不仅仅是确定两个列表是否相等...您能否详细解释一下您要完成的工作?
标签: c# algorithm list optimization comparison