【发布时间】:2014-01-23 18:22:21
【问题描述】:
给出以下代码示例(iOS 7、Xcode 5):
/**
* SampleProvider Class
*/
typedef void(^RequestCallback)(UIViewController *result);
static NSString * const cControllerRequestNotification = @"controllerRequestNotification";
static NSString * const cRequestClassNameKey = @"className";
static NSString * const cRequestCallbackKey = @"callback";
@interface SampleProvider : NSObject
+ (void)requestControllerForClassName:(NSString *)className completion:(RequestCallback)callback;
@end
@interface SampleProvider ()
- (UIViewController *)controllerForClassName:(NSString *)className;
- (void)didReceiveControllerRequest:(NSNotification *)n;
@end
@implementation SampleProvider
#pragma mark - Overrides
- (void)dealloc {
[[NSNotificationCenter defaultCenter] removeObserver:self];
}
- (id)init {
self = [super init];
if( self ) {
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didReceiveControllerRequest:) name:cControllerRequestNotification object:nil];
}
return self;
}
#pragma mark - Public API
+ (void)requestControllerForClassName:(NSString *)className completion:(RequestCallback)callback{
NSDictionary *requestInfo = @{ cRequestClassNameKey : className, cRequestCallbackKey : [callback copy] };
[[NSNotificationCenter defaultCenter] postNotificationName:cControllerRequestNotification object:requestInfo];
}
#pragma mark - Private API
- (UIViewController *)controllerForClassName:(NSString *)className {
UIViewController *result = nil;
Class controllerClass = NSClassFromString(className);
if( (nil != controllerClass) && ([controllerClass isSubclassOfClass:[UIViewController class]]) ) {
result = [[controllerClass alloc] init];
}
return result;
}
- (void)didReceiveControllerRequest:(NSNotification *)n {
NSDictionary *requestInfo = [n object];
NSString *className = requestInfo[cRequestClassNameKey];
RequestCallback callback = requestInfo[cRequestCallbackKey];
UIViewController *result = [self controllerForClassName:className];
if( nil != callback ) {
callback(result);
}
}
@end
/**
* SampleViewController Class
*/
@interface SampleViewController : UIViewController
@end
@implementation SampleViewController
#pragma mark - Overrides
- (void)viewDidAppear:(BOOL)animated{
[super viewDidAppear:animated];
NSString *className = @"ClassName";
[SampleProvider requestControllerForClassName:className completion:^(UIViewController *result) {
if( nil != result ) {
// Result is valid pointer, not a zombie.
[self.navigationController pushViewController:result animated:YES];
// Result is released, not nil.
} else {
NSLog(@"Unable to load controller with class name: %@", className);
}
}];
}
@end
为什么我的 UINavigationController 无法获得由 SampleProvider 的公共类方法接收的回调控制器的所有权,即使在显示视图之后也是如此?
我看到以下行为:
新的控制器类被正确分配并通过回调方法返回。进入回调后,结果参数指向有效内存。
新控制器被推送到我的 UINavigationController 的导航堆栈。
调用新推送的控制器的“viewDidLoad”方法。
检查 UINavigationController 的“viewControllers”属性时,新推送的控制器在数组中被引用。
当 UINavigationController pushViewController:animated: 仍在执行时,新的推送控制器被释放。
新控制器现在是僵尸。
感谢您的帮助。
【问题讨论】:
-
实际推送可能计划在堆栈展开后在主运行循环上运行...所以您会在推送实际发生之前首先看到 -release...
-
另一个选项——你的块是在不是主线程的线程上运行的吗?如果是,那么您可以将
-pushViewController:animated:用performBlockOnMainThread:或类似的东西包围 -
该块似乎正在同步执行,但是,我尝试使用主队列将
-pushViewController:animated:与 GCD 包装在一起。这会在推送发生之前产生崩溃。这让我感到困惑,因为我希望 GCD 块增加对象的保留计数,从而防止其释放。 -
我根据下面 Sean Cier 的回答更新了示例代码以纠正不相关的缺陷。
-
您可以使用 Instruments 查看应用程序中每个对象的每个保留/释放的调用堆栈。也许您可以查看僵尸的保留/释放跟踪。
标签: ios objective-c automatic-ref-counting objective-c-blocks exc-bad-access