在循环中执行存储过程是否有更有效的替代方法？

Question

我在我的 asp.net 站点的网络表单中调用了大量存储过程，并在循环中执行。在大多数情况下，这很好，除非我使用更高的数量。事情变得非常缓慢。有没有其他方法可以让我的网站更高效？

例如，我有一个存储过程spReservePart，它执行以下操作：

    -- Add the parameters for the stored procedure here
    @startdate datetime, @enddate datetime, @SparePartID int, @notes nvarchar(MAX), @sr int, @assignto nvarchar(MAX), @newloc nvarchar(MAX)
AS
BEGIN
    -- SET NOCOUNT ON added to prevent extra result sets from
    -- interfering with SELECT statements.
    SET NOCOUNT ON;



    if (@sr = 0) begin set @sr = null end

    Insert into Reservations (ReservationID, StartDate, EndDate, SparePartID, Notes, Status, SRNumber, AssignedTo)
    Values (newid(), @startdate, @enddate, @SparePartID, @notes, 'Active', @sr, @assignto)

    Update MiddleMan Set ReservationID = (Select Top (1) ReservationID from Reservations where SparePartID=@SparePartID and Status = 'Active') where SparePartID=@SparePartID
    Update MiddleMan Set In_Use = 1 where SparePartID = @SparePartID
    Update MiddleMan Set SRHistory = (Select Top (1) SRNumber from Reservations where SparePartID=@SparePartID and Status = 'Active') where SparePartID = @SparePartID
    Update MiddleMan Set CurrentLocation = @newloc where SparePartID = @SparePartID

END

它来自的网络表单有一个带有复选框的 Gridview，对于每个选中的复选框，它都会调用这个存储过程。

foreach (GridViewRow item in gvreserveparts.Rows)
                {//for each row in the gridview
                    var chk = (CheckBox)item.FindControl("cbSelect");
                    if (chk.Checked == true) //checkbox is checked
                    {
                        //assignment of parameters here


                        //create connection with database
                        OleDbConnection conn = new OleDbConnection(connectionInfo);

                        OleDbCommand cmd = new OleDbCommand();
                        conn.Open();
                        cmd.Connection = conn;
                        cmd.CommandText = "spReservePart";
                        cmd.CommandType = CommandType.StoredProcedure;
                        cmd.Parameters.AddWithValue("@startdate", start);
                        cmd.Parameters.AddWithValue("@enddate", end);
                        cmd.Parameters.AddWithValue("@SparePartID", sparepartid);
                        cmd.Parameters.AddWithValue("@notes", notes);
                        cmd.Parameters.AddWithValue("@sr", sr);
                        cmd.Parameters.AddWithValue("@assignto", assignto);
                        cmd.Parameters.AddWithValue("@newloc", newloc);

                        cmd.ExecuteNonQuery();
                        conn.Close();
                    }


                }
            }

即使调用此 SP 的 6 次，也可能需要很长时间。因此，更有效的替代方案将非常有帮助。

Answer 1

您可以重写存储过程以接受表值参数，而不是将一组标量值参数传递给过程，然后您可以将单个表中的所有参数集传递给过程并且只执行一次。

Answer 2

获取表值参数是一个不错的选择，但您可以从更改过程开始以避免多次读取 Reservations 表并更新 MiddleMan 表 4 次。您可以使用 OUTPUT 子句消除读取并使用单个 UPDATE。

CREATE PROCEDURE spReservePart 
    -- Add the parameters for the stored procedure here
    @startdate datetime, @enddate datetime, @SparePartID int, @notes nvarchar(MAX), @sr int, @assignto nvarchar(MAX), @newloc nvarchar(MAX)
AS
BEGIN
    -- SET NOCOUNT ON added to prevent extra result sets from
    -- interfering with SELECT statements.
    SET NOCOUNT ON;

    DECLARE @Output TABLE(
        ReservationId UNIQUEIDENTIFIER,
        SRNumber      INT,
        SparePartID   INT
    );

    IF (@sr = 0) 
        SET @sr = NULL;

    INSERT INTO Reservations (
        ReservationID, 
        StartDate, 
        EndDate, 
        SparePartID, 
        Notes, 
        Status, 
        SRNumber, 
        AssignedTo)
    OUTPUT  inserted.ReservationId, 
            inserted.SRNumber, 
            inserted.SparePartID 
    INTO @Output(
            ReservationId, 
            SRNumber, 
            SparePartID)
    VALUES (
        NEWID(), 
        @startdate, 
        @enddate, 
        @SparePartID, 
        @notes, 
        'Active', 
        @sr, 
        @assignto);

    UPDATE MiddleMan SET
        ReservationID   = o.ReservationID,
        In_Use          = 1,
        SRHistory       = o.SRNumber,
        CurrentLocation = @newloc
    FROM MiddleMan m
    JOIN @Output o ON m.SparePartID = o.SparePartID;
END

Answer 3

你可以做的是改变你的存储过程来接受所有的数据作为一个表。

将您的数据作为 dataTable 传递给存储过程。所以你必须调用一次存储过程。

在这个链接中，有一个例子：

How to send bulk data using table value parameters from c#

这就是你应该如何改变你的存储过程来接受表：

CREATE PROCEDURE [dbo].[SampleProcedure]
    (
     -- which accepts one table value parameter. 
     -- It should be noted that the parameter is read-only
     @Sample AS [dbo].[SampleDataType] READONLY
)
AS
BEGIN
    INSERT INTO Reservations (ReservationID, StartDate, EndDate, SparePartID, 
                              Notes, Status, SRNumber, AssignedTo)
        SELECT 
            ReservationID, StartDate,EndDate, ... 
        FROM
            @Sample
END

您可以在您的 C# 代码中创建一个 DataTable 并将其作为参数发送到存储过程

var dataTable = new DataTable("SampleDataType"); 
//create column names as per the type in DB
dataTable.Columns.Add("startdate", typeof(DateTime)); 
dataTable.Columns.Add("enddate", typeof(DateTime));
dataTable.Columns.Add("SparePartID", typeof(Int32));  

//...
foreach (GridViewRow item in gvreserveparts.Rows)
{
    var chk = (CheckBox)item.FindControl("cbSelect");

    if (chk.Checked == true) //checkbox is checked
    {
        dataTable.Rows.Add("startDate", start); 
        dataTable.Rows.Add("endDate", end); 
//...
    }
}

var parameter = new SqlParameter(); 
//The parameter for the SP must be of SqlDbType.Structured 
parameter.ParameterName="@Sample"; 
parameter.SqlDbType = System.Data.SqlDbType.Structured; 
parameter.Value = dataTable; 

var conn = new OleDbConnection(connectionInfo);
var cmd = new OleDbCommand();
cmd.Parameters.Add(parameter); 

conn.Open();

cmd.Connection = conn;
cmd.CommandType = CommandType.StoredProcedure;
cmd.CommandText = "spReservePart";

cmd.ExecuteNonQuery();

conn.Close();