将它移到 for 循环之外。它不依赖于i:maxcor <- names(which.max(sapply(A[,-1, drop=F], function(x) cor(A[, 1], x) )))
r <- 10 # rows
n <- 6 # columns
library(microbenchmark)
microbenchmark(OP = {
A <- data.frame(matrix(rnorm(r*n),nrow=r)) # original data frame
B <- data.frame(matrix(nrow=r,ncol=n)) # results
B[,1] <- A[,1]
for (i in 2:n) {
maxcor <- names(which.max(sapply(A[,-1, drop=F], function(x) cor(A[, 1], x) )))
B[,i] <- A[,1] + A[,maxcor]
A[,1] <- B[,i]
A[,maxcor] <- NULL
}
},
ALEX= {
A2 <- data.frame(matrix(rnorm(r*n),nrow=r)) # original data frame
B2 <- data.frame(matrix(nrow=r,ncol=n)) # results
B2[,1] <- A2[,1]
A3 <- A2
maxcor <- sapply(A3[,-1, drop=F], function(x) cor(A3[, 1], x) )
cor_n <- names(A2)[order(maxcor, decreasing=T)]
for (i in 1:length(cor_n)) {
B2[,i+1] <- A2[,1] + apply(A2[,cor_n[1:i], drop= FALSE], 1, sum)
}
}, times=100L)
Unit: milliseconds
expr min lq mean median uq max neval cld
OP 1.779013 1.806192 1.915267 1.835082 1.941329 3.585394 100 b
ALEX 1.229343 1.253102 1.386429 1.300428 1.377404 2.925868 100 a
30% 的性能提升...这是数据A3 <- A2 的额外副本,显然可以删除