for循环中的函数和数组创建错误

Question

我正在使用一个名为 moment.js 的 JS 库来查找和消除在 start_time 和 stop_time 之间存在很大差距的事件。我一直收到这个错误——

TypeError: moment(...) 为空 var stopmoment1 = moment(data.events.event[x].stop_time).format("YYYY");

啊！！！

for (var x = 0; x

var position = new google.maps.LatLng(
  data.events.event[x]['latitude'],
  data.events.event[x]['longitude']);

// 控制台返回年份

console.log(moment(data.events.event[x].start_time).format("YYYY"));

// 但这里说 moment 返回 null

var startmoment1 = 时刻(data.events.event[x].start_time).format("YYYY"); var startmoment2 = moment(data.events.event[x].start_time).format("MM"); var startmoment3 = moment(data.events.event[x].start_time).format("DD");

var startmoment = moment([startmoment1,startmoment2,startmoment3]);

var stopmoment1 = moment(data.events.event[x].stop_time).format("YYYY"); var stopmoment2 = moment(data.events.event[x].stop_time).format("MM"); var stopmoment3 = moment(data.events.event[x].stop_time).format("DD");

var stopmoment = moment([stopmoment1,stopmoment2,stopmoment3]);

if (startmoment.diff(stopmoment, 'days') > 7) { } else{

if (moment().format("YYYYMMDD") == moment(data.events.event[x].start_time).format("YYYYMMDD")) {

  marker.push(new google.maps.Marker({
    position: position,
    map: map,
    icon: image
  }));

  marker[x].x = x;//make the marker aware of its own index

  google.maps.event.addListener(marker[x], 'click', function() {
    var div = document.createElement('div');
    div.setAttribute("id", "tabs-min");
    div.innerHTML = content[this.x];
    $(div).tabs();
    infowindow.setContent(div); 
    infowindow.open(map, this);
  });


} else {
  marker.push(new google.maps.Marker({
    position: position,
    map: map,
    icon: image1
  }));

  marker[x].x = x;//make the marker aware of its own index

  google.maps.event.addListener(marker[x], 'click', function() {
    var div = document.createElement('div');
    div.setAttribute("id", "tabs-min");
    div.innerHTML = content[this.x];
    $(div).tabs();
    infowindow.setContent(div); 
    infowindow.open(map, this);
  });   }

Answer 1

发出警报或 console.writeline 或调试它以找出 data.events.event[x].stop_time 的值。
您可能将 undefined 或空字符串传递给导致异常的时刻函数。

Answer 2

啊，closures in loops，你能看出下面2个代码sn-ps的区别吗？

for(i=0;i<10;i++){
  setTimeout(function(){
    console.log(i);//logs 10 every time
  },10);
}

还有正确的

for(i=0;i<10;i++){
  setTimeout((function(i){
    return function(){
      console.log(i);//logs 0,1,2,3,4...
    };
  }(i)),10);
}

[更新]

我已重新格式化您的代码，删除重复代码，添加日志，甚至将侦听器移动到单独的对象中，以便您可以调用它并传递关闭所需的变量，而不会在其中捕获可能的大变量，并拥有更强大的事件处理程序附件循环内：

var eventListeners={
  markerClick:function(myContent){
      return function(e) {
        var div = document.createElement('div');
        div.setAttribute("id", "tabs-min");
        div.innerHTML = myContent;
        $(div).tabs();
        infowindow.setContent(div);
        infowindow.open(map, this);
      };
    }
};

for (var x = 0; x < data.event.length; x++) {
  var position = new google.maps.LatLng(
          data.events.event[x]['latitude'],
          data.events.event[x]['longitude']);

  console.log("moment is:",moment);
  console.log("data.events is:", data.events);
  console.log("x is:",x);
  console.log("event at x is:",data.events.event[x]);
  console.log("start time is:",data.events.event[x].start_time);
  var startmoment1 = moment(data.events.event[x].start_time).format("YYYY");
  var startmoment2 = moment(data.events.event[x].start_time).format("MM");
  var startmoment3 = moment(data.events.event[x].start_time).format("DD");
  var startmoment = moment([startmoment1, startmoment2, startmoment3]);

  var stopmoment1 = moment(data.events.event[x].stop_time).format("YYYY");
  var stopmoment2 = moment(data.events.event[x].stop_time).format("MM");
  var stopmoment3 = moment(data.events.event[x].stop_time).format("DD");
  var stopmoment = moment([stopmoment1, stopmoment2, stopmoment3]);

  if (!(startmoment.diff(stopmoment, 'days') > 7)) {
    marker.push(new google.maps.Marker({
      position: position,
      map: map,
  //no need for the if statement, only thing different is the image
  //but you are repating a lot of other code like adding and defining the handler
      icon: (moment().format("YYYYMMDD") ===
              moment(data.events.event[x].start_time).format("YYYYMMDD")) ?
              image : image1
    }));
    google.maps.event.addListener(marker[x], 'click', 
      eventListeners.markerClick(content[x]));
  }
}