如何将子程序中的参数传递给 VBA 中的函数？

Question

我正在尝试寻找值来为票证核对过程创建最终票证号。这是应该发生的：

子程序在单元格“Gx”中查找值

• 如果它找到一个值
  • 将值传递给函数以去除字母，转换为数字，传回子程序以放入 单元格“Ax”
• 如果没有值
  • 将“Cx”的值传递给函数等

这会根据填充在单独列中的行数循环遍历我在工作表中的单元格。

该函数本身在工作表中工作正常，但是当我从子例程列中传递一个值时，A 会填满行数，即。 A37=37，A8=8。我认为我没有将参数正确地传递给函数，但我不确定。下面是子程序和函数的代码：

    Sub final_ticket_number()
    Dim rw As Integer
    Dim i As Integer

    'header label
    Range("A1").Value = "Final Ticket #"

    'set number of rows for loop
    With Worksheets(1)
        rw = .Range("B2").End(xlDown).Row
    End With

    'check col G for empty, use col C as backup
    For i = 2 To rw
        If Not IsEmpty(Cells(i, "G")) Then
            'strip out letters in col G, place in col A
            Cells(i, "A").Value = getNumeric("G" & i)
        Else
            'strip out letters in col C, place in col A
            Cells(i, "A").Value = getNumeric("C" & i)
        End If
    Next i
    
    End Sub

    Function getNumeric(cellRef As String) As Long 'remove letters from ticket numbers
    Dim stringLength As Integer
    Dim i As Byte
    Dim Result As String
    stringLength = Len(cellRef)

    'loops through each character in a cell to evaluate if number or not
    For i = 1 To stringLength
        If IsNumeric(Mid(cellRef, i, 1)) Then
            Result = Result & Mid(cellRef, i, 1)
        End If
    Next i

    'convert remaining characters to number
    getNumeric = CLng(Result)

    End Function

我错过了什么？

Answer 1

据我了解，唯一错误的是您的 Len (cellRef)，在这里您只是通过了范围而不是他的值。看看我是怎么做的，我必须指定电子表格，做同样的工作。

使用 debug.print 查看变量的输出。写入代码“debug.print XvariableX”并在立即检查 (Ctrl + G) 中看到分配给变量的值。祝你好运。

Sub final_ticket_number()
Dim rw As Integer
Dim i As Integer

Range("A1").Value = "Final Ticket #"

With Worksheets(1)
    rw = .Range("B2").End(xlDown).Row
End With

For i = 2 To rw
    If Not IsEmpty(Cells(i, "G")) Then
        Cells(i, "A").Value = getNumeric("G" & i)
    Else
        Cells(i, "A").Value = getNumeric("C" & i)
    End If
Next i
End Sub

Function getNumeric(cellRef As String) As Long 'remove letters from ticket numbers
Dim stringLength As Integer
Dim i As Byte
Dim Result As String

Dim Wrs As String
Wrk = ActiveWorkbook.Name
Workbooks(Wrk).Activate
Wrs = ActiveSheet.Name
stringLength = Len(Workbooks(Wrk).Worksheets(Wrs).Range(cellRef))

For i = 1 To stringLength
    If IsNumeric(Mid(Workbooks(Wrk).Worksheets(Wrs).Range(cellRef), i, 1)) Then
        Result = Result & Mid(Workbooks(Wrk).Worksheets(Wrs).Range(cellRef), i, 1)
    End If
Next i

getNumeric = CLng(Result)
End Function