【发布时间】:2015-09-11 00:12:58
【问题描述】:
我正在尝试设置一个简单的 TCP 客户端。我不希望 main() 中的完整设置和连接代码,所以我试图将它移动到一个函数,但在 VS2015 中不断收到访问冲突错误,所有包含的内容都是正确的。该函数是从 MSDN 直接复制的。
argc = 2, argv[1] = "localhost", PORT = 27015
调用函数:
win32_connect(&argc, &argv, PORT);
接收函数:
win32_connect(int *argc, char** argv[], int port)
{
...
iResult = getaddrinfo(argv[1], port, &hints, &result); <- Access Violation
...
}
我只是想不出一个正确的方法来正确地将参数传递给函数,所以它就像我在 main() 中拥有整个函数时一样工作
头文件(cHeader):
#define _CRT_SECURE_NO_WARNINGS
#ifndef CHEADER_H
#define CHEADER_H
//- Includes
#include <sys/types.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <errno.h>
#include <fcntl.h>
//- OS specific includes
#ifdef _WIN32
#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <winsock2.h>
#include <ws2tcpip.h>
#pragma comment (lib, "Ws2_32.lib")
#pragma comment (lib, "Mswsock.lib")
#pragma comment (lib, "AdvApi32.lib")
#endif
....
main():
int main(int argc, char *argv[])
{
//- Define variables
int connected = 1;
int sockfd;
char cSend[BUF];
char cRecv[BUF];
//- Create socket + Connect to server
if ((sockfd = win32_connect(argc, argv, PORT)) < 0) {
printf("Failed to connect to server.");
exit(1);
}
...
}
cNetwork.c:
#include "cHeader.h"
#ifdef LINUX
...irrelevant unix code...
#endif
#ifdef _WIN32
int win32_connect(int argc, char* argv[], int port)
{
WSADATA wsaData;
SOCKET ConnectSocket = INVALID_SOCKET;
struct addrinfo *result = NULL,
*ptr = NULL,
hints;
char *sendbuf = "this is a test";
char recvbuf[BUF];
int iResult;
int recvbuflen = BUF;
// Validate the parameters
if (argc != 2) {
//printf("usage: %s server-name\n", argv[0]);
return 1;
}
// Initialize Winsock
iResult = WSAStartup(MAKEWORD(2, 2), &wsaData);
if (iResult != 0) {
printf("WSAStartup failed with error: %d\n", iResult);
return 1;
}
ZeroMemory(&hints, sizeof(hints));
hints.ai_family = AF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_protocol = IPPROTO_TCP;
// Resolve the server address and port
iResult = getaddrinfo(argv[1], port, &hints, &result);
if (iResult != 0) {
printf("getaddrinfo failed with error: %d\n", iResult);
WSACleanup();
return 1;
}
// Attempt to connect to an address until one succeeds
for (ptr = result; ptr != NULL; ptr = ptr->ai_next) {
// Create a SOCKET for connecting to server
ConnectSocket = socket(ptr->ai_family, ptr->ai_socktype,
ptr->ai_protocol);
if (ConnectSocket == INVALID_SOCKET) {
printf("socket failed with error: %ld\n", WSAGetLastError());
WSACleanup();
return 1;
}
// Connect to server.
iResult = connect(ConnectSocket, ptr->ai_addr, (int)ptr->ai_addrlen);
if (iResult == SOCKET_ERROR) {
closesocket(ConnectSocket);
ConnectSocket = INVALID_SOCKET;
continue;
}
break;
}
freeaddrinfo(result);
if (ConnectSocket == INVALID_SOCKET) {
printf("Unable to connect to server!\n");
WSACleanup();
return 1;
}
return ConnectSocket;
}
#endif
【问题讨论】:
-
哪一行代码触发了访问冲突?
-
在代码的其他问题中,
argc是一个简单的整数。您可以整天传递该整数,而无需获取它的地址。argv[]已经是一个指针。您可以整天传递该指针,而无需获取它的地址。 -
这一行:
#define _CRT_SECURE_NO_WARNINGS在“包含守卫”之前将导致该@define 的多个定义。通常,应该完全避免使用前导下划线,因为编译器会根据编译步骤在所有标识符前添加 1、2 或 3 个前导下划线。这种“用户”在源代码中提供的前导下划线会给编译器造成混淆。 (虽然大多数现代编译器都可以处理这个问题,但为什么要让事情变得困难) -
你可能想通过谷歌或维基百科查找“三星级程序员”的定义
-
函数:
win32_connect()在连接失败时返回“1”,但main()函数正在寻找返回值 ConnectSocket,该值将 > 0。建议更正函数之间的接口。
标签: c winsock getaddrinfo