【问题标题】:Memory Allocation Issues Passing/Returning a Struct *Array传递/返回结构 *Array 的内存分配问题
【发布时间】:2015-07-29 21:36:03
【问题描述】:

请帮我做作业。我已经让这个程序在调试模式下工作得很好,但是一旦我使用发布模式,它就会因 abort() 而崩溃。

我知道这可能与内存分配有关,但我对指针的理解不够好。

要求是我必须使用 *array 来动态分配内存。

“您的程序应该适用于任意数量的学生。当程序 开始,它应该询问用户的学生人数 处理。然后它应该动态分配一个该大小的数组 (学生/分数结构数组)。”

然后我需要,“调用一个函数来输入学生姓名/分数对并将它们存储在数组中。”

那么我应该在 main 中还是在函数内部创建数组?如何在不搞乱内存分配的情况下返回/传递 *array?

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

struct Student
{
    string name;    //student's name
    int score;      //student's score
};

//function prototypes
void inputNameScore(Student*, int&);
void sortArray(Student* , int);
double avgScore(Student* , int);
void displayTable(Student* , int, double);

int main()
{   
    Student* arrayOfStudentPtr;     //pointer of type student to receive returned array pointer
    int numberOfStudents;           //number of students to be entered by user
    double average;                 //total score average   

    cout << "Please enter the number of students: ";
    cin >> numberOfStudents;

    arrayOfStudentPtr = new Student[numberOfStudents];  //dynamic array of type Student assigned to pointer

    inputNameScore(arrayOfStudentPtr, numberOfStudents);
    sortArray(arrayOfStudentPtr, numberOfStudents);
    average = avgScore(arrayOfStudentPtr, numberOfStudents);

    displayTable(arrayOfStudentPtr, numberOfStudents, average);    

    return 0;
}

void inputNameScore(Student* arrayOfStudentPtr, int& numberOfStudents)
{   
    for (int i = 0; i < numberOfStudents; i++)
    {
        cout << endl << "Enter the name for student " << i + 1 << ": ";
        cin.ignore();
        getline(cin, arrayOfStudentPtr[i].name);
        cout << endl << "Enter the student's score: ";      
        cin >> arrayOfStudentPtr[i].score;
        while (arrayOfStudentPtr[i].score > 105 || arrayOfStudentPtr[i].score < 0)
        {
            cout << "Student's score can't be negative or greater than 105." << endl;
            cout << endl << "Enter the student's score: ";
            cin >> arrayOfStudentPtr[i].score;
        }
    }
}

void sortArray(Student* arrayOfStudentPtr, int numberOfStudents)
{
    Student Temp;   //holds a student struct object
    bool swap;      //swap is initialized to false at the start of each loop. If it is still false at end of loop we know there is nothing else to sort
    do
    {
        swap = false;
        for (int i = 0; i < numberOfStudents; i++)
        {
            if (arrayOfStudentPtr[i].score > arrayOfStudentPtr[i + 1].score)
            {
                Temp = arrayOfStudentPtr[i];
                arrayOfStudentPtr[i] = arrayOfStudentPtr[i + 1];
                arrayOfStudentPtr[i + 1] = Temp;
                swap = true;
            }
        }
    } while (swap);
}

double avgScore(Student* arrayOfStudentPtr, int numberOfStudents)
{
    int total;      //total of all grades
    double average; //average of all grades
    total = 0;

    for (int i = 0; i < numberOfStudents; i++)
    {
        total = arrayOfStudentPtr[i].score;
    }
    average = total / numberOfStudents;
    //average = static_cast<double>(total) / numberOfStudents;
    return average;
}

void displayTable(Student* arrayOfStudentPtr, int numberOfStudents, double average)
{   
    cout << endl << setw(31) << left << "Name" << setw(6) << right << "Score" << endl;
    cout << "-------------------------------------" << endl;
    for (int i = 0; i < numberOfStudents; i++)
    {
        cout << setw(31) << left << arrayOfStudentPtr[i].name << setw(6) << right << arrayOfStudentPtr[i].score << endl;
    }
    cout << "-------------------------------------" << endl;
    cout << setw(31) << left << "Average: " << setw(6) << right << endl;
}

【问题讨论】:

  • arrayOfStudentPtr[i + 1] in sortArray 将访问数组边界之外的元素,
  • 太好了,非常感谢您的回答!我可以从这里拿走。
  • 这是非常糟糕的风格。应避免使用指针和new。你是不是被你的班级强迫用这种方式编码?
  • 仅用于此作业。 《从 C++ 早期对象开始》一书在指针一章中有一个完整的部分,介绍如何为数组使用动态内存分配,以便我们可以让用户指定要创建的数组的大小。有人解释说,这是允许用户输入任意数量的内容的一种方式。它没有深入研究任何其他选择,我的导师也没有。

标签: c++ arrays pointers dynamic-memory-allocation


【解决方案1】:

以下代码将起作用。

void sortArray(Student* arrayOfStudentPtr, int numberOfStudents)
    {
        Student Temp;   //holds a student struct object
        bool swap;      //swap is initialized to false at the start of each loop. If it is still false at end of loop we know there is nothing else to sort
        do
        {
            swap = false;
            for (int i = 0; i < numberOfStudents-1; i++)
            {
                if (arrayOfStudentPtr[i].score > arrayOfStudentPtr[i + 1].score)
                {
                    Temp = arrayOfStudentPtr[i];
                    arrayOfStudentPtr[i] = arrayOfStudentPtr[i + 1];
                    arrayOfStudentPtr[i + 1] = Temp;
                    swap = true;
                }
            }
        } while (swap);
    }

【讨论】:

  • 谢谢,当我回到这里说 Marcinj 的建议帮助我解决了这个问题时,我刚刚完成了这个编译。我一直不敢相信,重新阅读这一章,并认为我的指针都错了:-(我猜是吸取了教训!
最近更新 更多