【问题标题】:Issues passing an ellement of an Array of Records to Temporary Array of Records将记录数组的元素传递给临时记录数组的问题
【发布时间】:2010-11-15 23:40:56
【问题描述】:

我是一名正在接受培训的新代码猴子,目前在处理数组和结构时遇到了问题。 目前我有一个主文件,其中声明了一个记录数组。我将该数组传递给一个外部函数,在该函数中对记录中的字段执行快速排序。主要是名字。我在将记录数组中的元素复制到排序算法的临时数组时遇到问题。我知道 C++ 确实有一个内置的 qsort 函数,但是对于我现在正在做的事情,我需要将算法按原样写出来。我只使用任何数组就能让它工作。

我在尝试使用 make 文件进行编译时遇到以下错误。

make
g++    -c -o main2.o main2.cpp
g++ -c externArray2.cpp -o externArray2.o
externArray2.cpp: In function ‘void copytemp(EmployeeRecord*, EmployeeRecord*, int, int)’:
externArray2.cpp:52: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:53: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:54: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:55: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:56: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:57: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:58: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:59: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
externArray2.cpp:60: error: cannot convert ‘float’ to ‘void*’ for argument ‘1’ to ‘void* memcpy(void*, const void*, size_t)’
make: *** [externArray2.o] Error 1

制作文件

test1:  main.o ExternArray.o
        g++ main.o ExternArray.o -o test1

externArray.o: ExternArray.cpp
        g++ -c ExternArray.cpp -o ExternArray.o

main.o: main.cpp
        g++ -c main.cpp -o main.o

头文件.h

#ifndef _INCL_GUARD
#define _INCL_GUARD
const int maxEmployee =10;
const int NAMES = 5;
const int LENGTH = 15;


typedef struct EmployeeRecord
{
char first[10];
char last[10];
float reghours;
float ovrhours;
float pay;
float gross;
float defer;
float state;
float fed;
float ssi;
float net;
} EmployeeRecord;
#endif

main.cpp

#include <iostream>
#include <cstring>
using namespace std;
#include "./Header2.h"

void showArray(EmployeeRecord employees[], int, const char*);  //Function Prototype 3.1

extern void qsortArray(EmployeeRecord employees[], int, int);     //Funvtion Prototype      3.2

int main(void)
{
    EmployeeRecord myEmployee[maxEmployee];
    strcpy(myEmployee[0].first,"John");
    strcpy(myEmployee[0].last,"Doe");
    strcpy(myEmployee[1].first,"Ed");
    strcpy(myEmployee[1].last, "Whittle");
    strcpy(myEmployee[2].first, "Louise");
    strcpy(myEmployee[2].last, "Marion");
    strcpy(myEmployee[3].first,"Paula");
    strcpy(myEmployee[3].last, "Prentiss");
    strcpy(myEmployee[4].first, "Carl");
    strcpy(myEmployee[4].last, "Davidson");


    showArray(myEmployee, NAMES, "Before Sort");
    qsortArray(myEmployee, 0, 4 );
    showArray(myEmployee, NAMES, "After Sort");

return 0;               
}



void showArray(EmployeeRecord employees[], int emp, const char *message)
{
cout << message << endl;
for (int test = 0; test < emp; test++)
    {
    cout << "First Name: " << employees[test].first << endl;
    cout << "Last Name: " << employees[test].last << endl;

    }
}

ExternArray.cpp

#include <cstring>
#include <iostream>
#include <iomanip>
#include <stdio.h>
using namespace std;
#include "./Header2.h"

void qsortArray(EmployeeRecord employees[], int, int);     //Funvtion Prototype         3.2

void copytemp(EmployeeRecord tmpEmp[], EmployeeRecord emp[], int, int);

void qsortArray(EmployeeRecord employees[], int start, int finish)
{

int left=start,
    right=finish;
char  pivot[15];
strcpy(pivot, employees[(start+finish)/2].first);
  while (left < right) {
  cout << pivot << " pivot " << endl;
  cout << "outer loop" << endl;
    // find left candidate
    while (strcmp(employees[left].first,pivot) <0) left++; 
    // find right candidate 
    cout << "First Inner Loop" << endl;
    while (strcmp(employees[right].first,pivot) > 0 )right--; 
    cout << "Inner Loop" << endl;
    if (left <= right) 
        {
        EmployeeRecord tmpEmployee[1];
        cout << "Create new struct" << endl;
        copytemp(tmpEmployee, employees, 0, left);
        cout << "copy to temp" << endl;
        copytemp(tmpEmployee, employees, 1, right);
        copytemp(employees, tmpEmployee, left, 1);
        copytemp(employees, tmpEmployee, right, 0);

        left++;
        right--;
        cout << "All copy done" <<endl;
        } 
  } // while left < right
  cout << "Back out of outer Loop" << endl;
  if (start < right) qsortArray(employees,start,right);
  if (left < finish) qsortArray(employees,left,finish);
}

void copytemp(EmployeeRecord tmpEmp[], EmployeeRecord emp[], int first, int secound)
{
memcpy(tmpEmp[first].first, emp[secound].first, sizeof(emp[secound].first));
memcpy(tmpEmp[first].last, emp[secound].last, sizeof(emp[secound].last));
memcpy(tmpEmp[first].reghours, emp[secound].reghours, sizeof(emp[secound].reghours));
memcpy(tmpEmp[first].ovrhours, emp[secound].ovrhours, sizeof(emp[secound].ovrhours));
memcpy(tmpEmp[first].pay, emp[secound].pay, sizeof(emp[secound].pay));
memcpy(tmpEmp[first].gross, emp[secound].gross, sizeof(emp[secound].gross));
memcpy(tmpEmp[first].defer, emp[secound].defer, sizeof(emp[secound].defer));
memcpy(tmpEmp[first].state, emp[secound].state, sizeof(emp[secound].state));
memcpy(tmpEmp[first].fed, emp[secound].fed, sizeof(emp[secound].fed));
memcpy(tmpEmp[first].ssi, emp[secound].ssi, sizeof(emp[secound].ssi));
memcpy(tmpEmp[first].net, emp[secound].net, sizeof(emp[secound].net));
}

【问题讨论】:

  • +1 提出了一个很好的问题。欢迎来到 SO :-)

标签: c++ arrays struct


【解决方案1】:

C 中,您可以使用简单的分配复制整个struct

tmpElm[first] = emp[secound];

这只有在结构包含指针成员时才有问题,这不是你的情况。

【讨论】:

  • 我已经按照您的建议进行了更改,现在程序没有问题。现在问题似乎出在我运行程序时。我现在收到中止陷阱错误消息。 "退出外部循环中止陷阱"
  • 我第一次看到这个消息......但我不做 C++。也许你最好问一个新问题
  • Ack 抱歉,我把 cout out 消息放出来了,以帮助我跟踪程序当前的位置/问题所在。" cout
  • “中止陷阱”(我不记得见过)意味着您的程序由于某种原因中止......我看到您使用EmployeeRecord tmpEmployee[1]; 为 1 名员工保留空间,然后尝试写给第二名员工copytemp(tmpEmployee, employees, 1, right);。注意你的索引。
【解决方案2】:

试试:

memcpy(&(tmpElm[first].first, &(emp[second].first), sizeof(emp[second].first));

不同之处在于您需要传递浮点地址而不是浮点值。

您可能会发现,在 C++ 中,您需要将运算符地址 (&amp;) 给您的浮点指针转换为 void,因为 C++ 的类型规则比 C 强。

memcpy((void *)&(tmpElm[first].first, (void *)&(emp[second].first), sizeof(emp[second].first));

当涉及到数组时,还有一些其他方法可以获取某物的地址,但这对于新程序员来说是最简单的。

【讨论】:

    猜你喜欢
    • 1970-01-01
    • 2014-02-24
    • 1970-01-01
    • 2012-10-02
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 2011-12-25
    相关资源
    最近更新 更多