【发布时间】:2018-01-13 15:39:14
【问题描述】:
我正在尝试通过示例用法来实现观察者模式,如下所示:
class Widget
{
class WidgetObserver
{
virtual void SomethingHappened(Widget&) { };
virtual void TextChanged(Widget&, const char*) { };
virtual void BoundsChanged(Widget&, const Rect&) { };
}
void AddObserver(WidgetObserver& observer)
{
observers.Add(observer);
}
virtual void OnSomthingHappened()
{
observers.Fire(&WidgetObserver::SomethingHappened, *this);
}
virtual void OnTextChanged(const char* text)
{
observers.Fire(&WidgetObserver::TextChanged, *this, text);
}
// Same for OnBoundsChanged(const Rect&)
ObserverList<Widget> observers;
}
class AnotherWidget : WidgetObserver
{
virtual void SomethingHappened(Widget& widget) override
{
std::cout << "Something happened with " widget.name() << std::endl;
}
// Implementations for TextChanged and BoundsChanged ...
}
void main()
{
Widget w;
AnotherWidget aw;
w.AddObserver(aw);
w.OnSomethingHappened();
}
现在我对ObserverList 的当前(部分)实现是:
template <typename TObserver>
class ObserverList
{
std::vector<TObserver*> observer_list;
void AddObserver(TObserver& observer) { observer_list.push_back(&observer); }
template <typename ...TArgs>
void Fire(void(TObserver::*func)(TArgs...), TArgs&& args)
{
for (TObserver* ob : observer_list)
{
(ob->*func)(std::forward<TArgs>(args)...);
}
}
}
这与 SomethingHappened 和 BoundsChanged 函数按预期工作一样,它们都通过引用而不是值传递其所有参数,但 TextChanged 其参数之一 (const char* text) 是通过值而不是传递参考。当我将其更改为 const char*& text 时,它会编译,但不能使用 MSVC++ 14.1 (Visual Studio 2017) 进行编译
error C2672: 'ObserverList<Widget::WidgetObserver>::Fire': no matching overloaded function found
error C2782: 'void ObserverList<Widget::WidgetObserver>::Fire(void (__thiscall Widget::WidgetObserver::* )(TArgs...),TArgs &&...)': template parameter 'TArgs' is ambiguous
好像编译器不喜欢传值的参数,有什么办法让它喜欢吗?
【问题讨论】:
-
@xskxzr 似乎工作和编译!我应该发布答案还是你会这样做?
标签: c++ variadic-templates perfect-forwarding