【问题标题】:Ruby Recursive Algorithm IssueRuby递归算法问题
【发布时间】:2017-02-26 14:51:18
【问题描述】:

研究算法:

Given a rows x cols screen and a sentence represented by a list of non-empty words, find how many times the given sentence can be fitted on the screen.

Note:

A word cannot be split into two lines.
The order of words in the sentence must remain unchanged.
Two consecutive words in a line must be separated by a single space.
Total words in the sentence won't exceed 100.
Length of each word is greater than 0 and won't exceed 10.
1 ≤ rows, cols ≤ 20,000.
Example 1:

Input:
rows = 2, cols = 8, sentence = ["hello", "world"]

Output: 
1

Explanation:
hello---
world---

The character '-' signifies an empty space on the screen.
Example 2:

Input:
rows = 3, cols = 6, sentence = ["a", "bcd", "e"]

Output: 
2

Explanation:
a-bcd- 
e-a---
bcd-e-

The character '-' signifies an empty space on the screen.
Example 3:

Input:
rows = 4, cols = 5, sentence = ["I", "had", "apple", "pie"]

Output: 
1

Explanation:
I-had
apple
pie-I
had--

The character '-' signifies an empty space on the screen.

这是我的代码:

def words_typing(sentence, rows, cols)
   count_words(sentence, rows, cols, cols, 0, 0)
end

def count_words(sentence, rows, cols, remaining_space, row_num, word_idx)
    return 0 if row_num == rows #keep going until out of rows, ends the recursion
    word_idx = 0 if word_idx == sentence.length  #reset the word back to the first

    if remaining_space >= sentence[word_idx].length
        if remaining_space == sentence[word_idx].length
            return 1 + count_words(sentence, rows, cols, remaining_space - sentence[word_idx].length, row_num, word_idx + 1 )
        else #greater than 1
            return 1 + count_words(sentence, rows, cols, remaining_space - sentence[word_idx].length - 1, row_num, word_idx + 1 )
        end
    else #move to a new line, reset remaining space
        return count_words(sentence, rows, cols, cols, row_num+1, word_idx)
    end 
end

代码的工作原理如下。 word_idx 是句子数组中单词的索引。剩余空间最初是列数。每当有足够的空间可以放下一个单词时,我都会返回 1 + 同一行上的函数调用以及下一个单词和剩余空间。如果剩余空间 >= 1 + 字长,那么我将考虑在两个连续单词之间有一个空格(这就是我有额外条件的原因)。

如果 word_idx 比句子数组长,它会重置为零。递归函数将继续运行,直到 row_num 现在大于问题中提供给我们的行数。

但是,此代码不起作用。我的输出通常大于正确答案,但从概念上讲,我似乎一切都好。有人发现我的方法有问题吗?

【问题讨论】:

    标签: ruby algorithm recursion


    【解决方案1】:

    这是因为你计算的是单词而不是句子。

    def words_typing(sentence, rows, cols)
       count_words(sentence, rows, cols, cols, 0, 0, 0)
    end
    
    def count_words(sentence, rows, cols, remaining_space, row_num, word_idx, number_of_sentences)
        nos = number_of_sentences
        return nos if row_num == rows #keep going until out of rows, ends the recursion
    
        if word_idx == sentence.length  #reset the word back to the first
        word_idx = 0 
        nos = number_of_sentences+1
        end
        if remaining_space >= sentence[word_idx].length
    
            if remaining_space == sentence[word_idx].length
    
                return count_words(sentence, rows, cols, remaining_space - sentence[word_idx].length, row_num, word_idx + 1, nos )
            else #greater than 1
    
                return count_words(sentence, rows, cols, remaining_space - sentence[word_idx].length - 1, row_num, word_idx + 1 , nos)
            end
        else #move to a new line, reset remaining space
    
            return count_words(sentence, rows, cols, cols, row_num+1, word_idx, nos)
        end 
    end
    
    
    rows = 3
     cols = 6
     sentence = ["a", "bcd", "e"]
    words_typing(sentence, rows, cols)
    rows = 4; cols = 5; sentence = ["I", "had", "apple", "pie"]
    words_typing(sentence, rows, cols)
    

    我引入了一个新的变量/参数(最后一个),它包含句子的数量(从 0 开始)。当word_idx == sentence.length 表示新句子适合剩余空间,因此nos = number_of_sentences+1
    最后我们返回 nos(句子数)。

    【讨论】:

    • 太好了——谢谢。它现在适用于大多数输入。但是,在较大的测试用例中,我得到一个堆栈太深的错误。我试图找出原因——我只进行一次递归调用,具体取决于是否可以以正确的方式放下一个词……所以我的算法在其他地方效率低下吗?
    • @Sunny 你对每个合适的单词进行一次递归调用 + 我认为是 1。例如#1(rows=3, cols=6, sentence=[a,bcd,e]) = 10 次调用,example#2(rows=4, cols=5, sentence=[I, had, apple, pie ]) = 11 次通话。并且 Ruby 不是(我不知道 Ruby 语言的当前状态)对功能非常友好,所以你不应该使用太多的递归。您可以尝试提高堆栈级别或使用“尾调用优化”[您可以打开它](不确定它是否会在这种情况下工作)。这是一个很好的链接,可以解释它rpanachi.com/2016/05/30/…
    【解决方案2】:

    由于您的问题已经确定,我想提出另一种编写方法的方法。

    def sentences_per_page(rows, cols, sentence)
      nbr_sentences = 0
      last_word_index = sentence.size-1
      loopy = sentence.each_with_index.cycle
      word, idx = loopy.next
      rows.times do
        cols_left = cols
        while cols_left >= word.size
          cols_left -= (word.size + 1)
          nbr_sentences += 1 if idx == last_word_index
          word, idx = loopy.next
        end
      end
      nbr_sentences
    end
    
    rows = 4
    cols = 5
    sentence = ["I", "had", "apple", "pie"]
    puts                    "    rows      sentences"
    (1..12).each { |n| puts "     %d           %d" %
      [n, sentences_per_page(n, cols, sentence)] }
    rows      sentences
      1           0
      2           0
      3           1
      4           1
      5           1
      6           2
      7           2
      8           2
      9           3
     10           3
     11           3
     12           4
    

    我使用了Array#cycle的方法。对于上面定义的sentence

    loopy = sentence.each_with_index.cycle
      #=> #<Enumerator: #<Enumerator: ["I", "had", "apple", "pie"]:each_with_index>:cycle> 
    loopy.first 10
      #=> [["I", 0], ["had", 1], ["apple", 2], ["pie", 3],
      #    ["I", 0], ["had", 1], ["apple", 2], ["pie", 3],
      #    ["I", 0], ["had", 1]]  
    

    【讨论】:

      猜你喜欢
      • 2012-12-25
      • 2021-10-14
      • 2017-09-13
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      相关资源
      最近更新 更多