为 PHP 表单合并两个按钮。提交成功但更新按钮提示错误答案

【问题标题】：Incorporating Two Buttons for PHP Form. Submit succeed but Update button prompt error为 PHP 表单合并两个按钮。提交成功但更新按钮提示错误
【发布时间】：2020-01-30 15:32:50
【问题描述】：

我有两个按钮为我的 PHP 表单提供服务，即“更新”和“提交”按钮。现在，问题出在更新按钮上。很抱歉问了一些可能感觉很愚蠢的问题，但我无法让我的更新按钮正常工作。当我点击更新按钮时，它会返回这样的错误

注意：未定义索引：第 241 行 C:\xampp\htdocs\dataentry\user\edit_draft.php 中的 id

第 241 行是

$sql ="SELECT *FROM iir_incidentmain_draft WHERE event_id='$_GET[id]'";

我不知道出了什么问题，因为我编写的代码实际上与提交报告相同，但不能用于更新。以下是我的代码的三个相关页面。

draft.php

<div class="col-md-9 bg-white padding-2">

  <h3>Reports in Draft</h3>
  <div class="row margin-top-20">
    <div class="col-md-12">
      <div class="box-body table-responsive no-padding">
        <table id="example" class="table table-striped table-bordered" style="width:100%">
          <thead>
            <th>Incident Date</th>
            <th>OPU Region Or Country</th>
            <th>Incident Title</th>
            <th>Incident Category</th>
            <th>Status</th>
            <th>Draft IIR</th>
            <th>Edit</th>
          </thead>
          <tbody>
<?php
    $sql = "SELECT * FROM iir_incidentmain_draft WHERE username='" . $_SESSION['user']['username'] . "'";

    $result = $conn->query($sql);

    //If Job Post exists then display details of post
    if($result->num_rows > 0) {
        while($row = $result->fetch_assoc()) {
?>
              <tr>
                <td>
                  <?php echo date("y-m-d", strtotime($row['incident_date'])); ?>
                </td>
                <td>
                  <?php echo $row['opus']; ?>
                </td>
                <td>
                  <?php echo $row['incident_title']; ?>
                </td>
                <td>
                  <?php echo $row['incident_category']; ?>
                </td>
                <td>
                  <?php echo $row['status']; ?>
                </td>
                <td><a href="iir_draft.php?id=<?php echo $row['incident_id']; ?>">&nbsp; &nbsp; <i class="fa fa-files-o"></i></a></td>
                <td><a href="edit_draft.php?id=<?php echo $row['incident_id']; ?>">&nbsp; &nbsp; <i class="fa fa-edit"></i></a></td>
<?php
        }
    }
?>
          </tbody>
        </table>
      </div>
    </div>
  </div>

</div>

这个是edit_draft.php（包含两个按钮的长格式。我已经缩短了）

<form action="submit.php" method="POST">
<?php
    $sql ="SELECT *FROM iir_incidentmain_draft WHERE incident_id='$_GET[id]'";
    $result = $conn->query($sql);
    if($result->num_rows > 0) {
        while($row = $result->fetch_assoc()) { 
?>

    <div class="col-md-12">
      <div class="form-group row">
        <label for="incident_title" class="col-md-2 col-form-label">Incident Title : <font color="red">*</font></label>
        <div class="col-md-10">
          <input type="text" id="incident_title" name="incident_title" class="form-control" value="<?php echo $row1['incident_title']; ?>">
        </div>
      </div>


      <div class="form-group row">
        <label for="incident_description" class="col-md-2 col-form-label">Incident Description : <font color="red">*</font></label>
        <div class="col-md-10">
          <textarea rows="4" cols="50" id="incident_description" name="incident_description" class="form-control" placeholder="(What, When, Where, Why, How?) (Explain in full including dates, location, cause and action)"><?php echo $row1['incident_description']; ?></textarea>
        </div>
      </div>

      <div class="form-group row">
        <label for="incident_description" class="col-md-2 col-form-label">Witness : </label>
        <div class="col-md-10">
          <textarea rows="2" cols="50" id="witness" name="witness" class="form-control"><?php echo $row1['witness']; ?></textarea>
        </div>
      </div>

      <--some more details->

        <div align="right" class="bottom">
          <button type="update" class="btn btn-dark" id="update" formaction="update_draft.php">Update Draft</button>
          <button type="submit" class="btn btn-dark">Submit Report</button>
        </div>
<?php
        }
    }
?>
</form>

这里是 update_draft.php

<?php
session_start();

if (empty($_SESSION['user'])) {
    header ("Location:../index.php");
    exit();
}

require_once("db.php");

if (isset($_GET['idpost']) && is_numeric($_GET['idpost'])) {

    $incident_id = $_POST['idpost'];
    $username= $_SESSION['user']['username'];
    $incident_title = mysqli_real_escape_string($conn, $_POST['incident_title']);
    $incident_description = mysqli_real_escape_string($conn, $_POST['incident_description']);
    $witness = mysqli_real_escape_string($conn, $_POST['witness']);
    $incident_date = mysqli_real_escape_string($conn, $_POST['incident_date']);
    $incident_year =  mysqli_real_escape_string($conn, $_POST['incident_year']);
    $incident_month = mysqli_real_escape_string($conn, $_POST['incident_month']);
    $monsoon = mysqli_real_escape_string($conn, $_POST['monsoon']);
    $holiday = mysqli_real_escape_string($conn, $_POST['holiday']);
    $incident_time = mysqli_real_escape_string($conn, $_POST['incident_time']);
    $time_hourly = mysqli_real_escape_string($conn, $_POST['time_hourly']);
    $time_category = mysqli_real_escape_string($conn, $_POST['time_category']);
    $incident_location = mysqli_real_escape_string($conn, $_POST['incident_location']);
    $latitude = mysqli_real_escape_string($conn, $_POST['latitude']);
    $longitude = mysqli_real_escape_string($conn, $_POST['longitude']);
    $incident_worksite = mysqli_real_escape_string($conn, $_POST['incident_worksite']);
    $country = mysqli_real_escape_string($conn, $_POST['country']);
    $state = mysqli_real_escape_string($conn, $_POST['state']);  
    $onshoreoffshore = mysqli_real_escape_string($conn, $_POST['onshoreoffshore']);
    $vessel = mysqli_real_escape_string($conn, $_POST['vessel']);
    $incident_type = mysqli_real_escape_string($conn, $_POST['incident_type']);
    $incident_category = mysqli_real_escape_string($conn, $_POST['incident_category']);
    $accident_type = mysqli_real_escape_string($conn, $_POST['accident_type']);
    $day_lost_time = mysqli_real_escape_string($conn, $_POST['daylosttime']);
    $estimated_cost = mysqli_real_escape_string($conn, $_POST['estimatedcost']);
    $actual_cost = mysqli_real_escape_string($conn, $_POST['actualcost']);
    $spill_voll = mysqli_real_escape_string($conn, $_POST['spillvolume']);
    $production_loss = mysqli_real_escape_string($conn, $_POST['productionloss']);
    if($_POST['productionunit']=="OTHER") {
        $production_unit = mysqli_real_escape_string($conn, $_POST['productionunit2a']);
    } else {
        $production_unit = mysqli_real_escape_string($conn, $_POST['productionunit']);
    }
    $downtime = mysqli_real_escape_string($conn, $_POST['downtime']);
    $impact_to = mysqli_real_escape_string($conn, $_POST['impactto']);
    $sector = mysqli_real_escape_string($conn, $_POST['sector']);
    $department = mysqli_real_escape_string($conn, $_POST['department']);
    $business_group = mysqli_real_escape_string($conn, $_POST['business_group']);  
    $business_section = mysqli_real_escape_string($conn, $_POST['business_section']);
    $opus = mysqli_real_escape_string($conn, $_POST['opus']);  
    $domestic_international = mysqli_real_escape_string($conn, $_POST['project_name']);
    $project_name = mysqli_real_escape_string($conn, $_POST['project_name']);
    $project_phase = mysqli_real_escape_string($conn, $_POST['project_phase']);
    $project_start_date = mysqli_real_escape_string($conn, $_POST['project_start_date']);
    $project_end_date= mysqli_real_escape_string($conn, $_POST['project_end_date']);
    $project_type = mysqli_real_escape_string($conn, $_POST['project_type']);

    if($_POST['contractor']=="ifothers") {
        $contractor = mysqli_real_escape_string($conn, $_POST['contractor2']);
    } else {
        $contractor = mysqli_real_escape_string($conn, $_POST['contractor']);
    }

    $sub_contractor = mysqli_real_escape_string($conn, $_POST['sub_contractor']);
    $name = mysqli_real_escape_string($conn, $_POST['injuriousname']);
    $staff_no = mysqli_real_escape_string($conn, $_POST['staff_no']);
    $staff_department = mysqli_real_escape_string ($conn, $_POST['staff_department']);
    $nationality = mysqli_real_escape_string($conn, $_POST['nationality']);
    $age_number = mysqli_real_escape_string($conn, $_POST['age']);
    $age_range = mysqli_real_escape_string($conn, $_POST['agerange']);
    $gender = mysqli_real_escape_string($conn, $_POST['gender']);
    $work_trade = mysqli_real_escape_string($conn, $_POST['worktrades']);
    $years_of_experience = mysqli_real_escape_string($conn, $_POST['yearsexp']);
    $imm_supervisor_name = mysqli_real_escape_string($conn, $_POST['supervisor']);
    $desc_of_injury = mysqli_real_escape_string($conn, $_POST['injuries_description']);
    $body_part = mysqli_real_escape_string($conn, $_POST['bodypart']);
    $body_part_group = mysqli_real_escape_string($conn, $_POST['bodypartgroup']);
    $hours_in_shift = mysqli_real_escape_string($conn, $_POST['hoursinshift']);
    $days_in_tour = mysqli_real_escape_string($conn, $_POST['daysintour']);
    $hse_risk = mysqli_real_escape_string($conn, $_POST['hserisks']);
    $critical_activity = mysqli_real_escape_string($conn, $_POST['critical_activity']);
    $sub_critical = mysqli_real_escape_string($conn, $_POST['sub_activity']);
    $hazard = mysqli_real_escape_string($conn, $_POST['hazard']);
    $hazard_number = mysqli_real_escape_string($conn, $_POST['hazardnumber']);
    $sub_hazard = mysqli_real_escape_string($conn, $_POST['subhazard']);
    $sub_hazard_no = mysqli_real_escape_string($conn, $_POST['subhazardnumber']);
    $failed_missing_barrier = mysqli_real_escape_string($conn, $_POST['barrier']);
    $ic_description1 = mysqli_real_escape_string($conn, $_POST['ic_description1']);
    $precondition1 = mysqli_real_escape_string($conn, $_POST['precondition1']);
    $uauc1 = mysqli_real_escape_string($conn, $_POST['uauc1']);
    $root_cause_latern_failure1 = mysqli_real_escape_string($conn, $_POST['ic_description1']);
    $brf1 = mysqli_real_escape_string($conn, $_POST['riskfactor1']);
    $ic_description2 = mysqli_real_escape_string($conn, $_POST['ic_description2']);
    $precondition2 = mysqli_real_escape_string($conn, $_POST['precondition2']);
    $uauc2 = mysqli_real_escape_string($conn, $_POST['uauc2']);
    $root_cause_latern_failure2 = mysqli_real_escape_string($conn, $_POST['ic_description2']);
    $brf2 = mysqli_real_escape_string($conn, $_POST['riskfactor2']);
    $ic_description3 = mysqli_real_escape_string($conn, $_POST['ic_description3']);
    $precondition3 = mysqli_real_escape_string($conn, $_POST['precondition3']);
    $uauc3 = mysqli_real_escape_string($conn, $_POST['uauc3']);
    $root_cause_latern_failure3 = mysqli_real_escape_string($conn, $_POST['ic_description3']);
    $brf3 = mysqli_real_escape_string($conn, $_POST['riskfactor3']);
    $ic_description4 = mysqli_real_escape_string($conn, $_POST['ic_description4']);
    $precondition4 = mysqli_real_escape_string($conn, $_POST['precondition4']);
    $uauc4 = mysqli_real_escape_string($conn, $_POST['uauc4']);
    $root_cause_latern_failure4 = mysqli_real_escape_string($conn, $_POST['ic_description4']);
    $brf4 = mysqli_real_escape_string($conn, $_POST['riskfactor4']);
    $immediateaction = mysqli_real_escape_string($conn, $_POST['immediateaction']);
    $person_responsible = mysqli_real_escape_string($conn, $_POST['person_responsible']);
    $completion_date = mysqli_real_escape_string($conn, $_POST['completion_date']);
    $permanentaction = mysqli_real_escape_string($conn, $_POST['permanentaction']);
    $person_responsible1 = mysqli_real_escape_string($conn, $_POST['person_responsible1']);
    $completion_date1 = mysqli_real_escape_string($conn, $_POST['completion_date1']);
    $managementaction = mysqli_real_escape_string($conn, $_POST['managementaction']);
    $person_responsible2 = mysqli_real_escape_string($conn, $_POST['person_responsible2']);
    $completion_date2 = mysqli_real_escape_string($conn, $_POST['completion_date2']);
    $ratingperson = mysqli_real_escape_string($conn, $_POST['ratingperson']);
    $ratingenvironment = mysqli_real_escape_string($conn, $_POST['ratingenvironment']);
    $ratingasset = mysqli_real_escape_string($conn, $_POST['ratingasset']);
    $ratingreputation = mysqli_real_escape_string($conn, $_POST['ratingreputation']);
    $ratingsecurity = mysqli_real_escape_string($conn, $_POST['ratingsecurity']);
    $report_status = mysqli_real_escape_string($conn, $_POST['report_status']);

    $file = count($_FILES['file']['name']);

    for( $i=0 ; $i < $file ; $i++ ){
        $tmpFilePath = $_FILES['file']['tmp_name'][$i];

        if ($tmpFilePath != ""){
            $newFilePath = "../uploads/attachment/report" . $_FILES['file']['name'][$i];

            //Upload the file into the temp dir
            if(move_uploaded_file($tmpFilePath, $newFilePath)) {
                echo "Uploads success";
            }   else {
                echo "Failed to upload";
                //header ("Location: newentry.php");
                exit();
            } 
        }
    }

    $sql = "UPDATE iir_incidentmain_draft 
            SET incident_title = '".$incident_title."', 
                incident_description = '".$incident_description."', 
                witness = '".$witness."', 
                incident_date = '".$incident_date."', 
                incident_year ='".$incident_year."', 
                incident_month = '".$incident_month."', 
                monsoon ='".$monsoon."', 
                holiday = '".$holiday."', 
                incident_time = '".$incident_time."', 
                time_hourly = '".$time_hourly."', 
                time_category = '".$time_category."', 
                incident_location = '".$incident_location."', 
                latitude = '".$latitude."', 
                longitude = '".$longitude."', 
                incident_worksite = '".$incident_worksite."', 
                country = '".$country."', 
                state = '".$state."', 
                onshoreoffshore = '".$onshoreoffshore."', 
                vessel = '".$vessel."', 
                incident_type = '".$incident_type."', 
                incident_category = '".$incident_category."', 
                accident_type = '".$accident_type."', 
                day_lost_time = '".$day_lost_time."', 
                estimated_cost'".$estimated_cost."', 
                actual_cost='".$actual_cost."', 
                spill_voll='".$spill_voll."', 
                production_loss='".$production_loss."', 
                production_unit='".$production_unit."', 
                downtime='".$downtime."', 
                impact_to='".$impact_to."', 
                sector='".$sector."', 
                department='".$department."', 
                business_group='".$business_group."', 
                business_section='".$business_section."', 
                opus='".$opus."', 
                domestic_international = '".$domestic_international."', 
                project_name = '".$project_name."', 
                project_phase = '".$project_phase."', 
                project_start_date = '".$project_start_date."', 
                project_end_date = '".$project_end_date."', 
                project_type = '".$project_type."', 
                contractor = '".$contractor."', 
                sub_contractor = '".$sub_contractor."', 
                name = '".$name."', 
                staff_no = '".$staff_no."', 
                staff_department = '".$staff_department."', 
                nationality = '".$nationality."', 
                age_number = '".$age_number."', 
                age_range = '".$age_range."', 
                gender = '".$gender."', 
                work_trade = '".$work_trade."', 
                years_of_experience = '".$years_of_experience."', 
                imm_supervisor_name = '".$imm_supervisor_name."', 
                desc_of_injury = '".$desc_of_injury."', 
                body_part = '".$body_part."', 
                body_part_group = '".$body_part_group."', 
                hours_in_shift = '".$hours_in_shift."', 
                days_in_tour = '".$days_in_tour."', 
                hse_risk = '".$hse_risk."', 
                critical_activity = '".$critical_activity."', 
                sub_critical = '".$sub_critical."', 
                hazard = '".$hazard."', 
                hazard_number = '".$hazard_number."', 
                sub_hazard = '".$sub_hazard."', 
                sub_hazard_no = '".$sub_hazard_no."', 
                failed_missing_barrier = '".$failed_missing_barrier."', 
                ic_description1 = '".$ic_description1."',
                precondition1 = '".$precondition1."', 
                uauc1='".$uauc1."', root_cause_latern_failure1 = '".$root_cause_latern_failure1."', 
                brf1 = '".$brf1."', 
                ic_description2 = '".$ic_description2."', 
                precondition2 = '".$precondition2."', 
                uauc2 = '".$uauc2."', 
                root_cause_latern_failure2 = '".$root_cause_latern_failure2."', 
                brf2 = '".$brf2."', 
                ic_description3 = '".$ic_description3."',  
                precondition3 = '".$precondition3."', 
                uauc3 = '".$uauc3."', 
                root_cause_latern_failure3 = '".$root_cause_latern_failure3."', 
                brf3 = '".$brf3."', 
                ic_description4 = '".$ic_description4."', 
                precondition4 = '".$precondition4."', 
                uauc4 = '".$uauc4."', 
                root_cause_latern_failure4 = '".$root_cause_latern_failure4."', 
                brf4 = '".$brf4."', 
                immediateaction = '".$immediateaction."', 
                person_responsible = '".$person_responsible."', 
                completion_date = '".$completion_date."', 
                permanentaction = '".$permanentaction."', 
                person_responsible1 ='".$person_responsible1."', 
                completion_date1 = '".$completion_date1."', 
                managementaction = '".$managementaction."', 
                person_responsible2 = '".$person_responsible2."', 
                completion_date2 = '".$completion_date2."', 
                ratingperson = '".$ratingperson."', 
                ratingenvironment = '".$ratingenvironment."', 
                ratingasset = '".$ratingasset."', 
                ratingreputation = '".$ratingreputation."', 
                ratingsecurity = '".$ratingsecurity."', 
                report_status = '".$report_status."', 
                file = '".$file."' 
        WHERE incident_id = '".$id."'"; 

    $result = mysqli_query($conn, $sql) or die (mysqli_error($conn)); 

    if(!$result)    { 
        die('Could not update data: '.  mysqli_error()); 
        header("Location: edit_draft.php");
        exit();
    } else { 
        $_SESSION['DraftEditSuccess'] = true;
        header("Location: draft.php");
        exit();
    } 
} else {
    header("Location:edit_draft.php");
    exit();
}


?>

我已经按照建议尝试了多种解决方案 One form two buttons Two Submits Button 还有更多，但它不起作用。我希望有人可以指导我，我很抱歉我还在学习。

【问题讨论】：

@CarlBinalla 错误在这部分 $sql ="SELECT *FROM iir_incidentmain_draft WHERE event_id='$_GET[id]'";
@WanHazyan 你是在打开edit_draft.php而不是从draft.php 重定向吗？
试试这个$get =$_GET['id']; if(empty($get)){ echo "ID is empty";}
假设从draft.php中获取想要的报告部分以打开edit_draft.php的表单，如果成功则重定向到draft.php，如果失败则返回edit_draft.php
您的脚本对SQL Injection Attack 开放。即使是if you are escaping inputs, its not safe!，您也应该考虑在MYSQLI_ 或PDO API 中使用prepared parameterized statements，而不是连接值

标签： php html

【解决方案1】：

在 update_draft.php 中，您在更新失败时重定向到 edit_draft.php，但是当您这样做时

header("Location: edit_draft.php");

您没有添加id=something 参数。因此，您会收到一条错误消息

注意：未定义索引：第 241 行 C:\xampp\htdocs\dataentry\user\edit_draft.php 中的 id

你没有显示足够的代码让我确定你应该做什么，但是要么为重定向添加一个适当的值，比如

header("Location: edit_draft.php?id=$someRelevantValue");

或者您将不得不修改edit_draft.php 中的控制代码，以便能够处理在没有id 存在的情况下调用的页面。

说实话，我不确定当数据库的 UPDATE 失败时返回 edit_update.php 是不是最好的办法

【讨论】：

所以！在您发表评论后，所有 3 个答案都是正确的！您的评论与edit_draft.php 中的WHERE incident_id='$_GET[id]'"; 或update_draft.php 中的WHERE incident_id = '".$incident_id."'"; 无关：)

【解决方案2】：

改变这个

if (isset($_GET['idpost']) && is_numeric($_GET['idpost']))
{

到

if (isset($_GET['idpost']) && is_numeric($_GET['idpost']))
{ $id = $_GET['idpost'];

此$id 变量未在您的整个代码WHERE incident_id = '".$id."'"; 中设置

更新：

我没有在你的帖子中看到$incident_id = $_POST['idpost'];。

改一下就行了

$incident_id = $_POST['idpost'];

到

$incident_id = $_GET['idpost'];

和

中的这一行

WHERE incident_id = '".$id."'";`

到

WHERE incident_id = '$incident_id'";

注意：我的第一个示例运行良好。

mysqli mysqli_fetch_assoc() expects parameter / Call to a member function bind_param() errors. How to get the actual mysql error and fix it?的错误报告需要查看这篇文章

【讨论】：

那么，我应该先在哪里声明该部分？在我的 update_draft.php 或 edit_draft.php 中？
update_draft.php 并且您需要通过 url 将 id 传递给 update_draft.php 看起来您的 id 是空的，请在您的问题下尝试我的评论。
好的。谢谢你。我会尝试这个解决方案。
edit_draft.php 没有对$_GET['idpost'] 的任何引用所以这对解决问题中的实际问题没有任何帮助
@RiggsFolly 我的回答是关于update_draft.php 而不是edit_draft.php 我告诉OP 在我的问题评论中检查它是否为空！是的，edit_draft.php 也一样 incident_id='$_GET[id]'"; 正如我在之前的评论中所说您需要通过 url 将 id 传递给 update_draft.php OP 需要为 edit_draft.php 这样做很好，我评论说，根据问题要求为 id 做 if 语句。所以不想在我的回答中再次重复这一点。我的错。

【解决方案3】：

更改此代码：

$sql ="SELECT * FROM iir_incidentmain_draft WHERE incident_id='$_GET[id]'";

到这里：

$get=$_GET['idpost'];
$sql ="SELECT * FROM iir_incidentmain_draft WHERE incident_id='$get'";

如您所见，您在$_GET[id] 到$_GET['idpost'] 上错了

【讨论】：

@CarlBinalla 我创建了变量以突出显示错误并使其更易于理解
@Dilek 你为什么这么说？
因为$_GET['idpost']
建议更改