【发布时间】：2017-02-02 10:29:58
【问题描述】：
刚开始学习多线程，陷入了并发修改的境地。
这是我的 Java 类
package ashish.demo.threading.basic;
import java.util.ArrayList;
import java.util.ConcurrentModificationException;
import java.util.List;
/**
* Created by ashishratan on 2/2/17.
*/
public class ItemTask implements Runnable {
private volatile boolean shutdown;
private List<Item> itemList = new ArrayList<Item>();
private volatile Item item;
private volatile boolean addItemEvent;
private volatile boolean removeItemEvent;
@Override
public void run() {
while (!this.shutdown) {
try {
synchronized (this) {
if (this.item != null) {
this.item.setProductName("Created By:: " + Thread.currentThread().getName());
}
if (this.addItemEvent) {
this.itemList.add(this.item);
this.item=null;
this.addItemEvent = false;
this.statusDisplay();
}
if (this.removeItemEvent) {
this.itemList.add(this.item);
this.removeItemEvent = false;
this.statusDisplay();
}
}
Thread.sleep(100);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
System.out.println("Shutting down...");
}
public void addItem(Item item) {
this.item = item;
this.addItemEvent = true;
}
public synchronized List<Item> getItemList() {
this.statusDisplay();
return itemList;
}
public void setItemList(List<Item> itemList) {
this.itemList = itemList;
}
public synchronized void shutdownHook() {
this.statusDisplay();
this.shutdown = true;
System.out.println(this.getItemList());
}
private synchronized void statusDisplay() {
System.out.println(Thread.currentThread());
System.out.println("Total Items In Stock are " + this.itemList.size());
}
}
跑步者类
package ashish.demo.threading;
import ashish.demo.threading.basic.Item;
import ashish.demo.threading.basic.ItemTask;
import java.util.Scanner;
public class Main {
public static void main(String[] args) {
ItemTask itemTask = new ItemTask();
Thread thread =null;
for (int i = 0; i < 500; i++) {
thread=new Thread(itemTask);
thread.setName("ItemTask-Thread-"+(i+1));
thread.setPriority(Thread.MAX_PRIORITY);
thread.start();
}
System.out.println("Please Enter Number (0) to exit");
Scanner scanner = new Scanner(System.in);
int i = scanner.nextInt();
while (i>0){
itemTask.addItem(new Item(1,12.0f,"Product "+i,(byte)12));
System.out.println(itemTask.getItemList()); // Line #26, Exception
System.out.println("Please Enter Number (0) to exit");
i = scanner.nextInt();
}
System.out.println("EXIT");
itemTask.shutdownHook();
}
}
package ashish.demo.threading.basic;
import java.io.Serializable;
/**
* Created by ashishratan on 2/2/17.
*/
public class Item implements Serializable {
private Integer orderId;
private Float price;
private String productName;
private byte category;
public Item(Integer orderId, Float price, String productName, byte category) {
this.orderId = orderId;
this.price = price;
this.productName = productName;
this.category = category;
}
public Item() {
}
public Integer getOrderId() {
return orderId;
}
public void setOrderId(Integer orderId) {
this.orderId = orderId;
}
public Float getPrice() {
return price;
}
public void setPrice(Float price) {
this.price = price;
}
public String getProductName() {
return productName;
}
public void setProductName(String productName) {
this.productName = productName;
}
public byte getCategory() {
return category;
}
public void setCategory(byte category) {
this.category = category;
}
@Override
public String toString() {
return "Item{" +
"orderId=" + orderId +
", price=" + price +
", productName='" + productName + '\'' +
", category=" + category +
'}';
}
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof Item)) return false;
Item item = (Item) o;
if (getCategory() != item.getCategory()) return false;
if (getOrderId() != null ? !getOrderId().equals(item.getOrderId()) : item.getOrderId() != null) return false;
if (getPrice() != null ? !getPrice().equals(item.getPrice()) : item.getPrice() != null) return false;
return getProductName() != null ? getProductName().equals(item.getProductName()) : item.getProductName() == null;
}
@Override
public int hashCode() {
int result = getOrderId() != null ? getOrderId().hashCode() : 0;
result = 31 * result + (getPrice() != null ? getPrice().hashCode() : 0);
result = 31 * result + (getProductName() != null ? getProductName().hashCode() : 0);
result = 31 * result + (int) getCategory();
return result;
}
}
异常跟踪
Please Enter Number (0) to exit
3
Thread[main,5,main]
Total Items In Stock are 0
[]
Please Enter Number (0) to exit
Thread[ItemTask-Thread-455,10,main]
Total Items In Stock are 1
6
Thread[main,5,main]
Total Items In Stock are 1
Thread[ItemTask-Thread-464,10,main]
Total Items In Stock are 2
Exception in thread "main" java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at java.util.AbstractCollection.toString(AbstractCollection.java:461)
at java.lang.String.valueOf(String.java:2994)
at java.io.PrintStream.println(PrintStream.java:821)
at ashish.demo.threading.Main.main(Main.java:26)
12
【问题讨论】：
-
"if (this.remove ItemEvent) { this.itemList.add (this.item);" ?
-
那么同步在做什么？？
-
Main.java的第26行是哪一个？
-
在方法上使用
synchronized(this)和synchronized关键字不使用相同的同步对象。 -
另外，您正在泄漏关键资源。同步仅在返回对列表的引用时发生。通过该引用进行的访问将不再同步。您可以通过返回列表副本或扩展 API 来避免这种情况，这样就不必放弃对列表的直接访问权限。
标签： java multithreading collections