这段代码编译:
#[derive(Clone)]
pub enum Node {
Value(u32),
Branch(u32, Box<Node>, Box<Node>),
}
fn main() {
let root = Node::Branch(1, Box::new(Node::Value(2)), Box::new(Node::Value(3)));
zero_node(&root, 2);
}
pub fn zero_node (tree: &Node, node_index: u8) -> Node {
let mut new_tree = tree.clone();
fn zero_rec (node : &mut Node, node_count : u8, node_index : u8) -> u8 {
if node_index == node_count {
match node {
&mut Node::Value(ref mut val) => { *val = 0; },
&mut Node::Branch(ref mut val, _, _) => { *val = 0; }
}
node_count
} else {
match node {
&mut Node::Value(_) => {1},
&mut Node::Branch(_, ref mut left, ref mut right) => {
let count_left = zero_rec(&mut **left, node_count + 1, node_index);
let count_right = zero_rec(&mut **right, node_count + 1 + count_left, node_index);
count_left + count_right + 1
}
}
}
}
zero_rec(&mut new_tree, 0, node_index);
new_tree
}
我所做的更改是:
-
&new_tree → &mut new_tree 和 &**left → &mut **left 等:创建&mut T 引用的方法是使用&mut 运算符(即mut 是必需的)。这通过传递可变引用而不是不可变引用来修复 cannot borrow immutable borrowed content as mutable 错误
- 更改
node_index == node_count 分支以直接改变值,而不是尝试就地覆盖。这通过根本不执行任何移动来修复 cannot move out of borrowed content 错误。
实际上可以通过仔细使用std::mem::replace 来实现覆盖,以将新值(例如Value(0),因为创建起来很便宜)交换到left 和right 引用。 replace 函数返回之前存在的值,即您需要创建新分支的 left 和 right 中的内容。对相关 match 手臂的这种更改看起来有点像:
&mut Node::Branch(_, ref mut left, ref mut right) => {
let l = mem::replace(left, Box::new(Node::Value(0)));
let r = mem::replace(right, Box::new(Node::Value(0)));
*node = Node::Branch(0, l , r);
}
(已将use std::mem; 添加到文件顶部。)
但是它遇到了一个新错误:
<anon>:25:9: 25:39 error: cannot assign to `*node` because it is borrowed
<anon>:25 *node = Node::Branch(0, l , r);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:22:26: 22:38 note: borrow of `*node` occurs here
<anon>:22 &mut Node::Branch(_, ref mut left, ref mut right) => {
^~~~~~~~~~~~
left 和 right 值是深入到 node 旧内容的指针,因此,就编译器(目前)所知,覆盖 node 将使那些指针无效,这会导致任何使用它们的进一步代码被破坏(当然,我们可以看到两者都没有被更多地使用,但是编译器还没有关注这样的事情)。幸运的是,有一个简单的解决方法:两个match 臂都将node 设置为一个新值,因此我们可以使用match 来计算新值,然后在计算后将node 设置为它:
*node = match node {
&mut Node::Value(_) => Node::Value(0),
&mut Node::Branch(_, ref mut left, ref mut right) => {
let l = mem::replace(left, Box::new(Node::Value(0)));
let r = mem::replace(right, Box::new(Node::Value(0)));
Node::Branch(0, l , r)
}
};
(注意,操作顺序有点奇怪,和let new_val = match node { ... }; *node = new_val;一样)
然而,这比我上面写的要贵,因为它必须为新的 Branch 分配 2 个新框,而就地修改的那个则不需要必须这样做。
一个稍微“更好”的版本可能是(cmets inline):
#[derive(Clone, Show)]
pub enum Node {
Value(u32),
Branch(u32, Box<Node>, Box<Node>),
}
fn main() {
let root = Node::Branch(1, Box::new(Node::Value(2)), Box::new(Node::Value(3)));
let root = zero_node(root, 2);
println!("{:?}", root);
}
// Taking `tree` by value (i.e. not by reference, &) possibly saves on
// `clone`s: the user of `zero_node can transfer ownership (with no
// deep cloning) if they no longer need their tree.
//
// Alternatively, it is more flexible for the caller if it takes
// `&mut Node` and returns () as it avoids them having to be careful
// to avoid moving out of borrowed data.
pub fn zero_node (mut tree: Node, node_index: u8) -> Node {
fn zero_rec (node : &mut Node, node_count : u8, node_index : u8) -> u8 {
if node_index == node_count {
// dereferencing once avoids having to repeat &mut a lot
match *node {
// it is legal to match on multiple patterns, if they bind the same
// names with the same types
Node::Value(ref mut val) |
Node::Branch(ref mut val, _, _) => { *val = 0; },
}
node_count
} else {
match *node {
Node::Value(_) => 1,
Node::Branch(_, ref mut left, ref mut right) => {
let count_left = zero_rec(&mut **left, node_count + 1, node_index);
let count_right = zero_rec(&mut **right, node_count + 1 + count_left, node_index);
count_left + count_right + 1
}
}
}
}
zero_rec(&mut tree, 0, node_index);
tree
}