创建文件夹的数据验证

Question

公司向客户发送发票。我创建了一个宏，它将客户的发票放入他们的文件夹中，存储在该发票的创建年份之下。

鉴于现在是 2020 年 1 月，发票将存储在 2020 文件夹下，然后按客户名称存储。

一旦 2020 年结束并且尚未创建 2021 年文件夹，我当前的代码是否会妥善处理这个问题？

代码确定客户端文件夹是否已存在，以及是否没有在当前年份下创建以该客户端名称作为文件夹的文件夹。

我假设在接下来的几年中会出现某种类型的错误，因为这些文件夹尚未创建。
我希望它不会出错，而是转到ErrorHandlerCreateNewYearFolder，以创建文件夹路径、当年的新文件夹和客户的新文件夹。

If fdObj.FolderExists("C:\Users\" & strInvoiceYear & "\ " & GroupID) Then 'if the Clients folder already exists....
    Call EmailClient((EmailValue), (GroupID)) '...then the necessary data required is already availiable, so it calls to the EmailClient sub function
Else
        
    On Error GoTo ErrorHandlerCreateNewYearFolder ' In the occation of a potential error, the code below will skip the run time error and try its best to handle this
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear & "\ " & GroupID)
    Exit Sub
    ' INSIGHT: THE LINE OF CODE BELOW CREATES A FOLDER THAT CONTAINS THE GROUPID OF A CLIENT WITHIN THAT YEAR. SO GIVEN THAT THE CURRENT YEAR IS 2020, IT WILL STORE ALL INVOICES WITHIN THAT FOLDER
    ' HOWEVER, THERE IS NO CURRENT 2021,2020, ETC FOLDERS, SO THIS LINE OF CODE WILL BE UNABLE TO DETERMINE THE CORRECT PATH OF strInvoiceYear BECAUSE THIS VARIABLE'S (THAT CURRENT YEAR) FOLDER HAS
    ' YET TO HAVE BEEN CREATED. SO THERE MAY BE A RUN TIME ERROR. HOWEVER, THIS CODE BELOW SHOULD HELP OVERCOME THIS POTENTIAL ISSUE
        
ErrorHandlerCreateNewYearFolder: 'THIS IS AN ERROR HANDLER, SO IF THE NEW YEAR STARTS, LIKE 2021, AND NO 2021 FOLDER HAS BEEN CREATED, THE PROGRAM WILL GO HERE
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear)  ' IN WHICH THE PROGRAM WILL THEN CREATE THE NEW YEAR FOLDER
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear & "\ " & GroupID) ' AND THEN CREATE THE NEW CLIENT FOLDER OF THAT YEAR
    Resume Next
        
    MsgBox ("Folder created successfully."), vbInformation ' notifies user that a new folder has been created for the client
    Call EmailClient((EmailValue), (GroupID)) ' This then calls to the EmailClient sub function where the data from that client will then be emailed to them
End If

Answer 1

我认为这里不需要错误处理程序。这很简单。

我把Call 拉出来了。无论如何，我们都会调用EmailClient，因此您不必将其嵌套在条件中。相反，运行您的检查，必要时创建文件夹，然后使用您所拥有的调用EmailClient。

您的第一个条件检查文件夹是否存在。如果是这样，那就太好了，不再需要条件。如果没有，它的父母会吗？如果答案是否定的，那就去做吧。如果答案是肯定的，那就做孩子。然后发送。

If fdObj.FolderExists("C:\Users\" & strInvoiceYear & "\ " & GroupID) = True Then

'Check if the parent folder exists (returns true if it doesn't)
ElseIf fdObj.FolderExists("C:\Users\" & strInvoiceYear) = False Then
    'Create parent
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear)
    'Create group folder
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear & "\ " & GroupID)
Else
    fdObj.CreateFolder ("C:\Users\" & strInvoiceYear & "\ " & GroupID)
End If

Call EmailClient((EmailValue), (GroupID))

End Sub

如果你真的想添加一个错误处理程序，我会把它放在对EmailClient 的调用之前或EmailClient 的内部。使用正确的条件格式，您在这里所做的事情应该非常简单。

另外，请注意，您的 cmets 太长了。如果它是一个简短的评论，请继续并将其粘贴在代码之后。如果是长注释，请将其放在前面，然后将更长的注释分成多行。没有人喜欢横向滚动。

理想情况下，您应该使用If Not 完全跳过第一个子句，但鉴于您提供的代码已被注释掉的数量，我想让它保持可读性。