C# 安全破解迷你游戏无法按预期工作

Question

背景：

我正在尝试为我班上的一款游戏制作一个小迷你游戏，但我无法让它 100% 发挥作用。问题是如果你通过 20 次猜测，它会无限打印 generateCombo(); 消息，我也无法让它转到第二个数字。

任何帮助，我是新的代码，今年才开始。

提前致谢！

class Safe
{
    public bool safeLocked { get; set; }
    public int guesses { get; set; }
    public int cn1 { get; set; }
    public int cn2 { get; set; }
    public int cn3 { get; set; } 
    public int cn4 { get; set; }
    public int num1 { get; set; }
    public int num2 { get; set; }
    public int num3 { get; set; }
    public int num4 { get; set; }

}

safe.guesses = 0;
        safe.safeLocked = true;
        safe.cn1 = 0;
        safe.cn2 = 0;
        safe.cn3 = 0;
        safe.cn4 = 0;

public static void generateCombo()
    {

        //First number
        Random n1 = new Random();
        safe.num1 = n1.Next(1, 10);

        //Second number
        Random n2 = new Random();
        safe.num2 = n2.Next(1, 10);

        //Third number
        Random n3 = new Random();
        safe.num3 = n3.Next(1, 10);

        //Fourth number
        Random n4 = new Random();
        safe.num4 = n4.Next(1, 10);

        Console.WriteLine ("A new combonation has been generated.");
        Console.ReadLine ();
        safeCracking ();

    }

public static void printScreen()
    {
        Console.Clear ();
        Console.ForegroundColor = ConsoleColor.Green;
        Console.Write("Guesses: ");
        Console.ResetColor();
        Console.WriteLine("{0}", safe.guesses);
        Console.WriteLine("");

        Console.WriteLine("     =================================    ");
        Console.WriteLine("     |       |       |       |       |    ");
        Console.WriteLine("     |       |       |       |       |    ");
        Console.WriteLine("     |   {0}   |   {1}   |   {2}   |   {3}   |    ", safe.cn1, safe.cn2, safe.cn3, safe.cn4);
        Console.WriteLine("     |       |       |       |       |    ");
        Console.WriteLine("     |       |       |       |       |    ");
        Console.WriteLine("     =================================    ");
        Console.WriteLine("");
        Console.WriteLine("Guess the numbers of the combination one by one.");
        Console.WriteLine("");
    }


    public static void safeCracking()
    {
        for (int i = 0; i < 20; i++) {

            if (safe.guesses == 20) {
                generateCombo ();
            }

            printScreen ();

            string numg;
            int numberG;

            try{
                numg = Console.ReadLine();
                numberG = int.Parse(numg);
            }   catch {
                numg = "";
                numberG = 0;
            }
            numberOf.puzzleGuess = numg;

            //Check number 4
            if (safe.cn3 < 0 && (numg == safe.num4.ToString ())) {
                Console.ForegroundColor = ConsoleColor.Green;
                Console.WriteLine("");
                Console.WriteLine("{0} Is Correct!", numberOf.puzzleGuess);
                Console.ResetColor();
                safe.cn4 = numberG;
                Console.ReadLine();
            } 

            //Check number 3
            else if (safe.cn2 < 0 && (numg == safe.num3.ToString ())) {
                Console.ForegroundColor = ConsoleColor.Green;
                Console.WriteLine("");
                Console.WriteLine("{0} Is Correct!", numberOf.puzzleGuess);
                Console.ResetColor();
                safe.cn3 = numberG;
                Console.ReadLine();
            }

            //Check number 2
            else if (safe.cn1 < 0 && (numg == safe.num2.ToString())) {
                Console.ForegroundColor = ConsoleColor.Green;
                Console.WriteLine("");
                Console.WriteLine("{0} Is Correct!", numberOf.puzzleGuess);
                Console.ResetColor();
                safe.cn2 = numberG;
                Console.ReadLine();
            }

            //Check number 1
            else if (safe.cn1 == 0 && (numg == safe.num1.ToString())) {
                Console.ForegroundColor = ConsoleColor.Green;
                Console.WriteLine("");
                Console.WriteLine("{0} Is Correct!", numberOf.puzzleGuess);
                Console.ResetColor();
                safe.cn1 = numberG;
                Console.ReadLine();
            } 

            else {
                Console.ForegroundColor = ConsoleColor.Red;
                Console.WriteLine("");
                Console.WriteLine("{0} Is Incorrect!", numberOf.puzzleGuess);
                Console.ForegroundColor = ConsoleColor.Gray;
                Console.WriteLine("Press Enter to continue...");
                Console.ResetColor();
                Console.ReadLine();
                safe.guesses++;
                safeCracking();
            }

        }

        if (safe.safeLocked == false) {
            //Continue game here
        }

    }

Answer 1

我假设您想生成一个连击并猜测 20 次，而不是每次有人猜测时重新生成一个连击（对于 IMO 游戏来说更有意义）。如果是这种情况，您应该将 generateCombo() 移出 for 循环

if (safe.guesses == 20) {
            generateCombo();
            safe.guesses = 0;
}

for (int i = 0; i < 20; i++) {
...

另外，您不需要在generateCombo() 中使用safeCracking();，因为它会导致无数次调用。有些东西调用safeCracking() 方法来启动游戏，它调用generateCombo()，它调用一个新的safeCracking() 等等。您的所有 for 循环都不会超过第一次迭代。

编辑：您可能还应该删除 else 中的 safeCracking() 递归调用。每次您似乎有错误的号码时都会调用该号码，并且每次您有错误的答案时都会重新启动游戏。

如果您希望游戏每 20 次猜测循环一次，为什么不在 for 循环之后放置一个 safeCracking() 调用。确保阅读“退出”行或用户可以输入以关闭游戏的某些命令。

try{
text = Console.ReadLine();
if(text.ToLower() == "exit")
   return
numberG = int.Parse(text);
}   catch {
            numberG = 0;
        }