【问题标题】:Django CreateView test failDjango CreateView 测试失败
【发布时间】:2024-05-03 18:40:02
【问题描述】:

我的配置如下(django 3.02):

型号:

class Assets(models.Model):
    assettag = models.CharField()
    ...

class Item(models.Model):
    asset = models.OneToOneField('Assets')
    ...

    def __str__(self):
        return (f"{self.rfid_tag}" + " - " + f"{self.asset.assettag}")

class Comments(models.Model): # I know, it should not be plural.
    item = models.ForeignKey('Item',
                             default=None,
                             null=True,
                             on_delete=models.CASCADE,
                             )
    text = models.TextField()
    ...

表格:

class ItemInsertForm(forms.ModelForm):
    rfid_tag = forms.CharField(label='RFID Tag',
                               widget=forms.TextInput(attrs={"placeholder":"96 bit EPC code",
                                                             "pattern":"^[a-fA-F0-9]{24}$",
                                                             "size":"25",
                                                             "id":"rfid_tag",
                                                             }
                                                      )
                               )
    asset = forms.CharField(label='AssetTag',
                            widget=forms.TextInput(attrs={"placeholder":"Item Inventory Tag",
                                                          "pattern":"{some regex}",
                                                          "size":"25",
                                                          "id":"asset",
                                                          }
                                                   )
                            )

    comments = forms.CharField(label='Comments',
                               required=False,
                               widget=forms.Textarea(attrs={"rows":5,
                                                            "cols":50,
                                                            "id":"comments",
                                                           }
                                                    )
                              )

    class Meta:
        model = Item
        fields = [
            'rfid_tag',
            'asset',
            'image',
            'date',
        ]


    def clean_rfid_tag(self, *args, **kwargs):
        return self.cleaned_data.get("rfid_tag").lower()

    def clean_asset(self, *args, **kwargs):
        AssetTag = self.cleaned_data.get("asset")
        try:
            _asset = Assets.objects.get(assettag = AssetTag)
        except Assets.DoesNotExist:
            raise forms.ValidationError("Asset does not exist !")
        self.Asset = _asset
        return self.Asset

查看:

class InsertView(SuccessMessageMixin, AuditMixin, generic.CreateView):
    template_name = '{some template}'
    success_message = "Item succesfully created"
    form_class = ItemInsertForm

    def form_valid(self, form):
        item = form.save(commit=False)
        _comment = form.cleaned_data.get('comments')
        item = form.save()
        if _comment:
            item.comments_set.create(text =_comment)
        self.log_insert(item)
        return super().form_valid(form)

测试:

class TestViews(TestCase):
    @classmethod
    def setUpTestData(cls) -> None:
        # create dummy assets
        cls.asset = Assets.objects.create(assettag="{some assettag #1}",)
        cls.asset2 = Assets.objects.create(assettag="{some assettag #2}")
        # create dummy item
        cls.item = Item.objects.create(rfid_tag='abcdef012345678900000000', asset=cls.asset)

    def setUp(self) -> None:
        self.client = Client()
        self.insert_url = reverse('inventory:insert')

    def test_insert_POST_valid(self):
        response = self.client.post(self.insert_url,
                                    data = {'rfid_tag':'abcdef012345678900000001',
                                            'asset':'{some assettag #2}',}
                                    )
        new_item = Item.objects.get(rfid_tag="abcdef012345678900000001")
        self.assertEqual(response.status_code, 302)
        self.assertTrue(isinstance(new_item,Item))
        self.assertEqual(Item.objects.filter(rfid_tag="abcdef012345678900000001").count(),1)
        self.assertEqual(self.asset2.item, new_item)
        self.assertFalse(Comments.objects.all())

    def test_insert_POST_comment(self):
        response = self.client.post(self.insert_url,
                                    data = {'rfid_tag':'abcdef012345678900000001',
                                            'asset':'{some assettag #2}',
                                            'comments':'Test comment.',
                                            }
                                    )
        new_item = Item.objects.get(rfid_tag="abcdef012345678900000001")
        self.assertEqual(response.status_code, 302)
        self.assertTrue(isinstance(new_item,Item))
        self.assertEqual(Item.objects.filter(rfid_tag="abcdef012345678900000001").count(),1)
        self.assertEqual(self.asset2.item, new_item)
        self.assertTrue(isinstance(Comments.objects.get(text='Test comment.'), Comments))
        self.assertEqual(Comments.objects.get(text='Test comment.'),
                         new_item.comments_set.first())

如果我运行这些测试,test_insert_POST_valid 将由于断言错误而失败:

AssertionError: !=

我在整个代码中插入了一些打印语句:

    # this was placed first in both tests, before the POST request
    items = Item.objects.all()
    for item in items:
        print("Item:",item.id, " - ", item)

    # and then again, after each POST request

我注意到,第一次运行打印时,它只会输出一个 Item 对象(这两个函数都是如此):

项目:1 - abcdef012345678900000009 - {一些资产标签 #1}

但在第二次运行时(在发送 POST 请求并创建新项目之后):

对于test_insert_POST_comment,结果是:

项目:1 - abcdef012345678900000009 - {一些资产标签 #1}
项目:2 - abcdef012345678900000001 - {一些资产标签#2}

test_insert_POST_valid 的结果是:

项目:1 - abcdef012345678900000009 - {一些资产标签 #1}
项目:3 - abcdef012345678900000001 - {一些资产标签#2}

如果我在test_insert_POST_valid 函数中执行print("Asset Item:", self.asset2.item.id, " - ", self.asset2.item)(由于某种原因,此测试第二次运行),它将输出:

资产项目:2 - abcdef012345678900000001 - {一些资产标签 #2}

我不明白这是怎么发生的。 Item.objects.all() 只会返回一个对象(abcdef012345678900000000),而Asset 对象仍然与虚构的第二个Item 对象保持关系,该对象不存在。

我怀疑test_insert_POST_valid 实际上并没有创建任何对象,因为self.asset2 已经通过OneToOne 关系关联了Item,但事实并非如此。如果我将 rfid_tag 值更改为 abcdef012345678900000002(或其他),它将创建新的 Item,但 self.asset2.item 仍将指向 abcdef012345678900000001。

这个问题的原因是什么,哇,我可以解决它吗? (在 POST 数据之前放置 self.asset2.item = None 将无济于事。不会创建新的关系。)

编辑: 我可以在setUp 方法中移动cls.asset2 = Assets.objects.create(assettag="{some assettag #2}"),它将在每次测试之前创建,但我有更多的逻辑取决于这个我也必须移动它。首选方法是将其保留在 setUpTestdata 中,这样它只会运行一次。

【问题讨论】:

    标签: python django forms unit-testing django-models


    【解决方案1】:

    我找到了一个简单的解决方案:在setUp 方法中添加self.asset2.refresh_from_db()。这将在运行每个测试之前从数据库中重新加载此模型的每个字段。

    【讨论】: