防止重复

Question

select，orderby，take子句和toArray()重复，只有第一行不同。如何缩短这 3 个 linq 查询以避免重复？

我已经包含了用于返回模型视图的方法

    public async Task<ActionResult> GetPopularContent(int Records, int? WorkareaRef, string Jurisdiction)
    {
        var model = new PopularContentModel();
        int? languageId = null;

        var login = new Login(HttpContext);
        var branding = new DynamicBranding(login);

        if (branding.BrandingDefaultLanguage != Cam.Service.ContentService.defaultLanguageId)
        {
            languageId = branding.BrandingDefaultLanguage;
        }

        languageId = languageId ?? ContentService.defaultLanguageId;
        var jurisdictionRef = string.IsNullOrEmpty(Jurisdiction) ? (int?)null : metaDataService.GetJurisdictionRefViaName(Jurisdiction);

        var reads24 = (await mostPopularContentService.MostPopularLast24HoursAsync(languageId.Value, WorkareaRef, jurisdictionRef, Records + 30)).ToDictionary(x=>x.Article, x=>x.Total);
        var reads7 = (await mostPopularContentService.MostPopularThisWeekAsync(languageId.Value, Records + 30)).ToDictionary(x => x.Article, x => x.Total);
        var readsShared = (await mostPopularContentService.MostSharedThisWeekAsync(languageId.Value, Records + 30)).ToDictionary(x => x.Article, x => x.Total);

        model.Read7DayDataSource = articleService.GetArticlesFromGuidList(reads7.Select(x=>x.Key), wcagOnly: branding.StrictlyWCAG2Accessible, useCache: true)
            .Select(x => new PopularArticle() { Article = x, ArticleGuid = x.ArticleGUID })
            .Where(x=> contentAdminTestingDataFilterService.AllowFirmAccess(x.Article.FirmRef, lexUser) && x.Article.RemoveDate == null)
            .OrderByDescending(x=> reads7[x.ArticleGuid])
            .Take(Records)
            .ToArray();
        model.Read24DataSource = articleService.GetArticlesFromGuidList(reads24.Select(x => x.Key), wcagOnly: branding.StrictlyWCAG2Accessible, useCache: true)
            .Select(x => new PopularArticle() { Article = x, ArticleGuid = x.ArticleGUID })
            .Where(x => contentAdminTestingDataFilterService.AllowFirmAccess(x.Article.FirmRef, lexUser) && x.Article.RemoveDate == null)
            .OrderByDescending(x => reads24[x.ArticleGuid])
            .Take(Records)
            .ToArray();
        model.SharedDataSource = articleService.GetArticlesFromGuidList(readsShared.Select(x => x.Key), wcagOnly: branding.StrictlyWCAG2Accessible, useCache: true)
            .Select(x => new PopularArticle() { Article = x, ArticleGuid = x.ArticleGUID })
            .Where(x => contentAdminTestingDataFilterService.AllowFirmAccess(x.Article.FirmRef, lexUser) && x.Article.RemoveDate == null)
            .OrderByDescending(x => readsShared[x.ArticleGuid])
            .Take(Records)
            .ToArray();

        model.LastUpdated = DateTime.Now.AddDays(-1).Date;

        DecorateFirmName(model);

        model.ShowSocialButtons = branding.ShowSocialButtons;

        return PartialView("PopularContentPartial", model);
    }

谢谢

Answer 1

您创建一个将reads7、reads24 或readsShared 作为参数类型并返回结果的方法：

IEnumerable<PopularArticle> Get(Dictionary<Guid, SOMETHING> variable)
{
    return articleService.GetArticlesFromGuidList(variable.Select(x => x.Key), wcagOnly: branding.StrictlyWCAG2Accessible, useCache: true)
        .Select(x => new PopularArticle() { Article = x, ArticleGuid = x.ArticleGUID })
        .Where(x => contentAdminTestingDataFilterService.AllowFirmAccess(x.Article.FirmRef, lexUser) && x.Article.RemoveDate != null)
        .OrderByDescending(x => variable[x.ArticleGuid])
        .Take(Records)
        .ToArray();
}

调用示例：

model.Read7DayDataSource = this.Get(reads7);