【发布时间】:2019-03-05 06:57:40
【问题描述】:
我有以下代码
Vehicle.h:
#pragma once
class Vehicle
{
public:
Vehicle();
~Vehicle();
private:
int wheels;
};
Car.h
#pragma once
#include "Vehicle.h"
class Car: public Vehicle
{
public:
Car();
~Car();
private:
int wheels=4;
};
ParkingLot.h
#pragma once
#include <vector>
#include <string>
#include "ParkingSpace.h"
#include "HandicappedParkingSpace.h"
#include "CompactParkingSpace.h"
#include "RegularParkingSpace.h"
class ParkingLot
{
public:
ParkingLot();
~ParkingLot();
void ParkVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps);
void ReleaseVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps);
void getOccupiedSpaces();
private:
int value;
std::vector <HandicappedParkingSpace> occupied_handicapparkingspaces;
std::vector <HandicappedParkingSpace> vacant_handicapparkingspaces;
std::vector <RegularParkingSpace> occupied_regularparkingspaces;
std::vector <RegularParkingSpace> vacant_regularparkingspaces;
std::vector <CompactParkingSpace> occupied_compactparkingspaces;
std::vector <CompactParkingSpace> vacant_compactparkingspaces;
};
ParkingLot.cpp:
#pragma once
#include <iostream>
#include <string>
#include <vector>
#include "ParkingLot.h"
using namespace std
ParkingLot::ParkingLot() {
for (int i=0; i<5; i++) {
HandicappedParkingSpace HPS(1, Null);
vacant_handicapparkingspaces.push_back(HPS);
}
for (int i=0; i<5; i++) {
CompactParkingSpace CPS(1, Null);
vacant_compactparkingspaces.push_back(CPS);
}
for (int i=0; i<5; i++) {
RegularParkingSpace RPS(1, Null);
vacant_regularparkingspaces.push_back(RPS);
}
cout<<"finished parking lot"<<endl;
}
void ParkingLot::ParkVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps)
{
if (ps=="Handicapped") {
if (vacant_handicapparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_handicapparkingspaces.pop_back();
occupied_handicapparkingspaces.push_back(_ps);
}
else
{
cout<<"No handicapped spaces available"<<endl;
}
}
else if (ps=="Compact") {
if (vacant_compactparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_compactparkingspaces.pop_back();
occupied_compactparkingspaces.push_back(_ps);
}
else
{
cout<<"No compact spaces available"<<endl;
}
}
else {
if (vacant_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_regularparkingspaces.pop_back();
occupied_regularparkingspaces.push_back(_ps);
}
else {
cout<<"No regular spaces available"<<endl;
}
}
}
void ParkingLot::ReleaseVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps)
{
_ps.vacant=1;
_ps.vehicle= Null;
if (ps=="Handicapped") {
if (occupied_regularparkingspaces.size()!=0) {
vacant_handicapparkingspaces.push_back(_ps);
occupied_handicapparkingspaces.pop_back();
}
else {
cout<<"Unable to release any handicapped spaces"<<endl;
}
}
else if (ps=="Compact") {
if (occupied_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_compactparkingspaces.pop_back(_ps);
occupied_compactparkingspaces.push_back();
}
else {
cout<<"Unable to release any compact spaces"<<endl;
}
}
else {
if (occupied_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_regularparkingspaces.pop_back(_ps);
occupied_regularparkingspaces.push_back();
}
else {
cout<<"Unable to release any regular spaces"<<endl;
}
}
}
void ParkingLot::getOccupiedSpaces() {
cout<<"Occupied handicap spaces: "<<occupied_handicapparkingspaces.size()<<endl;
cout<<"Vacant handicap spaces: "<<vacant_handicapparkingspaces.size()<<endl;
cout<<"Occupied compact spaces: "<<occupied_compactparkingspaces.size()<<endl;
cout<<"Vacant compact spaces: "<<vacant_compactparkingspaces.size()<<endl;
cout<<"Occupied regular spaces: "<<occupied_regularparkingspaces.size()<<endl;
}
ParkingSpace.h:
#pragma once
#include "Vehicle.h"
class ParkingSpace
{
public:
ParkingSpace();
~ParkingSpace();
virtual void parkvehicle()=0;
private:
Vehicle *vehicle;
bool vacant;
};
HandicappedParkingSpace.h:
#pragma once
#include "ParkingSpace.h"
class HandicappedParkingSpace : public ParkingSpace
{
public:
HandicappedParkingSpace(int _vacant, Vehicle* _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~HandicappedParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
private:
int vacant;
Vehicle *vehicle;
};
RegularParkingSpace.h:
#pragma once
#include "ParkingSpace.h"
class RegularParkingSpace : public ParkingSpace
{
public:
RegularParkingSpace(int _vacant, Vehicle* _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~RegularParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
private:
int vacant;
Vehicle *vehicle;
};
CompactParkingSpace.h:
#pragma once
#include "ParkingSpace.h"
class CompactParkingSpace : public ParkingSpace
{
public:
CompactParkingSpace(int _vacant, Vehicle* _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~CompactParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
private:
int vacant;
Vehicle *vehicle;
};
main.cpp:
#include "ParkingLot.h"
#include "HandicappedParkingSpace.h"
#include "RegularParkingSpace.h"
#include "CompactParkingSpace.h"
#include "Car.h"
#include <iostream>
using namespace std;
int main()
{
ParkingLot PL;
Car c1;
HandicappedParkingSpace HPS;
PL.ParkVehicle(c1, HPS, "Handicapped");
Car c2;
CompactParkingSpace CPS;
PL.ParkVehicle(c2, CPS, "Handicapped");
PL.getOccupiedSpaces();
cout<<"FINISHED"<<endl;
//delete d;
return 0;
}
这是我得到的错误:https://pastebin.com/p0vzb0Mz(错误太长,我无法在此处发布)
有人可以帮忙吗?
编辑:
我修改了ParkingLot.cpp,现在看起来像
#pragma once
#include <iostream>
#include <string>
#include <vector>
#include "ParkingLot.h"
using namespace std;
ParkingLot::ParkingLot() {
for (int i=0; i<5; i++) {
HandicappedParkingSpace HPS(1, nullptr);
vacant_handicapparkingspaces.push_back(HPS);
}
for (int i=0; i<5; i++) {
CompactParkingSpace CPS(1, nullptr);
vacant_compactparkingspaces.push_back(CPS);
}
for (int i=0; i<5; i++) {
RegularParkingSpace RPS(1, nullptr);
vacant_regularparkingspaces.push_back(RPS);
}
cout<<"finished parking lot"<<endl;
}
void ParkingLot::ParkVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps)
{
if (ps=="Handicapped") {
if (vacant_handicapparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_handicapparkingspaces.pop_back();
occupied_handicapparkingspaces.push_back(_ps);
}
else
{
cout<<"No handicapped spaces available"<<endl;
}
}
else if (ps=="Compact") {
if (vacant_compactparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_compactparkingspaces.pop_back();
occupied_compactparkingspaces.push_back(_ps);
}
else
{
cout<<"No compact spaces available"<<endl;
}
}
else {
if (vacant_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_regularparkingspaces.pop_back();
occupied_regularparkingspaces.push_back(_ps);
}
else {
cout<<"No regular spaces available"<<endl;
}
}
}
void ParkingLot::ReleaseVehicle(Vehicle _v, ParkingSpace& _ps, std::string ps)
{
//_ps.vacant=1;
//_ps.vehicle= nullptr;
_ps.setVehicle(1, nullptr);
if (ps=="Handicapped") {
if (occupied_regularparkingspaces.size()!=0) {
vacant_handicapparkingspaces.push_back(_ps);
occupied_handicapparkingspaces.pop_back();
}
else {
cout<<"Unable to release any handicapped spaces"<<endl;
}
}
else if (ps=="Compact") {
if (occupied_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_compactparkingspaces.push_back(_ps);
occupied_compactparkingspaces.pop_back();
}
else {
cout<<"Unable to release any compact spaces"<<endl;
}
}
else {
if (occupied_regularparkingspaces.size()!=0) {
_ps.parkvehicle(_v);
vacant_regularparkingspaces.push_back(_ps);
occupied_regularparkingspaces.pop_back();
}
else {
cout<<"Unable to release any regular spaces"<<endl;
}
}
}
void ParkingLot::getOccupiedSpaces() {
cout<<"Occupied handicap spaces: "<<occupied_handicapparkingspaces.size()<<endl;
cout<<"Vacant handicap spaces: "<<vacant_handicapparkingspaces.size()<<endl;
cout<<"Occupied compact spaces: "<<occupied_compactparkingspaces.size()<<endl;
cout<<"Vacant compact spaces: "<<vacant_compactparkingspaces.size()<<endl;
cout<<"Occupied regular spaces: "<<occupied_regularparkingspaces.size()<<endl;
cout<<"Vacant regular spaces: "<<vacant_regularparkingspaces.size()<<endl;
}
ParkingSpace.h 现在是
#pragma once
#include "Vehicle.h"
class ParkingSpace
{
public:
ParkingSpace();
~ParkingSpace();
virtual void parkvehicle(Vehicle _v)=0;
virtual void setVehicle(bool vacant, Vehicle _v);
private:
Vehicle vehicle;
bool vacant;
};
HandicappedParkingSpace.h 现在是
#pragma once
#include "ParkingSpace.h"
class HandicappedParkingSpace : public ParkingSpace
{
public:
HandicappedParkingSpace(int _vacant, Vehicle& _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~HandicappedParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
void setVehicle(bool _vacant, Vehicle _v) {
this->vacant=_vacant;
this->vehicle= _v;
}
private:
int vacant;
Vehicle vehicle;
};
RegularParkingSpace.h 现在是
#pragma once
#include "ParkingSpace.h"
class RegularParkingSpace : public ParkingSpace
{
public:
RegularParkingSpace(int _vacant, Vehicle& _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~RegularParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
void setVehicle(bool _vacant, Vehicle _v) {
this->vacant=_vacant;
this->vehicle= _v;
}
private:
int vacant;
Vehicle vehicle;
};
CompactParkingSpace.h 现在是
#pragma once
#include "ParkingSpace.h"
class CompactParkingSpace : public ParkingSpace
{
public:
CompactParkingSpace(int _vacant, Vehicle& _v) {
this->vacant=_vacant;
this->vehicle=_v;
}
~CompactParkingSpace();
void parkvehicle(Vehicle _v) {
this->vacant=0;
this->vehicle=_v;
}
void setVehicle(bool _vacant, Vehicle _v) {
this->vacant=_vacant;
this->vehicle= _v;
}
private:
int vacant;
Vehicle vehicle;
};
main.cpp 现在是
#include "ParkingLot.h"
#include "HandicappedParkingSpace.h"
#include "RegularParkingSpace.h"
#include "CompactParkingSpace.h"
#include "Car.h"
#include <iostream>
using namespace std;
int main()
{
ParkingLot PL;
Car c1;
HandicappedParkingSpace HPS(1, nullptr);
PL.ParkVehicle(c1, HPS, "Handicapped");
Car c2;
CompactParkingSpace CPS(1, nullptr);
PL.ParkVehicle(c2, CPS, "Handicapped");
PL.getOccupiedSpaces();
cout<<"FINISHED"<<endl;
//delete d;
return 0;
}
但现在我收到这些错误,似乎它们主要与nullptr:https://pastebin.com/hVdcSc63
我认为push_back 错误是因为我需要将std:vectors 如occupied_handicapparkingspaces 从<HandicappedParkingSpace> 更改为<HandicappedParkingSpace&>,然后我收到此错误:https://pastebin.com/QkWC6SRk
【问题讨论】:
-
你试过一一阅读错误吗? 20% 是写
Null(不存在)而不是nullptr或NULL。另外 30% 是关于parkVehicle,它不会在您的基类中使用参数,但在子类中会使用。正如编译器所说,由于此方法未被覆盖,因此您的子类也被认为是抽象的。为了帮助自己识别此类错误,请将override关键字放在子类中的覆盖方法上(即 CompactParkingSpace 中的void parkVehicle(Vehicle _v) override。 -
class Vehicle { int wheels; }; class Car : public Vehicle { int wheels=4; };- 但您知道知道Vehicle的wheels与Car的不一样,是吗?跨度> -
关于using namespace std...
-
Offtopic:设计问题:对空置和占用的停车场有不同的向量对我来说似乎是有问题的。自发地,我宁愿将两者放在同一个向量中,而是在基类中添加一个标志
isOccupied。这避免了在向量中移动批次的必要性(并保留它们的顺序,如果感兴趣的话)。当然,这取决于用例;如果您的主要目标只是尽快找到免费停车场,那么您的方法可能会更好...... -
我用
nullptrs 替换了Null并得到了EDIT中提到的新错误
标签: c++ oop abstract-class