【发布时间】:2016-05-17 19:33:25
【问题描述】:
我想做的是编写允许我从 csv 文件批量加载 Django 对象实例的代码。显然我应该在保存任何东西之前先检查所有数据。
tl;dr:full_clean() 方法不会捕捉到即将尝试在没有null=True 的字段中保存 None 的尝试。看起来很反常。这是设计使然,如果是,为什么? Django 的 bug 比我用过的任何其他软件都要少,所以“Bug!”似乎最不可能。
完整版。我认为可行的是,为每一行创建一个对象实例,用电子表格中的数据填充字段,然后调用 full_clean 方法。 IE。 (大纲)
from django.core.exceptions import ValidationError
...
# upload a CSV file and open with a csvreader
errors=[]
for rownumber, row in enumerate(csvreader):
o = SomeDjangoModel()
o.somefield = row[0] # repeated for all input data row[1] ...
try:
reason = ""
o.full_clean()
except ValidationError as e:
reason = "Row:{} Reason:{}".format( rownumber, str(e))
errors.append( reason)
# reason, together with the row-number of the csv file, fully explains
# what is wrong.
# end of loop
if errors:
# display errors to the user for him to fix
else:
# repeat the loop, doing .save() instead of .full_clean()
# and get database integrity errors trying to save Null in non-null model field.
问题是,.full_clean() 在没有 null=True 的字段中无法捕获 None 值
我该怎么办?想法包括
将整个事务包装在一个事务中,在异常处理程序中执行一批 o.save(),然后回滚整个事务,除非没有错误。但是,当可能 90% 的尝试都会以微不足道的方式出错时,为什么还要打扰数据库呢?
通过表单输入数据,即使没有与用户进行表单级别的每行交互。
在不应该的地方手动测试无。但是 .full_clean 还没有检查什么?
我可以理解,最终捕获数据库完整性错误的唯一方法是尝试存储数据,但为什么 Django 不能单独在 null=False 字段中捕获 None 呢?
顺便说一句,这是 Django 1.9.6
添加了细节。这是模型定义的相关字段
class OrderHistory( models.Model):
invoice_no = models.CharField( max_length=10, unique=True) # no default
invoice_val= models.DecimalField( max_digits=8, decimal_places=2) # no default
date = models.DateField( ) # no default
这就是正在发生的事情,从 python manage.py shell 完成,以证明 .full_clean 方法无法发现 n
>>> from orderhistory.models import OrderHistory
>>> from datetime import date
>>> o = OrderHistory( date=date(2010,3,17), invoice_no="21003163")
>>> o.invoice_val=None
>>> o.full_clean() # passes clean
>>> o.save() # attempt to save this one which has passed full_clean() validation
Traceback (most recent call last):
File "<console>", line 1, in <module>
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/base.py", line 708, in save
force_update=force_update, update_fields=update_fields)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/base.py", line 736, in save_base
updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/base.py", line 820, in _save_table
result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/base.py", line 859, in _do_insert
using=using, raw=raw)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/manager.py", line 122, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/query.py", line 1039, in _insert
return query.get_compiler(using=using).execute_sql(return_id)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/sql/compiler.py", line 1060, in execute_sql
cursor.execute(sql, params)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/backends/utils.py", line 79, in execute
return super(CursorDebugWrapper, self).execute(sql, params)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/backends/utils.py", line 64, in execute
return self.cursor.execute(sql, params)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/utils.py", line 95, in __exit__
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/utils/six.py", line 685, in reraise
raise value.with_traceback(tb)
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/backends/utils.py", line 64, in execute
return self.cursor.execute(sql, params)
django.db.utils.IntegrityError: null value in column "invoice_val" violates not-null constraint
DETAIL: Failing row contains (2, 21003163, , , 2010-03-17, , null, null, null, null, null, null).
>>>
>>> p = OrderHistory( invoice_no="21003164") # no date
>>> p.date=None
>>> p.full_clean() # this DOES error as it should
Traceback (most recent call last):
File "<console>", line 1, in <module>
File "/home/nigel/.virtualenvs/edge22/lib/python3.4/site-packages/django/db/models/base.py", line 1144, in full_clean
raise ValidationError(errors)
django.core.exceptions.ValidationError: {'date': ['This field cannot be null.']}
>>>
【问题讨论】:
-
您的 csv 文件中如何表示 None 值?您的代码缩进有错误,请参阅最后 4 行检查错误并保存的位置。
-
这不是代码错误。我在循环过程中积累了错误。如果有错误,则在循环之后显示所有错误,否则我重复循环执行 save() 而不是 full_clean()。 (这可能会引发数据库完整性错误,但这与这个问题无关)。
-
CSV 文件中的 Null 是两个逗号,它们之间没有任何内容。我还将数字列中的全空白字符串视为 null(这是用户将数据间隔而不是删除,这是一种常见的电子表格反模式)。