我在哪里出错了 C++ 类 [关闭]

Question

您好，这是我在堆栈溢出时的第一个主题（问题），我在 Code::Blocks 尝试了一个关于 c++ 类的项目，但出了点问题

#include <iostream>
using namespace std;

class char1
{
    public:
    string charName;
    float charLength;

    void printName()
    {
        cout<<"char name is"<<charName;
    }
};

int main()
{
    int charNAME;
    float charLENGTH;

    cout<<"write your char's name"<<endl;
    cin>>charNAME;

    cout<<"write your char's length"<<endl;
    cin>>charLENGTH;

    char1 name;
    char1 length;

    name.charName=charNAME;
    length.charLength=charLENGTH;

    return 0;
}

当我运行程序时，它问我 char 的名字我写了一些东西，在它询问 char 的长度之后 但是程序到此为止我什么都做不了 here is picture for help

Answer 1

对您的代码进行了一些修复，以向您展示如何在实践中使用您的类（包括一些 c++ 编码技巧）。

#include <string>
#include <iostream>

// using namespace std; <== don't do this 
// https://*.com/questions/1452721/why-is-using-namespace-std-considered-bad-practice

//class char1
class Character // <== give classes clear names, makes code more readable
{
public:
    std::string name;
    float length;

    // I understand you want to do this to test stuff.
    // but from a design point of view printing is not something
    // a character can do to himself 
    /*
    void printName()
    {
        cout << "char name is" << charName;
    }
    */
};

// bit offtopic but : 
// if you want to add support for printing your character
// its more common to overload operator<< for streams like this
std::ostream& operator<<(std::ostream& os, const Character& character)
{
    os << "Your character's name = " << character.name << ", and his/her length = " << character.length << "\n";
    return os;
}


int main()
{
    // int charNAME; in your class this is a string, be consistent.
    // float charLENGTH;

    // make an instance of the Character class
    Character character;

    std::cout << "Enter your char's name : "; // << endl; avoid using endl use "\n" if you want a newline
    std::cin >> character.name;

    std::cout << "Enter your char's length : "; // << endl;
    std::cin >> character.length;

    std::cout << "\n";
    std::cout << character; // this will now call your overloaded << operator 
    
    return 0;
}