【问题标题】:TypeError: Cannot read property 'then' of undefined on Promise in Express routeTypeError:无法读取 Express 路由中 Promise 上未定义的属性“then”
【发布时间】:2017-07-21 21:56:41
【问题描述】:

我的 MEEN 应用程序中有一个接受文件上传的路由,然后将数据传递给解析文件并将其存储在数组中的辅助模块,一旦这个辅助模块完成,我想将它传递给另一个模块然后将处理返回的数组。出于某种原因,即使我在帮助程序末尾有一个 return 语句,then 方法也是未定义的。

路线:

router.route('/tools/sku/reactivate').post(upload.single('csvdata'),function(req,res){
        console.log('handing request over to helper.csv');
        csv.reader(req,res).then(sku.reactivate(data));
    });

csv.reader:

var csv = require('csv-parse');
var multer = require('multer');
var fs = require('fs');

module.exports.reader = function(req,res){
  //define array for holding csv data in this case skus
    const csvArray = [];
    //max number of columns in csv
    const maxColumns = parseInt(req.body.maxColumns);
    //create an array of column headers to check chunks against so we dont parse headers
    let columnHeader = req.body.moduleTarget.split(',');
    //loopThrough Array to create arrays inside container array for each column
    for(var i = 0; i < maxColumns; i++){
        csvArray.push([]);
    }
    //define filesystem readstream from uploaded file
    let readStream = fs.createReadStream(req.file.path).pipe(csv());
    //push csv data to array ignoring headers to csvArray
    readStream.on('data', function(chunk){
        //get number of keys in the dataChunk
        let chunkLength = Object.keys(chunk).length;
        //check column count on csv if greater than expected throw error
        if(chunk[maxColumns]){
            throw '[ERROR] More columns than expected in CSV, please fix and try again';
        }else{
            //loop through chunk keys and store each one in csvArray by index
            for(var i = 0; i < chunkLength; i++){
                //if chunk at this index doesnt equal column header and chunk at this index exists push to array
                if(chunk[i] !== columnHeader[i] && chunk[i]){
                    csvArray[i].push(chunk[i]);
                }
            }
        }
    });
    //error handling
    readStream.on('error',function(err){
        console.log('Error while reading file stream '+ err);
        res.json({message:err,errorType:'1'});
    });
    readStream.on('end',function(){
        console.log('finished reading csv returning array back to router to process next middleware');
        return csvArray;
    });
}

我在 readStream 结束侦听器上的 console.log 消息后立即收到错误

【问题讨论】:

    标签: javascript node.js express promise


    【解决方案1】:

    来自 Express 网站。 https://expressjs.com/en/advanced/best-practice-performance.html

    TL;DR

    尝试将阅读器模块的内容包装在一个 Promise 中并返回该 Promise。

    ...但是,有两个警告: 您的所有异步代码都必须返回承诺(发射器除外)。如果特定库不返回承诺,请使用 Bluebird.promisifyAll() 等辅助函数转换基础对象。 事件发射器(如流)仍然可能导致未捕获的异常。因此,请确保您正确处理错误事件;例如:

    app.get('/', wrap(async (req, res, next) => {
      let company = await getCompanyById(req.query.id)
      let stream = getLogoStreamById(company.id)
      stream.on('error', next).pipe(res)
    }))
    

    @example:::

    module.exports.reader = function(req,res){
        return new Promise((resolve, reject)=>{
          //define array for holding csv data in this case skus
            const csvArray = [];
            //max number of columns in csv
            const maxColumns = parseInt(req.body.maxColumns);
            //create an array of column headers to check chunks against so we dont parse headers
            let columnHeader = req.body.moduleTarget.split(',');
    
                ...
            //error handling
            readStream.on('error',function(err){
                console.log('Error while reading file stream '+ err);
                res.json({message:err,errorType:'1'});
            });
            readStream.on('end',function(){
                console.log('finished reading csv returning array back to router to process next middleware');
                return csvArray;
            });
        })
    }
    

    【讨论】:

    • 做到了,我的 then 语法也不正确。感谢铜锅的帮助
    • 最好不要将res 传递给csv.reader() 并将响应组合回调用者的.then.catch 处理程序中。这对于由csv.reader() 引起的任何同步抛出的错误具有特别的优势,就目前而言,这些错误仍然未被捕获和报告。为了使模式健壮,请确保在csv.reader() 拒绝其承诺的两种情况下,它使用Error 对象(或RangeError 等)这样做 - 所以最终的.catch 处理程序,如果被调用,保证接收到正确的错误对象(带有.message 属性),而不是字符串。
    猜你喜欢
    • 2014-11-26
    • 2018-01-15
    • 2018-06-02
    • 1970-01-01
    • 2019-08-19
    • 2014-09-07
    • 1970-01-01
    • 1970-01-01
    相关资源
    最近更新 更多