如何在代码不递归的情况下为 IDisposable 实现 Dispose？ [关闭]

Question

我正在重构一些代码，在上面使用 Resharper，然后遇到了这个问题：

public virtual void Dispose()
{
    this.Dispose();
}

...哪个 R# 标记为“函数在所有路径上都是递归的”

这是有道理的；但是，“官方”（straight from the horse's mouth）代码有些相似（Dispose 调用 Dispose）：

public void Dispose()
{
    Dispose(true);
    // This object will be cleaned up by the Dispose method. 
    // Therefore, you should call GC.SupressFinalize to 
    // take this object off the finalization queue 
    // and prevent finalization code for this object 
    // from executing a second time.
    GC.SuppressFinalize(this);
}

...不过，该代码甚至无法编译；我得到，“方法 'Dispose' 没有重载需要 '1' 个参数”

那么我怎样才能既实现 Dispose() 又不让它递归呢？

更新

如果我试试这个（来自here）：

try
{
    Dispose(true); //true: safe to free managed resources
}
finally
{
    base.Dispose();
}

...我明白了，“'object' 不包含 'Dispose' 的定义”和“方法 'Dispose' 没有重载需要 '1' 个参数”

Answer 1

看来您需要正确实现 Dispose 模式：

public class MyThingWithResources : IDisposable
{
    ~MyTHingWithResources()
    {
        // This is a finalizer and is an optional part.
        // Finalizers are not generally required, and are 
        // intended for clearing up unmanaged resources
        // that your class might hold

        // Finalizers are called by the garbage collector
        // So you can never be sure when they are going to
        // be called.

        this.Dispose(false);
    }

    public void Dispose()
    {
        this.Dispose(true);
        GC.SuppressFinalize(this);
    }

    protected virtual void Dispose(bool disposing)
    {
        if (disposing)
        {
            // if disposing is true, then the method 
            // is being called as part of a managed disposal
            // this means it should be safe to dispose of managed 
            // resources (.Net classes such as System.IO.Stream )
        }

        // If disposing is false, the Dispose method was called 
        // from the finaliser, so you're in the last chance saloon 
        // as far as tidying stuff up is concerned.
        // Only unmanaged resources (and the objects that wrap them)
        // should be tidied up in this scenario
    }
}