解析云函数 - 代码未按顺序执行

Question

如果满足某些条件，我有以下函数来更新行，并且在 for 循环结束时，响应包括更新的行数。尽管更新的行数超过零，但响应显示为零。查看日志，似乎 reponse.success() 在完成 for 循环之前触发。

为什么会这样？

Parse.Cloud.define("reset", function(request, response) {


    var isSaveNeeded = false
  var Query = new Parse.Query("price");
  Query.equalTo('isActive', true);
  Query.find({useMasterKey:true})
      .then((results) => {
        console.log("Found " + results.length + " price rows")
        var currentDate = moment()
        var noOfRowsUpdated = 0
        for (let i = 0; i < results.length; ++i) {
            var valid_till_date = results[i].get('valid_till_date');

            if (valid_till_date == null) {
                // if user had not selected valid_till_date then set to expire after system max no of days
                var updatedAt = results[i].get('updatedAt');
                if (currentDate.diff(updatedAt,'days') > 10) {
                  console.log("Permanent change row to be set inactive. Updated at - " + currentDate.diff(updatedAt)+ updatedAt)
                    results[i].set('isActive',false)
                    isSaveNeeded = true
                }
            } else if (currentDate.diff(valid_till_date) > 0) {
                // check whether valid_till_date has passed
                console.log("Found row with elapsed valid date "  + results[i].id)
                results[i].set("isActive",false)
                isSaveNeeded = true
            }
            if (isSaveNeeded == true) {
              console.log("Record needs to be saved for " + results[i].id)
              results[i].save(null, {useMasterKey:true})
                .then(function (user) {
                    ++noOfRowsUpdated
                    console.log("reset : Object ID: " + results[i].id + " saved - " + noOfRowsUpdated)
                  })
                .catch(function (error) {
                    console.log("reset : Error saving Object ID: " + results[i].id + error);
                    response.error(error);
                })
            } else {

              console.log("Record not to be saved for " + results[i].id)
            }
            isSaveNeeded = false
        } // end of for loop
        //BELOW IS EXECUTED BEFORE FOR LOOP COMPLETES
        console.log("Updated " + noOfRowsUpdated +" price rows");
        response.success("Updated " + noOfRowsUpdated +" price rows")
      }) // end of .then((results) 
      .catch(function(error) {
        response.error("Failed to fetch from price" + error );
      });
});

Answer 1

Parse.com 的 save 异步运行，因此循环在保存发生之前完成。解决方案是稍微重新组织一下代码，并在执行响应函数之前等待保存。

诀窍是将每次保存返回的承诺收集到一个数组中，然后使用Promise.when()（Promise.all() 的同义词）等待这些承诺的履行

为了更清楚，排除“需要保存”的逻辑，所以这个云功能只能处理数据库......

Parse.Cloud.define("reset", function(request, response) {
    var Query = new Parse.Query("price");
    Query.equalTo('isActive', true);
    Query.find({useMasterKey:true}).then((results) => {
        console.log("Found " + results.length + " price rows");
        // assuming ES6 or something like underscore
        let pricesToSave = results.filter(price => priceNeedsSave(price));

        // here's the important part, collect the promise from each save
        // proceed only after the promises have completed
        let promises =  pricesToSave.map(price => price.save(null, {useMasterKey:true}));
        return Parse.Promise.when(promises).then(() => pricesToSave.length);
    }).then(count => {
        response.success("Updated " + count +" price rows");
    }).catch(error => {
        response.error("Failed to fetch from price" + error );
    });
}

为了完整起见，下面是分解出的需求保存逻辑。 （OP应该检查一下，我只是复制了循环体）......

function priceNeedsSave(price) {
    var isSaveNeeded = false;
    var currentDate = moment()

    var valid_till_date = price.get('valid_till_date');
    if (valid_till_date == null) {
        // if user had not selected valid_till_date then set to expire after system max no of days
        var updatedAt = price.get('updatedAt');
        if (currentDate.diff(updatedAt,'days') > 10) {
          console.log("Permanent change row to be set inactive. Updated at - " + currentDate.diff(updatedAt)+ updatedAt)
            price.set('isActive',false)
            isSaveNeeded = true
        }
    } else if (currentDate.diff(valid_till_date) > 0) {
        // check whether valid_till_date has passed
        console.log("Found row with elapsed valid date "  + price.id)
        price.set("isActive",false)
        isSaveNeeded = true
    }
    return isSaveNeeded;
}