将数组数组作为参数发送，然后再次循环遍历每个数组

Question

我有一个场景，我向所有用户发送通知邮件。因此我需要获取所有信息，例如 useremail、videocount、imagecount、videoids、imageids 等并发送到 usermailer 以发送邮件。我想简化这个过程通过将所有必需的参数发送到方法并再次循环遍历每个数组。

    for example:-

    ###########the below code is in a loop of users################

    User.signed_in_users.find_in_batches(:batch_size => 100 ) { |users| users.each { |user| 

    vcount=Video.where(:users_notified=>f).count
    icount=Image.where(:users_notified=>f).count
    acount=Audio.where(:users_notified=>f).count

    @count << vcount + icount + acount

    vcat=###ALL VIDEO CATEGORIES
    icat=###ALL IMAGE CATEGORIES
    acat=###ALL AUDIO CATEGORIES

    @cats << vcat + icat + acat...and many more


   ###########now sending all these parameter to mailer(array of arrays)
   ####how i can simplify this call 
UserMailer.notify_user(user.email,@video_cat,@video_count,@image_cat,@image_count,@audio_cat,@audio_count,@place_cat,@place_count,@Lpage_count,@Dpage_count).deliver


    } } ###loop ends

Answer 1

我不知道您为什么要多次尝试获取相同的值。您的以下代码无缘无故地运行了多次。

vcount=Video.where(:users_notified=>f).count
icount=Image.where(:users_notified=>f).count
acount=Audio.where(:users_notified=>f).count

@count << vcount + icount + acount

vcat=###ALL VIDEO CATEGORIES
icat=###ALL IMAGE CATEGORIES
acat=###ALL AUDIO CATEGORIES

@cats << vcat + icat + acat

因为您正在迭代 user 对象。而且这一堆代码中没有user的交互。所以你可以把它从你的每个块中拿出来：

vcount=Video.where(:users_notified=>f).count
icount=Image.where(:users_notified=>f).count
acount=Audio.where(:users_notified=>f).count

@count << vcount + icount + acount

vcat=###ALL VIDEO CATEGORIES
icat=###ALL IMAGE CATEGORIES
acat=###ALL AUDIO CATEGORIES

@cats << vcat + icat + acat

User.signed_in_users.find_in_batches(:batch_size => 100 ) { |users| users.each { |user| 

###########now sending all these parameter to mailer(array of arrays)
  UserMailer.notify_user(user.email,@count,@cats)

} } ###loop ends