【问题标题】:Rspec test fail Hartl tutorial Chap. 9.1 - fails on Edit User titleRspec 测试失败 Hartl 教程章节。 9.1 - 编辑用户标题失败
【发布时间】:2013-05-12 02:59:06
【问题描述】:

我仍然坚持编辑用户第 9.1.1 章的测试,尽管我制定了第一组错误消息——感谢你们的帮助。 在我所在的同一位置出现了一个新的测试失败错误,我被鼓励提出一个新问题。我会把我更新的代码放在这里。

我正在运行这个测试: $ bundle exec rspec spec/requests/user_pages_spec.rb -e "edit page" 经过大量搜索,我只是看不到错误来自哪里。 我也更新了 Capybara 2.0.0

Failures:

  1) User pages signup edit page 
     Failure/Error: it { should have_selector('title', text: "Edit user") }
     Capybara::ExpectationNotMet:
       expected to find css "title" with text "Edit user" but there were no matches. Also found "",         which matched the selector but not all filters.
     # ./spec/requests/user_pages_spec.rb:60:in `block (5 levels) in <top (required)>'

Finished in 0.56475 seconds
3 examples, 1 failure

这是用户页面规范:

require 'spec_helper'

describe "User pages" do

  subject { page }

  describe "profile page" do
    let(:user) { FactoryGirl.create(:user) }
    before { visit user_path(user) }

    it { should have_selector('h1',   text: user.name) }
    it { should have_selector('title', text: user.name) }
  end

  describe "signup page" do
    before { visit signup_path }

    it { should have_selector('h1',   text: 'Sign up') }
    it { should have_selector('title', text: full_title('Sign up')) }
  end

describe "signup" do

    before { visit signup_path }

    describe "with invalid information" do
      it "should not create a user" do
        expect { click_button submit }.not_to change(User, :count)
      end


    describe "with valid information" do
      before do
        fill_in "Name",         with: "Example User"
        fill_in "Email",        with: "user@example.com"
        fill_in "Password",     with: "foobar"
        fill_in "Confirmation", with: "foobar"
      end

      it "should create a user" do
        expect { click_button submit }.to change(User, :count).by(1)
      end

     describe "after saving the user" do
       before { click_button submit }
      it { should have_link('Sign out') }   
     end
      end
   end

      describe "edit" do
            let(:user) { FactoryGirl.create(:user) }
        before { visit edit_user_path(user) }

        describe "page" do
          it { should have_selector('h1',   text: "Update your profile") }
          it { should have_selector('title', text: "Edit user") }
          it { should have_link('change', href: 'http://gravatar.com/emails') }
        end

        describe "with invalid information" do
          before { click_button "Save changes" }

          it { should have_content('error') }
  end
  end
end
end

这是我修改后的用户控制器:

class UsersController < ApplicationController

  def show
    @user = User.find(params[:id])
  end

  def new
    @user = User.new
  end

   def create
    @user = User.new(params[:user])
    if @user.save
      sign_in @user
      flash[:success] = "Welcome to the Your App!"
      redirect_to @user
    else
      render 'new'    
      end
    end

  def edit
    @user = User.find(params[:id])
  end
end

还附上了edit.html.erb

<% provide(:title, "Edit user") %>
<h1>Update your profile</h1>

<div class="row">
  <div class="span6 offset3">
    <%= form_for(@user) do |f| %>
    <%= render 'shared/error_messages' %>

      <%= f.label :name %>
      <%= f.text_field :name %>

      <%= f.label :email %>
      <%= f.text_field :email %>

      <%= f.label :password %>
      <%= f.password_field :password %>

      <%= f.label :password_confirmation, "Confirmation" %>
      <%= f.password_field :password_confirmation %>

      <%= f.submit "Save changes", class: "btn btn-large btn-primary" %>
    <% end %>

    <% gravatar_for @user %>
    <a href="http://gravatar.com/emails">change</a>
  </div>

这是身份验证规范:

require 'spec_helper'

describe "Authentication" do

  subject { page }

   describe "signin page" do
    before { visit signin_path }

    it { should have_selector('h1',   text: 'Sign in') }
    it { should have_selector('title', text: full_title('Sign in')) }
    end

    describe "signin" do
    before { visit signin_path }

    describe "with invalid information" do
      before { click_button "Sign in" }

    it { should have_selector('title',   text: 'Sign in') }
    it { should have_selector('div.alert.alert-error', text: 'Invalid') }

     describe "after visiting another page" do
      before { click_link "Home" }

    it { should_not have_selector('div.alert.alert-error') }
  end
end


  describe "with valid information" do
    let(:user) { FactoryGirl.create(:user) }
      before do
          fill_in "Email", with: user.email
          fill_in "Password", with: user.password
          click_button "Sign in"
     end

    it { should have_selector('title',   text: user.name) }
    it { should have_link('Profile', href: user_path(user)) }
        #it { should have_link('Settings', href: edit_user_path(user)) }
    it { should have_link('Sign out', href: signout_path) }
    it { should_not have_link('Sign in', href: signin_path)}


  describe "followed by signout" do
    before { click_link "Sign out" }
    it { should have_link('Sign in') }  
end
end 
end
end

还有 Header html.erb 文件

<header class="navbar navbar-fixed-top navbar-inverse">
<div class="navbar-inner">
    <div class="container">
        <%=link_to "sample app", root_path, id: "logo" %>
        <nav>
            <ul class="nav pull-right">
                <li><%= link_to "Home",   root_path %></li>
                <li><%= link_to "Help",    help_path %></li>
                          <% if signed_in? %>   
                          <li><%= link_to "Users", users_path %></li>
    <li id="fat-menu" class="dropdown">"
      <a href="#" class="dropdown-toggle" data-toggle="dropdown">
        Account <b class="caret"></b>
      </a>
      <ul class="dropdown-menu">
        <li><%= link_to "Profile", current_user %></li>
        <li><%= link_to "Settings", edit_user_path(current_user) %></li>
        <li class="divider"></li>
        <li>
          <%= link_to "Sign out", signout_path, method: "delete" %>
        </li>
      </ul>
    </li>
  <% else %>                    

    <li><%= link_to "Sign in", signin_path %></li>
    <% end %>                   
            </ul>
        </nav>
    </div>
</div>  
</header>

【问题讨论】:

  • 试试content_for :title {'Edit user'}
  • 这一行没有改变错误
  • 标题标签也没有关闭,虽然它可能是一个sn-p。
  • header 标签在原版中。谢谢迈克尔。

标签: ruby-on-rails rspec railstutorial.org


【解决方案1】:

看起来您的描述块嵌套可能有误。

'用户页面注册编辑页面'

这表明编辑页面嵌套在“注册”中,它应该在用户页面下。

这可能会导致上下文错误

require 'spec_helper'

describe "User pages" do

  subject { page }

  describe "profile page" do
    let(:user) { FactoryGirl.create(:user) }
    before { visit user_path(user) }

    it { should have_selector('h1', text: user.name) }
    it { should have_selector('title', text: user.name) }
  end

  describe "signup page" do
    before { visit signup_path }

    it { should have_selector('h1', text: 'Sign up') }
    it { should have_selector('title', text: full_title('Sign up')) }
  end

  describe "signup" do

    before { visit signup_path }

    describe "with invalid information" do
      it "should not create a user" do
        expect { click_button submit }.not_to change(User, :count)
      end


      describe "with valid information" do
        before do
          fill_in "Name", with: "Example User"
          fill_in "Email", with: "user@example.com"
          fill_in "Password", with: "foobar"
          fill_in "Confirmation", with: "foobar"
        end

        it "should create a user" do
          expect { click_button submit }.to change(User, :count).by(1)
        end

        describe "after saving the user" do
          before { click_button submit }
          it { should have_link('Sign out') }
        end
      end
    end
  end


  describe "edit" do
    let(:user) { FactoryGirl.create(:user) }
    before { visit edit_user_path(user) }

    describe "page" do
      it { should have_selector('h1', text: "Update your profile") }
      it { should have_selector('title', text: "Edit user") }
      it { should have_link('change', href: 'http://gravatar.com/emails') }
    end

    describe "with invalid information" do
      before { click_button "Save changes" }

      it { should have_content('error') }
    end
  end
end

【讨论】:

  • 谢谢@muttonlamb 我会调查的。你推荐在哪里学习 Rails 约定中的嵌套?
  • 这不是关于在 Rails 中的嵌套,而是关于如何在 RSpec 中设置测试上下文。不同级别的描述块设置不同的上下文。我已经更新了帮助的答案 - 基本上我认为你这样做,目的是不正常的
  • 为了在用户页面下嵌套编辑页面,我是否需要更改缩进或向上移动描述部分(最后 16 行左右)?块是否需要以不同的顺序放置?我正在尝试在github上研究hartl的代码。
  • 如果您复制代码,并与您最初的发布进行比较,在开始描述“编辑”之前,有一个结束描述“注册”的结尾,这是唯一的变化
  • 不幸的是,我确实添加了额外的“结束”,但它并没有改变错误:(虽然我确实清理了代码 - 感谢@muttonlamb的提示
猜你喜欢
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
相关资源
最近更新 更多