两个函数单独工作，但不能一起工作

Question

我有两个函数 rmdup 和 rmvow，当我单独运行这些函数时，它们运行良好，但是当它们一起在一个程序中时，它们就完全不工作了？

int rmdup ( char name[] ) 
{

  char nodup[20] = {''\0''};
  int l = strlen(name);
  int i = 0, j, k = 0;

  while ( i < l ) 
  {
    j = i + 1;

    if ( name[i] == name[j] ) 
    {
      nodup[k] = name[i];
      i+2;
      while(nodup[k] == name[i]) 
      {
        i++;
      }
      k++;
    }
    else 
    {
      i++;
    }

    nodup[k] = ''\0'';
  }

  strcpy(name, nodup);
}

上面的工作是孤立的，下面的也是。

int rmvow ( char name[]  ) 
{
  char novow[20] = {''\0''};
  int l = strlen(name);
  int i = 0, j = 0;

  while ( i < l ) 
  {
    if ( name[i] == ''a'' || 
         name[i] == ''e'' ||
         name[i] == ''i'' ||
         name[i] == ''o'' ||
         name[i] == ''u'' ) 
    {
      i++;
    }
    else 
    {
      novow[j] = name[i];
      i++;
      j++;
    }

    novow[j] = ''\0'';
  }

  strcpy(name, novow);
}

Answer 1

正确且完整的代码如下输出：

aabbccddeeff
abcdef
bcdf

这似乎是正确的。唯一更正的是rmdup() 中的i += 2 和有效字符常量。在没有任何其他信息的情况下编译为 C 代码。

#include <stdio.h>
#include <string.h>

int rmdup ( char name[] ) ;
int rmvow ( char name[] ) ;

int main(void) 
{
    char test[] = "aabbccddeeff" ;

    printf( "%s\n", test ) ;
    rmdup( test ) ;

    printf( "%s\n", test ) ;
    rmvow( test ) ;

    printf( "%s\n", test ) ;

    return 0;
}

int rmdup ( char name[] ) 
{

  char nodup[20] = {'\0'};
  int l = strlen(name);
  int i = 0, j, k = 0;

  while ( i < l ) 
  {
    j = i + 1;

    if ( name[i] == name[j] ) 
    {
      nodup[k] = name[i];
      i+=2;
      while(nodup[k] == name[i]) 
      {
        i++;
      }
      k++;
    }
    else 
    {
      i++;
    }

    nodup[k] = '\0';
  }

  strcpy(name, nodup);
}

int rmvow ( char name[]  ) 
{
  char novow[20] = {'\0'};
  int l = strlen(name);
  int i = 0, j = 0;

  while ( i < l ) 
  {
    if ( name[i] == 'a' || 
         name[i] == 'e' ||
         name[i] == 'i' ||
         name[i] == 'o' ||
         name[i] == 'u' ) 
    {
      i++;
    }
    else 
    {
      novow[j] = name[i];
      i++;
      j++;
    }

    novow[j] = '\0';
  }

  strcpy(name, novow);
}

但是代码很危险，因为没有防止novow 或nodup 数组溢出的保护措施。两者都是不必要的；在这两种情况下，您都可以将数据直接写回name，因为目标索引始终是

int rmdup ( char name[] ) 
{

  int l = strlen(name);
  int i = 0, j, k = 0;

  while ( i < l ) 
  {
    j = i + 1;

    if ( name[i] == name[j] ) 
    {
      name[k] = name[i];
      i+=2;
      while(name[k] == name[i]) 
      {
        i++;
      }
      k++;
    }
    else 
    {
      i++;
    }

    name[k] = '\0';
  }
}

int rmvow ( char name[]  ) 
{
  int l = strlen(name);
  int i = 0, j = 0;

  while ( i < l ) 
  {
    if ( name[i] == 'a' || 
         name[i] == 'e' ||
         name[i] == 'i' ||
         name[i] == 'o' ||
         name[i] == 'u' ) 
    {
      i++;
    }
    else 
    {
      name[j] = name[i];
      i++;
      j++;
    }

    name[j] = '\0';
  }
}