将单词压入堆栈并检查回文

Question

我们的老师给我们布置了作业，使用数据结构“Stack”检查单词的回文。

以下是我为以下问题编写的代码：-

# include <stdio.h>
# include <stdlib.h>
# include <string.h>
# include <stdbool.h>

struct Stack
{
    int top;
    int capacity;
    char *array;
};

void push(struct Stack stack, char a) //Push function.
{
    stack.array[++stack.top] = a; //Helps to push charater to a stack.
}

char pop(struct Stack stack) //Pop function.
{
    return stack.array[stack.top--]; //Helps to pop character from a stack.
}

int main(void)
{
    struct Stack original; //Original stack where the "Original" word will be pushed.
    original.top = -1;
    original.capacity = 10;
    original.array = calloc(original.capacity, sizeof(char));

    struct Stack checker; //Another stack that "Checks" whether the word is palindrome or not.
    checker.top = -1;
    checker.capacity = 10;
    checker.array = calloc(checker.capacity, sizeof(char));

    while(getchar()!='\0') //Getting all the characters from the stdin buffer and pushing it into "Original" stack.
    {
        push(original, getchar());
    }

    while(original.top != -1)
    {
        push(checker,pop(original)); //Popping from "Original" stack and pushing it to "Checker" stack.
    }

    while(checker.top != -1)
    {
        original.top = checker.top;
        if(original.array[original.top] != checker.array[checker.top]) //Checking every character in the stack if it is excatly same or not.
        {
            printf("It is not a palindrome.\n");
            return EXIT_SUCCESS;
        }
        else
        {
            checker.top = checker.top - 1;
        }
    }

    if(checker.top == -1)
    {
        printf("It is a palindrome.\n");
    }

    return 0;
}

无论我在以下行中遇到问题：-

while(getchar()!='\0') //Getting all the characters from the stdin buffer and pushing it into "Original" stack.
{
    push(original, getchar());
}

以下循环无限运行。我添加以下行的目的是我想将stdin buffer 和push 中的单个字符添加到original 堆栈中，直到遇到'\0'。

我在这里做错了什么？这样做违法吗？

附录：-

示例输入 1：- 公民

预期输出：- 这是一个回文。

示例输入 2：- 夫人

预期输出：- 这不是回文。

附言

以下代码：-

while(getchar()!='\0') //Getting all the characters from the stdin buffer and pushing it into "Original" stack.
{
    push(original, getchar());
}

现在已替换为：-

int c;
int i = 0;

while ( i < original.capacity && ( c = getchar() ) != EOF && c != '\n' )
{
    push(original, c );
    ++i;
}

现在工作完美，但是现在，对于每个单词，我的代码都会给出输出：-

这是一个回文。

我在哪里错误地应用了堆栈的概念？

Answer 1

这个循环

while(getchar()!='\0') //Getting all the characters from the stdin buffer and pushing it into "Original" stack.
{
    push(original, getchar());
}

在任何情况下都是错误的，因为它读取字符两次：在循环的条件下和在循环的主体内。

并且您必须使用例如键盘明确输入 0。

您需要的是以下内容

int c;
int i = 0;

while ( i < original.capacity && ( c = getchar() ) != EOF && c != '\n' )
{
    push(original, c );
    ++i;
} 

还有一个问题。这些函数处理传递参数的副本。

void push(struct Stack stack, char a) //Push function.
{
    stack.array[++stack.top] = a; //Helps to push charater to a stack.
}

char pop(struct Stack stack) //Pop function.
{
    return stack.array[stack.top--]; //Helps to pop character from a stack.
}

你必须像这样声明它们

void push(struct Stack *stack, char a) //Push function.
{
    stack-?array[++stack->top] = a; //Helps to push charater to a stack.
}

char pop(struct Stack *stack) //Pop function.
{
    return stack->array[stack->top--]; //Helps to pop character from a stack.
}

即通过指针通过引用传递原始堆栈。

并调用这些函数，例如

push( &original, c );

否则数据成员top不会改变。

这是您的更新程序

# include <stdio.h>
# include <stdlib.h>

struct Stack
{
    int top;
    int capacity;
    char *array;
};

void push(struct Stack *stack, char a) //Push function.
{
    stack->array[++stack->top] = a; //Helps to push charater to a stack.
}

char pop(struct Stack *stack) //Pop function.
{
    return stack->array[stack->top--]; //Helps to pop character from a stack.
}

int main(void)
{
    struct Stack original; //Original stack where the "Original" word will be pushed.
    original.top = -1;
    original.capacity = 10;
    original.array = calloc(original.capacity, sizeof(char));

    struct Stack checker; //Another stack that "Checks" whether the word is palindrome or not.
    checker.top = -1;
    checker.capacity = 10;
    checker.array = calloc(checker.capacity, sizeof(char));

    int c;
    int i = 0;

    while ( i < original.capacity && ( c = getchar() ) != EOF && c != '\n' )
    {
        push( &original, c );
        ++i;
    }

    while(original.top != -1)
    {
        push(&checker,pop(&original)); //Popping from "Original" stack and pushing it to "Checker" stack.
    }

    while(checker.top != -1)
    {
        original.top = checker.top;
        if(original.array[original.top] != checker.array[checker.top]) //Checking every character in the stack if it is excatly same or not.
        {
            printf("It is not a palindrome.\n");
            return EXIT_SUCCESS;
        }
        else
        {
            checker.top = checker.top - 1;
        }
    }

    if(checker.top == -1)
    {
        printf("It is a palindrome.\n");
    }

    return 0;
}

考虑到这些标题

#include <string.h>
#include <stdbool.h>

是多余的。