Auto_Fix 用户的游标内的游标

Question

我有以下脚本，我希望能够针对除系统数据库之外的数据库的动态列表运行它。这已经够直截了当了。棘手的一点是每个数据库可能有不同的用户列表来运行修复命令。这会是第三个光标吗？我在下面的尝试没有正确填充每个数据库的用户。任何帮助将不胜感激。

SET nocount ON
GO
SET QUOTED_IDENTIFIER OFF
GO
--
-- Declare and define variables
--

DECLARE @databasename VARCHAR(50) -- database name
DECLARE @sqlcommand nvarchar(256) -- SQL Command generated

-- 在@name 中包含范围内的数据库名称

DECLARE db_cursor CURSOR FOR
  SELECT NAME
  FROM   master.dbo.sysdatabases
  WHERE  NAME NOT IN ( 'master', 'model', 'msdb', 'tempdb', 'DBATools' ) -- don't include the databases
OPEN db_cursor

FETCH NEXT FROM db_cursor INTO @databasename

WHILE @@FETCH_STATUS = 0
  BEGIN
      PRINT 'Fixing Logins for '
            + Cast(@databasename AS VARCHAR)

      DECLARE curSQL CURSOR FOR
        SELECT "USE " + ( @databasename ) + ";" + " exec sp_change_users_login 'AUTO_FIX','" + NAME + "'"

      SELECT NAME
      FROM   sys.sysusers
      WHERE  issqluser = 1
             AND NAME NOT IN ( 'dbo', 'guest', 'INFORMATION_SCHEMA', 'sys' )

      OPEN curSQL

      FETCH curSQL INTO @sqlcommand

      WHILE @@FETCH_STATUS = 0
        BEGIN
            PRINT @sqlcommand
            EXEC (@sqlcommand)
            FETCH curSQL INTO @sqlcommand
        END

      CLOSE curSQL
      DEALLOCATE curSQL

      FETCH NEXT FROM db_cursor INTO @databasename
  END

CLOSE db_cursor

DEALLOCATE db_cursor 

Answer 1

或者你可以不用光标。

DECLARE @Output NVARCHAR(MAX)
SET @Output = ''

SELECT @Output = @Output +
'--Fixing Logins For ' + name + CHAR(10) + 
'USE ' + name + CHAR(10) + 
'EXEC sp_change_users_login ''AUTO_FIX'','''+
(
    SELECT  b.name 
    FROM   sys.sysusers as b
    WHERE  issqluser = 1
    AND b.name NOT IN ( 'dbo', 'guest', 'INFORMATION_SCHEMA', 'sys' )
)
+''''+CHAR(10)+CHAR(10)

FROM  master.dbo.sysdatabases
WHERE  NAME NOT IN ( 'master', 'model', 'msdb', 'tempdb', 'DBATools' )
PRINT @Output

Answer 2

您的过程的主要内容是，与 PHP 不同，TSQL 不能互换使用单引号和双引号。所以我修复了你的动态 SQL 字符串。

另一个小问题似乎是游标声明中的脱节查询 - 在您的声明中，您使用 select 子句跟随第二个声明，没有伴随的 from 子句，这将引发“名称”无法为该游标找到。所以我也解决了这个问题。

DECLARE @databasename SYSNAME, @sqlcommand nvarchar(max)
DECLARE db_cursor CURSOR FOR
    SELECT NAME
    FROM   master.dbo.sysdatabases
    WHERE  NAME NOT IN ( 'master', 'model', 'msdb', 'tempdb', 'DBATools' ) -- don't include the databases
OPEN db_cursor

FETCH NEXT FROM db_cursor INTO @databasename

WHILE @@FETCH_STATUS = 0
BEGIN
    PRINT 'Fixing Logins for '
    + Cast(@databasename AS VARCHAR)

    DECLARE curSQL CURSOR FOR
        SELECT 'USE ' + @databasename + ';' + ' exec sp_change_users_login ''AUTO_FIX'',''' + NAME + ''';'
        FROM   sys.database_principals
        WHERE  Type='S'
            AND NAME NOT IN ( 'dbo', 'guest', 'INFORMATION_SCHEMA', 'sys' )

    OPEN curSQL

    FETCH curSQL INTO @sqlcommand

    WHILE @@FETCH_STATUS = 0
    BEGIN
        PRINT @sqlcommand
        --EXEC (@sqlcommand)
        FETCH curSQL INTO @sqlcommand
    END

    CLOSE curSQL
    DEALLOCATE curSQL

    FETCH NEXT FROM db_cursor INTO @databasename
END

CLOSE db_cursor

DEALLOCATE db_cursor 

编辑：根据评论将表切换到 database_principals 而不是 sys.sysusers。