多次执行函数或创建存储过程

Question

假设我有这样的功能

SELECT 
    ROW_NUMBER() OVER (ORDER BY T1.FinalScore desc) as Position, 
    T1.Employee, T1.FinalScore
FROM 
    (SELECT 
         Position, Employee, AVG(Score) as FinalScore
     FROM 
         dbo.Answers
     WHERE 
         DATEPART(year, EvaluationDate) = @Year
     GROUP BY   
         Employee) as T1

这将返回一个像这样的表：

|--------|----------|-------|
|Position| Employee | FScore|
|========|==========|=======|
|   1    |   John   |  5.6  |
|   2    |   Tom    |  4.8  |
|   3    |   Paul   |  3.6  |
|   4    |   Mark   |  2.0  |

现在我需要用之前的表格和往年的信息创建一个趋势图。

我的问题是，最佳实践是什么，我是否应该从我的 asp.net 页面多次调用我的函数来检索多个表，并处理我页面上的信息。

或者我应该创建一个存储过程，多次执行此函数并将数据插入到临时表中？像这样：

CREATE TABLE #TOP 
(
     Position int, 
     Employee nvarchar(60), 
     Score decimal(18,2)
)

DECLARE @Flag as int

SET @Flag = @Year - 3

WHILE (@Year > @Flag)
BEGIN
   INSERT INTO #TOP
       SELECT * 
       FROM dbo.MyFunction(@Year)

   SET @Year = @Year -1
END

SELECT * FROM #TOP
DROP TABLE #TOP

Answer 1

首先，您可以将查询简化为：

   SELECT row_number() over (order by avg(Score)) as position,
          Employee, AVG(Score) as FinalScore
   FROM dbo.Answers
   WHERE DATEPART(year, EvaluationDate) = @Year
   GROUP BY Employee;

然后，如果你想要这个所有年份，请使用partition by：

   SELECT row_number() over (partition by year(EvaluationDate) order by avg(Score)) as position,
          Employee, AVG(Score) as FinalScore
   FROM dbo.Answers
   GROUP BY Employee, year(EvaluationDate);