【发布时间】:2020-12-30 17:44:46
【问题描述】:
我完成了一个 - 非常菜鸟的创建,因为我仍然是菜鸟 :( - 充当银行账户的程序。
我有main.cpp、Account.cpp、Account.h。
在main.cpp 我有:
#include <iostream>
#include <string>
#include "Account.h"
int main()
{
Account Luigis;
Luigis.set_name("Luigi's Account");
Luigis.set_balance(0);
std::string letter;
do {
std::cout << "Your current balance is: " << Luigis.get_balance() << std::endl;
std::cout << "What would you like, to deposit, to withdraw or to exit?" << std::endl;
std::cout << "(D for 'Deposit, W for 'Withdraw' and Q for 'Exit') D/W/Q ";
std::cin >> letter;
if(letter == "d" || letter == "D") {
std::cout << "How much would you like to deposit?: ";
double amountDeposit{};
std::cin >> amountDeposit;
Luigis.deposit(amountDeposit);
}
else if(letter == "w" || letter == "W") {
std::cout << "How much would you like to withdraw?: ";
double amountWithdraw;
std::cin >> amountWithdraw;
Luigis.withdraw(amountWithdraw);
}
else if(letter == "q" || letter == "Q") {
std::cout << "Goodbye!" << std::endl;
}
else
std::cout << "Invalid selection, please try again with: D for Deposit, W for Withdraw, Q for Exist" << std::endl;
} while (letter != "q" && letter != "Q");
return 0;
}
在Account.cpp 我有:
#include "Account.h"
#include <string>
#include <iostream>
//IMPLEMENTATION or DEFINITION
bool Account::deposit(double amount) {
//money you're doing to deposit
balance = balance + amount;
}
bool Account::withdraw(double amount) {
//if you can withdraw
if(balance-amount >= 0) {
balance = balance - amount;
return true;
} else {
std::cout << "You cannot withdraw the specified amount - balance is too low and it would result in " << balance - amount << " funds!" << std::endl;
return false;
}
}
void Account::set_name(std::string name) {
this->name = name;
}
std::string Account::get_name(){
return name;
}
void Account::set_balance(double balance) {
this->balance = balance;
}
double Account::get_balance() {
return balance;
}
在Account.h 我有:
#ifndef _ACCOUNT_H_
#define _ACCOUNT_H_
#include <string>
//SPECIFICATION or DECLARATION
class Account
{
private:
//attributes
std::string name;
double balance;
public:
//methods
bool deposit(double amount);
bool withdraw(double amount);
void set_name(std::string name);
std::string get_name();
void set_balance(double balance);
double get_balance();
};
#endif // _ACCOUNT_H_
我的问题是:既然我“知道”如何使用函数,我该如何简化main.cpp 中的if-else 语句?我的朋友说我应该可以使用函数并将事情变得更抽象,以避免编写所有if和else语句。
基本上,我将 OOP 与过程编程混合在一起,这违背了目的。
【问题讨论】:
-
(1) 除了缩进之外,我认为您的 if-else 语句没有任何实际问题。 (2) 提取每个 if-else 的主体可能会使其更具可读性,并且是微不足道的。 (3) 如果您想完全避免 if-and else,您将需要一个映射,但这通常会导致 less 可读代码。 tldr;我认为您的代码很好(缩进除外)
-
您有太多与您的问题完全无关的代码。请创建一个minimal reproducible example(强调“最小”)
-
如果字母始终是单个字符,您可能可以使用
char,而不是std::string并使用switch 语句 -
折叠箱子?
letter = toupper(letter); ... if (letter == 'Q')或switch (toupper(letter)) case 'Q': ...?
标签: c++ function class oop c++17