【发布时间】:2024-01-10 07:00:01
【问题描述】:
我有以下程序,先存储一些城市之间的直飞航班,然后使用DFS查询两个城市是否有中转航班。
程序在查询步骤中不断崩溃,所以我尝试使用打印语句找到问题,但奇怪的是,当执行搜索的函数中有打印语句时,程序并没有崩溃。代码有什么问题?
(我使用的是 Code:Blocks 13.12)
#include <stdio.h>
#include <stdlib.h>
#define MIN_SIZE 2
#define MAX_SIZE 10000
#define MIN_CON 1
#define FALSE 0
#define TRUE 1
//global variables
struct city** checked;
int* num_connect;
int n, found=0;
//Define a struct
struct city
{
//Declaration of struct members
int name;
struct city **connected; //array of all cities with direct flights to
};
int readCity(int n)
{
//Declaration of a variable
int city;
do
{
scanf("%d", &city);
}while(city<MIN_CON && city>n);
return city;
}
void addFlight(struct city *list, int orig, int dest)
{
//decl
int i=0;
int j=0;
//check if orig is in list
while(num_connect[i]!=0 && list[i].name!=orig)
{
i++;
}
//if it isnt add it
if (num_connect[i]==0)
{
list[i].name =orig;
list[i].connected = malloc((num_connect[i]+1)*sizeof(struct city*));
}
else
{
//reallocate memory to store additional flight connection
list[i].connected = realloc(list[i].connected, (num_connect[i]+1)*sizeof(struct city*));
}
num_connect[i]++;
//check if dest is in list
while(num_connect[j]!=0 && list[j].name!=dest)
{
j++;
}
//if it isnt add it
if (num_connect[j]==0)
{
list[j].name =dest;
list[j].connected = malloc((num_connect[j]+1)*sizeof(struct city*));
}
else
{
//reallocate memory to store additional flight connection
list[j].connected = realloc(list[j].connected, (num_connect[j]+1)*sizeof(struct city*));
}
num_connect[j]++;
//add b to a's connected and add b to a's connected
list[j].connected[num_connect[j]-1]=&list[i];
list[i].connected[num_connect[i]-1]=&list[j];
printf("JUST CONNECTED %d WITH %d\n", list[i].name, list[j].name);
}
int inChecked(struct city* c)
{
int i;
while(checked[i]!=c && i<n)
{
i++;
}
if (i==n)
{
return FALSE;
}
else
{
return TRUE;
}
}
void search_connection(struct city *list, int orig, int dest)
{
//decl
int i=0, k=0, j=0, p=0;
printf(" "); // <------------------------------------------------------------
//Find origin city in list
while(i<n && list[i].name!=orig)
{
i++;
}
//add to checked
while(checked[k]!=NULL)
{
k++;
}
checked[k]=&list[i];
//Check for 'dest' city in connected of origin
while(j<num_connect[i] && list[i].connected[j]->name!=dest)
{
j++;
}
//If-statement to determine if dest was found
if (j!=num_connect[i])
{
//Set 'found' to 1
found=1;
return;
}
else
{
//While not all connected have been checked and not found
while(p<num_connect[i] && found==0)
{
if (!inChecked(list[i].connected[p]))
{
//call method on it
search_connection(list, list[i].connected[p]->name, dest);
}
p++;
}
}
}
int main()
{
//Declaration of variables
int i, m;
int city_a, city_b, q_result;
//Read input
do
{
//printf("Enter number of cities:\n");
scanf("%d", &n);
}while(n<MIN_SIZE || n>MAX_SIZE);
//Declare an array of cities
struct city* cities;
//Allocate memory for array of 'n' cities
cities = malloc(n*sizeof(struct city)); // <---------------- FREE later!!!
//Allocate memory for array of 'n' pointers to cities
checked = calloc(n,sizeof(struct city*)); // <---------- FREE later!!!
//Allocate memory for array of 'n' integers
num_connect = calloc(n,sizeof(int)); // <------------ FREE later!!!
//Read input
do
{
//printf("Enter number of connections:\n");
scanf("%d", &m);
}while(n<MIN_SIZE || n>MAX_SIZE);
//For-loop to read connected cities
for (i=0; i<m; i++)
{
//Read two cities
city_a = readCity(n);
city_b = readCity(n);
//add flight connecting the two cities
addFlight(cities, city_a, city_b);
}
//Read connection to query
city_a = readCity(n);
city_b = readCity(n);
//Search for connection between the two cities by in-direct flight
search_connection(cities, city_a, city_b);
//Print results
if (found==1)
{
printf("Yes");
}
else
{
printf("No");
}
//Free up memory
// TO DO. . .
return 0;
}
【问题讨论】:
-
不查看代码,崩溃是未定义行为的结果,SEGMENTATION FAULT 是对内存的非法访问,因此当您访问不应该访问的内存时,它可能会发生也可能不会发生。未定义的行为就是这样,未定义。如果你想调试程序使用调试器,虽然可能会发生同样的事情,因为调试器也会导致分段错误消失,这些被称为 HeisenBUGS 因为海森堡的不确定性原理。
-
打印语句的位置是否有助于隔离代码非法访问内存的位置?
-
我想我找到了导致问题的代码行,但我不知道为什么?
if (j!=num_connect[i])我用 100(随机值)替换了num_connect[i],程序在没有打印语句的情况下运行.. -
根据您最后的评论,当您在
(j!=num_connect[i])时,'i' 是什么?我敢打赌你正在访问 num_connect 数组的范围之外。 -
对于我输入 6 个城市(以及 6 个 num_connect 项)的测试用例,我采用的值是:5、3、1,因此它们始终在 0-5 之间,这是 6 时的索引使用城市..
标签: c struct crash printf depth-first-search