【问题标题】:Recyleview inside fragment is empty when comming back from other fragment从另一个片段返回时,片段内的 Recyclerview 为空
【发布时间】:2019-05-25 14:07:48
【问题描述】:

我正在开发一个带有片段的应用程序(一个只有活动但有多个片段的应用程序)。

我遇到的问题是,当我转到一个片段并返回(系统后退按钮)到初始片段时,它的 RecycleView 现在是空的。

关于这个的奇怪之处在于,当我从不同的片段(也使用 RecycleView)到同一个片段时,问题不会发生。

下面我发布了两个片段,分别是 RecycleView 和 MainActivity。

有人知道为什么会这样吗?

确实有问题的片段:

public class FavEventFragment extends Fragment implements RecyclerView.OnItemTouchListener {

    private static final String PAGE_NAME = "Saved Events";

    private TextView noEventsTextView;

    FavEventAdapter adapter;
    RecyclerView recyclerView;
    private EventViewModel eventViewModel;
    private List<Event> favEvents;

    @Nullable
    @Override
    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
        View rootView = inflater.inflate(R.layout.fragment_favevent, container, false);

        MainActivity.changeLayoutWeight(true);
        MainActivity.setPageName(PAGE_NAME);

        favEvents = new ArrayList<>();

        recyclerView = rootView.findViewById(R.id.favEvent_list);
        noEventsTextView = rootView.findViewById(R.id.noFavEventsText);

        recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));

        eventViewModel = ViewModelProviders.of(this).get(EventViewModel.class);
        eventViewModel.getFavEvents().observe(this, new Observer<List<Event>>() {

            @Override
            public void onChanged(@Nullable List<Event> games) {
                favEvents = games;
                updateUI();
            }
        });

        setRecycleViewGestures();

        return rootView;
    }

    private void updateUI() {
        if (adapter == null) {
            adapter = new FavEventAdapter(favEvents);
            recyclerView.setAdapter(adapter);
        } else {
            adapter.swapList(favEvents);
        }
    }

    void setRecycleViewGestures() {

        recyclerView.addOnItemTouchListener(new RecycleGestures(getActivity(), recyclerView, new RecycleGestures.ClickListener() {
            @Override
            public void onClick(View view, int position) {

                EventDetailsFragment fragment = new EventDetailsFragment();

                FragmentManager fragmentManager = getFragmentManager();
                FragmentTransaction transaction = fragmentManager.beginTransaction();

                transaction.setCustomAnimations(R.anim.enter_from_top, R.anim.exit_to_top, R.anim.enter_from_top, R.anim.exit_to_top);

                fragment.setObject(favEvents.get(position));
                transaction.addToBackStack(null);
                transaction.replace(R.id.fragment_container, fragment, "FRAGMENT").commit();
            }

            @Override
            public void onLongClick(View view, int position) { }
        }));

        ItemTouchHelper.SimpleCallback simpleItemTouchCallback =
                new ItemTouchHelper.SimpleCallback(0, ItemTouchHelper.LEFT | ItemTouchHelper.RIGHT) {
                    @Override
                    public boolean onMove(RecyclerView recyclerView, RecyclerView.ViewHolder viewHolder, RecyclerView.ViewHolder target) {
                        return false;
                    }

                    @Override
                    public void onSwiped(RecyclerView.ViewHolder viewHolder, int swipeDir) {
                        int position = (viewHolder.getAdapterPosition());
                        eventViewModel.delete(favEvents.get(position));
                        favEvents.remove(position);
                        adapter.notifyItemRemoved(position);
                    }
                };

        ItemTouchHelper itemTouchHelper = new ItemTouchHelper(simpleItemTouchCallback);
        itemTouchHelper.attachToRecyclerView(recyclerView);
        recyclerView.addOnItemTouchListener(this);
    }

    @Override
    public boolean onInterceptTouchEvent(RecyclerView rv, MotionEvent e) { return false; }

    @Override
    public void onTouchEvent(RecyclerView rv, MotionEvent e) { }

    @Override
    public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept) { }
}```


The fragment that **doesn't** have the problem:


public class EventsFragment extends Fragment {

    private static final String PAGE_NAME = "Upcoming Events";

    private RecyclerView eventList;
    private EventAdapter adapter;

    private AirsoftRepository airsoftRepository;

    @Nullable
    @Override
    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {

        View rootView = inflater.inflate(R.layout.fragment_shop, container, false);

        MainActivity.changeLayoutWeight(true);
        MainActivity.setPageName(PAGE_NAME);

        airsoftRepository = AirsoftRepository.getInstance();

        eventList = rootView.findViewById(R.id.item_list);

        eventList.setLayoutManager(new LinearLayoutManager(getActivity()));

        getEvents();

        return rootView;
    }

    private void getEvents() {
        airsoftRepository.getEvents(new OnGetEventsCallback() {
            @Override
            public void onSuccess(List<Event> events) {
                adapter = new EventAdapter(events, onClickCallback);
                eventList.setAdapter(adapter);
            }

            @Override
            public void onError() {
                Toast.makeText(getActivity(), "Please check your internet connection.", Toast.LENGTH_SHORT).show();
            }
        });
    }

    OnEventsClickCallback onClickCallback = new OnEventsClickCallback() {
        @Override
        public void onClick(Event event) {

            EventDetailsFragment fragment = new EventDetailsFragment();

            FragmentManager fragmentManager = getFragmentManager();
            FragmentTransaction transaction = fragmentManager.beginTransaction();

            transaction.setCustomAnimations(R.anim.enter_from_top, R.anim.exit_to_top, R.anim.enter_from_top, R.anim.exit_to_top);

            fragment.setObject(event);
            transaction.addToBackStack(null);
            transaction.replace(R.id.fragment_container, fragment, "FRAGMENT").commit();
        }
    };
}

【问题讨论】:

    标签: android android-fragments android-recyclerview fragment-backstack


    【解决方案1】:

    替换片段会导致其视图层次结构被破坏。目前,您在重新输入片段时正在泄漏适配器。

    将覆盖添加到您的片段以清理当前适配器并查看引用:

    @Override
    public void onDestroyView(){
        recyclerView.setAdapter(null);
        adapter = null;
        recyclerView = null;
    }
    

    理想情况下,您的适配器应该在onCreate 期间创建,并且无论视图状态如何都可以使用。

    【讨论】:

    • 我认为这解决了我的问题。非常感谢!
    • 它起作用了,但我仍然不太明白为什么,考虑到另一个片段上没有问题。你能解释一下吗?
    • @Cyborgium 这一切都是为了检查if(adapter == null)。在第一种情况下,您从以前的视图中泄漏了适配器,并且您没有将其添加到新的recyclerView
    • 请不要忘记考虑pmd.github.io/latest/… 以保持您的代码干净。
    • 非常感谢。 3 小时后它的工作我得到了这个。
    【解决方案2】:
     //Instead of replace use add() method
    
     transaction.add(R.id.fragment_container, fragment, "FRAGMENT").commit();
    

    【讨论】:

    • 感谢您的回复,但如果我使用 add 而不是 replace 它会弄乱一些动画,因为片段没有 onResume
    猜你喜欢
    • 1970-01-01
    • 1970-01-01
    • 2021-06-21
    • 2021-12-26
    • 1970-01-01
    • 1970-01-01
    • 2015-08-26
    • 2021-12-25
    • 1970-01-01
    相关资源
    最近更新 更多