【问题标题】:Laravel 5.2 understanding "fat model, skinny controller"Laravel 5.2 理解“胖模型,瘦控制器”
【发布时间】:2016-01-12 11:15:01
【问题描述】:

我正在尝试了解如何在 Laravel 5.2 中使用“胖模型,瘦控制器”。基本上,我主要了解原因和内容,但不了解如何。我在 Google 上搜索了一段时间,发现有几页描述了为什么(以及一些描述为什么不这样做)和什么,但没有任何页面可以让您轻松理解如何使用瘦控制器创建胖模型。

我创建了一个非常基本的待办事项列表,没有登录或验证,只有最基本的待办事项功能。这个应用程序基本上使用“瘦模型,胖控制器”,我想重写应用程序,以便它使用“胖模型,瘦控制器”。

我在 MySQL 数据库中有三个表:

  • 用户
    • id int(10)
    • uname varchar(255)
    • 电子邮件 varchar(255)
    • 密码 varchar(60)
  • 项目
    • id int(10)
    • pname varchar(255)
  • 注释
    • id int(10)
    • user_id int(10)
    • project_id int(10)
    • 内容文本
    • time_created 时间戳
    • time_deadline 时间戳
    • 完成 tinyint(1)
    • 删除 tinyint(1)

当我为表创建迁移时,我使用 $table->foreign('user_id')->references('id')->on('users');$table->foreign('project_id')->references('id')->on('projects'); 来迁移 notes 表。由于某种原因它不起作用,所以在数据库中notes.user_idnotes.project_id 不是users.idprojects.id 的外键,这是从一开始的想法。我猜这对我下面的问题并不重要,但如果确实如此,请有人告诉我,以便我尝试解决这个问题。

我有以下模型(已删除文档块)

app\User.php:

<?php

namespace App;

use Illuminate\Foundation\Auth\User as Authenticatable;

class User extends Authenticatable
{
    protected $fillable = [
        'name', 'email', 'password',
    ];

    protected $hidden = [
        'password', 'remember_token',
    ];

    public function notes()
    {
        return $this->hasMany(Note::class);
    }
}

app\Project.php:

<?php
namespace App;

use Illuminate\Database\Eloquent\Model;

class Project extends Model
{
    public function notes()
    {
        return $this->hasMany(Note::class);
    }
}

app\Note.php:

<?php
namespace App;

use Illuminate\Database\Eloquent\Model;

class Note extends Model
{
    public function user()
    {
        return $this->belongsTo(User::class);
    }

    public function project()
    {
        return $this->belongsTo(Project::class);
    }
}

我有以下控制器(删除了文档块)

app\Http\Controllers\UserController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\User;
use Response;

class UserController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $users = User::orderBy('uname', 'asc')->get()->toArray();
            $response = [];

            foreach ($users as $user) {
                $this_row = array(
                    'id' => $user['id'],
                    'name' => $user['uname'],
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }
}

app\Http\Controllers\ProjectController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Project;
use Response;

class ProjectController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $projects = Project::orderBy('pname', 'asc')->get()->toArray();
            $response = [];

            foreach ($projects as $project) {
                $this_row = array(
                    'id' => $project['id'],
                    'name' => $project['pname'],
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }
}

app\Http\Controllers\NoteController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Note;
use App\User;
use App\Project;
use Input;
use Response;
use Redirect;

class NoteController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $notes = Note::where('removed', 0)
                ->orderBy('time_created', 'asc')->get()->toArray();
            $response = [];

            foreach ($notes as $note) {
                $user = User::find($note['user_id']); // Username for note
                $project = Project::find($note['project_id']); // Project name

                $this_row = array(
                    'id' => $note['id'],
                    'user' => $user['uname'],
                    'project' => $project['pname'],
                    'content' => $note['content'],
                    'completed' => $note['completed'],
                    'created' => $note['time_created'],
                    'deadline' => $note['time_deadline']
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }

    public function destroy(Request $request)
    {
        try {
            $statusCode = 200;

            $note = Note::find($request->id);
            $note->removed = 1;
            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }        
    }

    public function edit($request) 
    {
        try {
            $statusCode = 200;

            $note = Note::find($request);

            $response = array(
                'id' => $note['id'],
                'content' => $note['content'],
                'completed' => $note['completed'],
                'deadline' => $note['time_deadline']
            );
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }

    public function update(Request $request)
    {
        try {
            $statusCode = 200;

            $note = Note::find($request->id);

            $note->content = $request->content;
            $note->time_deadline = $request->deadline;

            if ($request->completed == "true") {
                $note->completed = 1;
            } else {
                $note->completed = 0;
            }

            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }
    }

    public function store(Request $request)
    {
        try {
            $statusCode = 200;

            $note = new Note;

            $note->user_id = $request->user;
            $note->project_id = $request->project;
            $note->content = $request->content;
            $note->time_deadline = $request->deadline;

            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }    
    }
}

最后,这是我的 app/Http/routes.php (cmets 去掉)

<?php

Route::get('/', function () {
    return view('index');
});

Route::get('/notes', 'NoteController@index');
Route::get('/notes/{id}', 'NoteController@edit');
Route::delete('/notes', 'NoteController@destroy');
Route::put('/notes', 'NoteController@store');
Route::post('/notes', 'NoteController@update');

Route::get('/projects', 'ProjectController@index');
Route::get('/users', 'UserController@index');

Route::group(['middleware' => ['web']], function () {
    //
});

完整代码可以在我的 GitHub here 找到。

我正在使用 Angular 接收控制器发送的 JSON。这适用于我当前的页面,但如您所见,我的控制器有很多逻辑,我想将其转移到模型中。我不明白我是怎么做到的,所以这是我的问题:

  • 我应该创建哪些其他文件?
  • 它们应该位于哪里?
  • 除了控制器中当前的逻辑之外,我还需要这些文件中的哪些内容?
  • 我应该如何重写控制器来处理来自模型的数据?

【问题讨论】:

  • 不要将逻辑移到模型中,将其移到存储库和转换器中。控制器调用 Repositories,然后 Repositories 调用 Models,如果需要,Repositories 还将调用 Transformers 来转换所有数据,然后再将其返回给 Controller

标签: php laravel model controller laravel-5.2


【解决方案1】:

您的瘦控制器可能是以下内容,它会执行与您所做的相同的操作:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Project;

class ProjectController extends Controller
{
    public function index()
    {
        $projects = Project::orderBy('pname', 'asc')->get(['id', 'name']);
        return response()->make($projects);
    }
}

但正如 Fabio 所说,如果您想更进一步,请查看存储库。这是一篇好文章:https://bosnadev.com/2015/03/07/using-repository-pattern-in-laravel-5/

在大多数情况下,我将存储库包装到服务中以创建业务逻辑。 Controllers 只处理路由,models 只包含关系或修改器和访问器。但它可能因开发方法而异。

另外,不要在 foreach 循环中进行 db 查询,利用 Eloquent 的优势,例如:

$notes = Note::where('removed', 0)
            ->with(['user', 'project'])
            ->orderBy('time_created', 'asc')->get();

你可以像这样访问:

foreach($notes as $note)
{
    echo $note->user->uname;
}

【讨论】:

    猜你喜欢
    • 1970-01-01
    • 2012-01-25
    • 2015-04-24
    • 1970-01-01
    • 2010-10-02
    • 2011-03-07
    • 2012-02-02
    • 1970-01-01
    • 2014-04-24
    相关资源
    最近更新 更多