C++ 构造函数错误。无法初始化字符串数组

Question

为什么不能在我的构造函数中初始化我的字符串数组？我收到以下错误： 内部编译器错误：分段错误|

在构造函数的这两行： 西装= {“俱乐部”，“钻石”，“红心”，“黑桃”}； 面额 = {"Ace","2","3","4","5","6","7","8","9","10","Jack","Queen" "国王"};

class Card
    {
      public:
        Card(int n);
        Card(string d, string s);
        int getNumber();
        string getDenomination();
        string getSuit();
        void setNumber(int n);
        void setDenomination(string d);
        void setSuit(string s);
        void printMe();
        void compareMe(Card c);

      private:
        int number;
        string denomiation;
        string suit;
        string suits [4];
        string denominations [13];
    };


    Card::Card(int n)
    {
        suits = {"Clubs", "Diamonds", "Hearts", "Spades"};
        denominations = {"Ace","2","3","4","5","6","7","8","9","10","Jack","Queen","King"};

        int denIndex, suitIndex;

        denIndex = 51 % 13;
        suitIndex = 51 / 13;

        number = n;
        denomiation = denominations[denIndex];
        suit = suits[suitIndex];

    }

Answer 1

根据您发布的代码，我猜suits 和denominations 成员应该是静态数据成员，也就是说，对于每个Card 实例，它们将始终具有相同的数据。

所以我建议你将它们设为静态并在你的 cpp 文件的文件范围内初始化它们（在你的类声明之外）：

声明：

class Card
{
  public:
    Card(int n);
    Card(string d, string s);
    int getNumber();
    string getDenomination();
    string getSuit();
    void setNumber(int n);
    void setDenomination(string d);
    void setSuit(string s);
    void printMe();
    void compareMe(Card c);

  private:
    int number;
    string denomiation;
    string suit;
    static const string suits [4];                 // static const
    static const string denominations [13];        // static const
};

定义：

const string Card::suits[4] = {"Clubs", "Diamonds", "Hearts", "Spades"};
const string Card::denominations[13] = {"Ace","2","3","4","5","6","7","8","9","10","Jack","Queen","King"};

编辑： 正如 Robert S. Barnes 所说，将它们设为 static const 会更好。

希望对您有所帮助。

Answer 2

你只能在构造时使用字面量数组初始化，而不是赋值。

int good[3] = { 1, 2, 3 }; // OK
int bad[3];
bad = { 1, 2, 3 }; // not so good

您必须手动复制数组（或使用vector 或boost::array 之类的容器。

Answer 3

如果您遇到 ICE（内部编译器错误），那么您确实应该将代码报告给编写您的编译器的人。编译器应该打印出警告和错误，而不是分段错误。

Answer 4

使用std::vector 或boost::array，您的代码的简化示例如下

#include <boost/assign/list_of.hpp>

#include <boost/array.hpp>

#include <iostream>
#include <string>

class Card
{
public:
    explicit Card( unsigned n ) :
        _number( n ),
        _suits( boost::assign::list_of( "Clubs" )( "Diamonds" )( "Hearts" )( "Spades" ) ),
        _denominations( boost::assign::list_of( "Ace" )( "2" )( "3" )( "4" )( "5" )( "6" )( "7" )( "8" )( "9" )( "10" )( "Jack" )( "Queen" )( "King" ) )
    {

    }

private:
    unsigned _number;
    boost::array<std::string, 4> _suits;
    boost::array<std::string, 13> _denominations;
};

int
main()
{
    Card foo( 5 );

    return 0;
}