【问题标题】:percentage calculation in my function is not working我的函数中的百分比计算不起作用
【发布时间】:2021-03-27 22:29:54
【问题描述】:

所以我要做的是取一个数字向量,找出每个元素出现的次数,然后计算其在向量中出现次数的百分比。

它在一个只有一个数字的几个元素的向量上工作得非常好,但在一个不同元素的向量(准确地说是 2 个)出现多次的向量上完全不行。

这是一个详细的输出:

count = 6
pushed back 21
total = 6
percent = 6 / 6* 100
pushed back 100
Number:
21 
Percent Chance
100 

count = 5
pushed back 42
count = 5
pushed back 21
total = 5
total = 10
percent = 5 / 10* 100
pushed back 0
percent = 5 / 10* 100
pushed back 0
Number:
42 
Percent Chance
0 // SHOULD BE 50
Number:
21 
Percent Chance
0 // SHOULD BE 50

这里是代码:(这个函数的输出是用不同的 x 向量运行两次)

 std::vector <std::string>  findpercentages(std::vector <std::string> x)
 {
 int count{};                          //for amount of times element occurs
 std::vector <std::string> tempvec{};  //to hold the element/s
 std::vector <int> counts{};           //to hold count for each element in tempvec
 std::vector <std::string> finalvec{}; //elements and counts of elements
 for (size_t i = 0; i < x.size(); i++)
 {
    //look for x[element] in tempvec, if not in tempvec, count occurances in x and add element to 
    // tempvec, add count to counts 
    std::vector <std::string>::iterator point { std::find(tempvec.begin(), tempvec.end(), x[i]) };
    if (point == tempvec.end())
    {
        count = std::count(x.begin(), x.end(), x[i]);
        std::cout << "count = " << count << '\n';
        counts.push_back(count);
        std::cout << "pushed back " << x[i] << '\n';
        tempvec.push_back(x[i]);

    }
}
int total{};
for (size_t n = 0; n < counts.size(); n++)
{
    total += counts[n]; //total for percentage calculation
    std::cout << "total = " << total << '\n';
}
for (size_t y = 0; y < tempvec.size(); y++)
{
    finalvec.push_back(tempvec[y]);
    //percent calculation. used unsigned_int64 because got arithmatic overflow warning if i just use 
    // int
    unsigned __int64 percentage = static_cast <unsigned __int64> (round((counts[y] / total) * 100));
    std::cout << "percent = " << counts[y] << " / " << total << "* 100" << '\n';
    finalvec.push_back(std::to_string(percentage));
    std::cout << "pushed back " << percentage << '\n';
}
return finalvec;
}

【问题讨论】:

    标签: c++ math vector percentage


    【解决方案1】:
    unsigned __int64 percentage = static_cast <unsigned __int64> (round((counts[y] / total) * 100));
    

    应该是这样的

    double percentage = round((100.0 * counts[y]) / total);
    

    您的问题是,当您将一个整数除以另一个整数时,您总是得到一个整数。所以(counts[y] / total) 永远是01

    所以最简单的解决方案是在计算中引入一个double100.0。这确保您得到浮点除法而不是整数除法。

    【讨论】:

    • 我之前尝试过,但不是按照那个确切的顺序。我会按这个顺序做并回复结果:)
    • 成功了。我总是很高兴我取得了进步并编写了更好看的代码,直到发生这样的事情,我不明白我为什么不这样做。
    猜你喜欢
    • 2013-10-27
    • 1970-01-01
    • 2014-10-15
    • 1970-01-01
    • 2013-10-28
    • 2018-02-17
    • 2023-03-21
    • 2022-11-21
    • 2021-10-08
    相关资源
    最近更新 更多