【发布时间】:2015-10-11 18:53:19
【问题描述】:
我有一个正在处理的项目,我刚刚切换到 PHPStorm,因为它开始变大,我需要一些重构工具。我注意到,由于变量没有被声明为类型(就像它们在 Java 中一样),PHPStorm 有时不知道在哪里寻找对变量名的方法调用。这是我的代码。
<?php
require_once "autoloader.php";
class User {
private $userID;
private $email;
private $encryptedPassword;
private $userDBWriter;
private $company;
private $companyInfoChangeRequest;
private $admin;
private $accountIsActive;
private $dealTracker;
private $changeRequestPending;
function __construct($email, $encryptedPassword) {
$this->email = $email;
$this->encryptedPassword = $encryptedPassword;
$this->userDBWriter = new UserDBWriter();
$this->admin = false;
$this->dealTracker = new DealTracker($this);
}
public function addUserToDB() {
$this->userDBWriter->addUserToDB($this);
}
public function setUserAsAdmin($adminStatus) {
$this->admin = (bool) $adminStatus;
}
public function userAccountActiveStatus($accountStatus) {
$this->accountIsActive = (bool) $accountStatus;
}
public function setUserID($userID) {
$this->userID = $userID;
}
public function getUserID() {
return $this->userID;
}
public function getEmail() {
return $this->email;
}
public function isAdmin() {
return $this->admin;
}
public function isAccountActive() {
return $this->accountIsActive;
}
public function getEncryptedPassword() {
return $this->encryptedPassword;
}
public function toArray() {
$userArray = array(
"id"=>$this->userID,
"email"=>$this->email,
"company_name"=>$this->getCompanyName(),
"business_type"=>$this->getBusinessType(),
"company_phone"=>$this->getCompanyPhone(),
"company_street"=>$this->getCompanyStreet(),
"company_city"=>$this->getCompanyCity(),
"company_zip"=>$this->getCompanyZip(),
"monday_hours"=>$this->getMondayHours(),
"tuesday_hours"=>$this->getTuesdayHours(),
"wednesday_hours"=>$this->getWednesdayHours(),
"thursday_hours"=>$this->getThursdayHours(),
"friday_hours"=>$this->getFridayHours(),
"saturday_hours"=>$this->getSaturdayHours(),
"sunday_hours"=>$this->getSundayHours(),
"store_image_path"=>$this->getStoreImagePath(),
"shop_description"=>$this->getShopDescription(),
"deals"=>$this->dealTracker->dealsToArray()
);
return $userArray;
}
public function addCompany(Company $company) {
$this->company = $company;
}
public function getCompanyName() {
return $this->company->getCompanyName();
}
public function getBusinessType() {
return $this->company->getBusinessType();
}
public function getCompanyPhone() {
return $this->company->getCompanyPhone();
}
public function getCompanyStreet() {
return $this->company->getCompanyStreet();
}
public function getCompanyCity() {
return $this->company->getCompanyCity();
}
public function getCompanyState() {
return $this->company->getCompanyState();
}
public function getCompanyZip() {
return $this->company->getCompanyZip();
}
public function getMondayHours() {
return $this->company->getMondayHours();
}
public function getTuesdayHours() {
return $this->company->getTuesdayHours();
}
public function getWednesdayHours() {
return $this->company->getWednesdayHours();
}
public function getThursdayHours() {
return $this->company->getThursdayHours();
}
public function getFridayHours() {
return $this->company->getFridayHours();
}
public function getSaturdayHours() {
return $this->company->getSaturdayHours();
}
public function getSundayHours() {
return $this->company->getSundayHours();
}
public function getStoreImagePath() {
return $this->company->getStoreImagePath();
}
public function getShopDescription() {
return $this->company->getShopDescription();
}
public function isBusinessVerified() {
return $this->company->getVerifiedBusiness();
}
public function setCompanyInfoChangeRequest($company) {
$this->companyInfoChangeRequest = $company;
}
public function submitCompanyInfoChangeRequest($company) {
$this->companyInfoChangeRequest = new CompanyInfoChangeRequest($this, $company);
$this->companyInfoChangeRequest->submitCompanyInfoChangeRequest();
}
public function cancelCompanyInfoChangeRequest() {
if ($this->changeRequestPending) {
$this->companyInfoChangeRequest->cancelRequest();
}
}
public function isCompanyChangeRequestPending() {
return $this->changeRequestPending;
}
public function approveCompanyInfoChangeRequest($company) {
$this->companyInfoChangeRequest->approveCompanyInfoChangeRequest($this);
}
public function setChangeRequestPending($isPending) {
$this->changeRequestPending = (bool) $isPending;
}
public function getChangeRequestCompanyName() {
return $this->companyInfoChangeRequest->getCompanyName();
}
public function getChangeRequestBusinessType() {
return $this->companyInfoChangeRequest->getBusinessType();
}
public function getChangeRequestCompanyPhone() {
return $this->companyInfoChangeRequest->getCompanyPhone();
}
public function getChangeRequestCompanyStreet() {
return $this->companyInfoChangeRequest->getCompanyStreet();
}
public function getChangeRequestCompanyCity() {
return $this->companyInfoChangeRequest->getCompanyCity();
}
public function getChangeRequestCompanyState() {
return $this->companyInfoChangeRequest->getCompanyState();
}
public function getChangeRequestCompanyZip() {
return $this->companyInfoChangeRequest->getCompanyZip();
}
public function getChangeRequestMondayHours() {
return $this->companyInfoChangeRequest->getMondayHours();
}
public function getChangeRequestTuesdayHours() {
return $this->companyInfoChangeRequest->getTuesdayHours();
}
public function getChangeRequestWednesdayHours() {
return $this->companyInfoChangeRequest->getWednesdayHours();
}
public function getChangeRequestThursdayHours() {
return $this->companyInfoChangeRequest->getThursdayHours();
}
public function getChangeRequestFridayHours() {
return $this->companyInfoChangeRequest->getFridayHours();
}
public function getChangeRequestSaturdayHours() {
return $this->companyInfoChangeRequest->getSaturdayHours();
}
public function getChangeRequestSundayHours() {
return $this->companyInfoChangeRequest->getSundayHours();
}
public function getChangeRequestStoreImagePath() {
return $this->companyInfoChangeRequest->getStoreImagePath();
}
public function getChangeRequestShopDescription() {
return $this->companyInfoChangeRequest->getShopDescription();
}
}
带有警告"Method not found in class..." 的一些方法是getCompanyName() getBusinessType() getCompanyPhone() 和任何其他调用$this->company 或$this->companyInfoChangeRequest 上的方法的方法。
我知道为什么会这样。这是因为 PHPStorm 不知道变量是什么实例。我注意到这里Method not found in class 他们使用 PHPDoc 注释来输入提示变量类型,以便 PHPStorm 知道在哪里查找。 我想要一个“不发表评论”的解决方案,因为如果我以后遇到评论,我可能会删除它。对不起,上课时间太长了。我正在将项目导入 PHPStorm,以便开始进行一些重构。谢谢。
【问题讨论】:
-
" 我想要一个“不发表评论”的解决方案,因为如果我以后遇到评论我可能会删除它。” i> 为什么要“删除”? PHPDoc cmets 有什么问题?你见过任何现代框架/库,它们是如何使用 PHPDoc 的吗?
-
为什么要删除 cmets?因为他们把代码弄乱了。您可以为文档提出论据,如果做得对,那就太好了。如果要删除评论,那么重构工具就会中断。我宁愿依赖代码而不是评论。
-
显然,选择权完全在您手中(在您想知道这段代码的作用以及这些字段/方法的作用之后,想想其他将使用该代码的用户/开发人员)。我会把它留在这里,以防你会感兴趣/还没有看到它。 phptherightway.com
-
谢谢,我一定会看看的。
标签: php phpstorm type-hinting