堆栈被损坏并且不会返回

Question

我创建了自己的堆栈和一个重载函数。但是，当我调用该函数时，返回堆栈已损坏，我无法弄清楚原因：/我是 C++ 新手，很想学习！这是我的代码

主要

int main(){
string line;
SStack s1(1000);
SStack s2(1000);
int cap = s1.getCapacity();
cout << "Is the stack empty? " << s1.IsEmpty() << "\n";
cout << "The capacity of the stack is: " << cap << "\n";
ifstream myfile("all.last.txt");
cout << "s1 begin pushing: \n";
for (int i = 0; i <= 500; i++){
    getline(myfile, line);
    cout << "Pushing " << line << "\n";
    s1.push(line);
}
cout << "s2 begin pushing: \n";
for (int i = 0; i <= 50; i++){
    getline(myfile, line);
    cout << "Pushing " << line << "\n";
    s2.push(line);
}
myfile.close();
cout << "Is the stack empty? " << s1.IsEmpty() << "\n";
string top = s1.top();
cout << "The top object on the stack is: " << top << "\n";
cout << "The size of the stack is: " << s1.size() << "\n";
cout << "Popping: " << s1.pop() << "\n";
cout << "Size after pop is: " << s1.size() << "\n";
s1 = s1 + s2;
cout << s1.top();

}

不返回的SStack函数

    SStack::SStack(const SStack& s) : used(-1), Capacity(0), DynamicStack(0){
    *this = s;
}

SStack SStack::operator=(const SStack& s){
    if (this != &s){
        int cap = s.getCapacity();
        DynamicStack = new string[cap];
        Capacity = cap;
        used = -1;
        for (int count = 0; count < s.size(); count++){
            DynamicStack[count] = s.DynamicStack[count];
            used++;
        }
        }
        return *this;
}

SStack SStack::operator +(const SStack& s2){
int size1 = used + 1;
int size2 = s2.size();
SStack result = *this;
if (size1 + size2 <= Capacity){
    for (int count = 0; count < s2.size(); count++){
        result.push(s2.DynamicStack[count]);
    }
    return result;
}
else{
    cout << "Error stack is not big enough";
    return result;
}

Answer 1

您在 2 个位置分配堆栈实例，但我没有看到 operator= 定义。 我建议你在你的 SStack 类中添加一个 operator=() 并将你的复制构造函数委托给这个 operator=()。确保您的 operator=() 检查它是否在复制自己：

...
SStack::SStack(const SStack &s) : used(-1), Capacity(0), DynamicStack(0)
{ 
    *this = s; 
}
SStack &SStack::operator=(const SStack &s)
{
    if (this != &s && s.size() > 0)
    {
        // check if we already have an allocated array
        if (Capacity < s.size())
        {
            // safe even if Capacity==0 as long as DynamicStack==0 too
            delete [] DynamicStack;  

            int cap = s.getCapacity();
            DynamicStack = new string[cap];
            Capacity = cap;
        }
        used = -1;
        for (int count = 0; count < s.size(); count++){
            DynamicStack[count] = s.DynamicStack[count];
            used++;
        }
    }
    return *this;
}

用调试器试试这个，我建议你重新检查你的“使用”变量，以确保它在所有使用它的地方都有你想要的索引。

希望这会有所帮助。