【问题标题】:Code Issue with JavaJava的代码问题
【发布时间】:2012-04-27 20:20:25
【问题描述】:

我正在使用LongIntParallelHashMultimap java 代码,这是我上一个问题的答案here。我将地图保存在磁盘中并将其加载到内存中。但是,在内存中加载地图后,当我执行 get 方法时,代码会停止执行并进入永无止境的循环。任何人都可以帮助我为什么会发生这种情况以及如何解决这个问题?任何提示都会对我有所帮助。

我的代码可以在here 找到,也可以在下面找到:

import java.io.*;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.Arrays;
import java.util.Random;
import java.nio.*;
import java.nio.channels.FileChannel;
import java.io.RandomAccessFile ;


public class Test{
public static void main(String args[]){

LongIntParallelHashMultimap abc = new LongIntParallelHashMultimap(10, "a.txt","b.txt");
Random randomGenerator = new Random();


for(int i = 1 ; i < 5 ; i++ ){
long b = (long) Math.floor(i/2) + 1 ;
int  c = randomGenerator.nextInt();
abc.put(b,c) ;
}

int[]tt = abc.get(1);
System.out.println(tt[0]);
abc.save();

abc.load();

int[]tt1 = abc.get(1);
System.out.println(tt1[0]);

 }
}

class LongIntParallelHashMultimap {

private static final long NULL = -1L ;

private final long[] keys;
private final int[] values;
private int size;
private int savenum = 0;
private String str1 = "";
private String str2 = "";

public LongIntParallelHashMultimap(int capacity, String st1, String st2 ) {
    keys = new long[capacity];
    values = new int[capacity];
     Arrays.fill(keys, NULL);
     savenum = capacity ;
     str1 = st1;
     str2 = st2;
}

public void load(){
try{
FileChannel channel2 = new RandomAccessFile(str1, "r").getChannel();
MappedByteBuffer mbb2 = channel2.map(FileChannel.MapMode.READ_ONLY, 0,     channel2.size());
 mbb2.order(ByteOrder.nativeOrder());
  assert mbb2.remaining() == savenum * 8;
 for (int i = 0; i < savenum; i++) {
long l = mbb2.getLong();
keys[i] = l ;
 }
channel2.close();

FileChannel channel3 = new RandomAccessFile(str2, "r").getChannel();
MappedByteBuffer mbb3 = channel3.map(FileChannel.MapMode.READ_ONLY, 0, channel3.size());
mbb3.order(ByteOrder.nativeOrder());
assert mbb3.remaining() == savenum * 8;
for (int i = 0; i < savenum; i++) {
long l = mbb3.getLong();
keys[i] = l ;
 }
channel3.close();
}

catch(Exception e){
        System.out.println(e) ;
    }
}

public void put(long key, int value) {
    int index = indexFor(key);
    while (keys[index] != NULL) {
        index = successor(index);
    }
    keys[index] = key;
    values[index] = value;
    ++size;
}

public int[] get(long key) {
    int index = indexFor(key);
    int count = countHits(key, index);
    int[] hits = new int[count];
    int hitIndex = 0;

    while (keys[index] != NULL) {
        if (keys[index] == key) {
            hits[hitIndex] = values[index];
            ++hitIndex;
        }
        index = successor(index);
    }

    return hits;
}

private int countHits(long key, int index) {
    int numHits = 0;
    while (keys[index] != NULL) {
        if (keys[index] == key) ++numHits;
        index = successor(index);
    }
    return numHits;
}

private int indexFor(long key) {
return Math.abs((int) ((key * 5700357409661598721L) % keys.length));
}

private int successor(int index) {
    return (index + 1) % keys.length;
}

public int size() {
    return size;
}

     public void save() {
    try {
        long l = 0 ;
 FileChannel channel = new RandomAccessFile(str1, "rw").getChannel();
 MappedByteBuffer mbb = channel.map(FileChannel.MapMode.READ_WRITE, 0, savenum * 8);
 mbb.order(ByteOrder.nativeOrder());

for(int i = 0 ; i < savenum ; i++){
l = keys[i] ;
  mbb.putLong(l);
}
channel.close();

FileChannel channel1 = new RandomAccessFile(str2, "rw").getChannel();
MappedByteBuffer mbb1 = channel1.map(FileChannel.MapMode.READ_WRITE, 0, savenum * 8);
mbb1.order(ByteOrder.nativeOrder());

for(int i = 0 ; i < savenum ; i++){
 l = values[i] ;
 mbb1.putLong(l);
 }
 channel1.close();
    }
catch (Exception e){
   System.out.println("IOException : " + e);
      }
    }
 }

【问题讨论】:

  • 你调试了吗?哪部分代码导致死循环?
  • @talnicolas,是的。 countHits 方法部分。
  • 不,真的!你不想稍微格式化一下你的代码吗?
  • 当您到达NULL 的键时您会停止,但您似乎没有在任何地方设置该值,因此它永远不会停止。
  • @BorisStrandjev,您的意思是添加 cmets。或者正确地构建它。

标签: java


【解决方案1】:

我一点点愚蠢,从而使如此愚蠢的错误。修改的代码在这里:

http://textuploader.com/?p=6&id=xkAHw。谢谢。

【讨论】:

    【解决方案2】:

    使用我的调试器单步执行代码,我可以看到您的 load() 设置了两次 keys[],而您应该设置 keys[]values[](复制和粘贴错误)

    当我更改第二个负载时,测试似乎运行良好。


    如果你想在不创建副本的情况下访问键和值,你可以从

    private final LongBuffer keys;
    private final IntBuffer values;
    private int size;
    private int savenum = 0;
    private final FileChannel channel1;
    private final FileChannel channel2;
    
    public LongIntParallelHashMultimap(int capacity, String st1, String st2) throws IOException {
        boolean newFile = !new File(st1).exists();
    
        channel1 = new RandomAccessFile(st1, "rw").getChannel();
        MappedByteBuffer mbb1 = channel1.map(FileChannel.MapMode.READ_WRITE, 0, capacity * 8);
        mbb1.order(ByteOrder.nativeOrder());
    
        keys = mbb1.asLongBuffer();
    
        channel2 = new RandomAccessFile(st2, "rw").getChannel();
        MappedByteBuffer mbb2 = channel2.map(FileChannel.MapMode.READ_WRITE, 0, capacity * 4);
        mbb2.order(ByteOrder.nativeOrder());
    
        values = mbb2.asIntBuffer();
    
        if (newFile)
            for(int i=0;i<capacity;i++)
                keys.put(i, NULL);
    
        savenum = capacity;
    }
    
    public void close() throws IOException {
        channel1.close();
        channel2.close();
    }
    

    【讨论】:

    • 我已经添加了一个示例开始。
    • 顺便说一句:一旦内存映射工作正常,当您有大映射时,请查看 Visual VM 中的程序内存。 ;)
    猜你喜欢
    • 2018-01-26
    • 1970-01-01
    • 2017-01-28
    • 2014-10-26
    • 1970-01-01
    • 1970-01-01
    • 2019-06-06
    • 1970-01-01
    • 1970-01-01
    相关资源
    最近更新 更多