延迟不返回的Javascript递归函数

Question

我得到了这个递归函数。我可以看到它在数据返回为空时循环，但在完成递归任务后数据不为空时它没有返回承诺。好像完成递归任务后，承诺在某处丢失了。有人会指出我在这里做错了什么吗？

var callrq1 = function(globalsystemid, globalgraphid, start, end, lastcheck) {
  var datetimeformat = "YYYY-MM-DD HH:mm:ss";
  var d1 = new $.Deferred();
  var request1 = "../system/" + globalsystemid + "/highcharts.xml?type=" + globalgraphid + "&start=" + start + "&end=" + end;
  var requeststring1 = makejson(request1); //this makejson function is an ajax get and return promise
  requeststring1.done(function(data) {
    if (data != null) {
      d1.resolve(data);
    } else {
      var theend = moment(lastcheck).format(datetimeformat);
      var newstart = moment(end).format(datetimeformat);
      var newend = moment(end).add(1, 'weeks').format(datetimeformat);
      if (newend <= theend) {
        //recursive callrq1
        callrq1(globalsystemid, globalgraphid, newstart, newend, theend);
      } else {
        d1.resolve(null);
      }
    }
  });
  return d1.promise();
}

callrq1(globalsystemid, globalgraphid, starttimeobj.start, starttimeobj.end, endtimeobj.start).then(function(data) {
  console.log(data);
});

Answer 1

在递归的情况下你没有解决延迟

var callrq1 = function (globalsystemid, globalgraphid, start, end, lastcheck) {
    var datetimeformat = "YYYY-MM-DD HH:mm:ss";
    var d1 = new $.Deferred();
    var request1 = "../system/" + globalsystemid + "/highcharts.xml?type=" + globalgraphid + "&start=" + start + "&end=" + end;
    var requeststring1 = makejson(request1); //this makejson function is an ajax get and return promise
    requeststring1.done(function (data) {
        if (data != null) {
            d1.resolve(data);
        } else {
            var theend = moment(lastcheck).format(datetimeformat);
            var newstart = moment(end).format(datetimeformat);
            var newend = moment(end).add(1, 'weeks').format(datetimeformat);
            if (newend <= theend) {
                //recursive callrq1
                callrq1(globalsystemid, globalgraphid, newstart, newend, theend).done(function(data){
                    d1.resolve(data);//pass any data required
                });
            } else {
                d1.resolve(null);
            }
        }
    });
    return d1.promise();
}

callrq1(globalsystemid, globalgraphid, starttimeobj.start, starttimeobj.end, endtimeobj.start).then(function (data) {
    console.log(data);
});

Answer 2

在递归调用的情况下，您错过了解决您的延迟。但是，首先是您shouldn't be using a deferred！只需链接一个then 回调并从您的函数返回结果承诺。您甚至可以从回调中返回 Promise，我们将其用于递归案例：

function callrq1(globalsystemid, globalgraphid, start, end, lastcheck) {
  var datetimeformat = "YYYY-MM-DD HH:mm:ss";
  var request1 = "../system/" + globalsystemid + "/highcharts.xml?type=" + globalgraphid + "&start=" + start + "&end=" + end;
  var requeststring1 = makejson(request1); //this makejson function is an ajax get and return promise
  return requeststring1.then(function(data) {
//^^^^^^                ^^^^
    if (data != null) {
      return data;
//    ^^^^^^
    } else {
      var theend = moment(lastcheck).format(datetimeformat);
      var newstart = moment(end).format(datetimeformat);
      var newend = moment(end).add(1, 'weeks').format(datetimeformat);
      if (newend <= theend) {
        return callrq1(globalsystemid, globalgraphid, newstart, newend, theend);
//      ^^^^^^
      } else {
        return null;
//      ^^^^^^
      }
    }
  });
}