在excel vba的数组优化中查找字符串

Question

我有一段代码可以满足我的需要。但是，它运行得太慢了。通过研究，我发现“缓慢”来自不断访问工作簿，如果我可以从数组中执行操作，它应该会显着提高性能速度。我还没有找到任何专门帮助我解决这个问题的东西。所以这就是我得到的。

我的代码在一个单元格中搜索一个字符串 (xlpart)，该单元格将包含多个用逗号分隔的数据条目。它会找到该实例和所有其他实例（以及它们在逗号分隔字符串中的位置），然后将它们重新组合成一个以逗号分隔的新字符串。

就像我说的那样，这行得通，但是当我将它应用到 4000 行时，它会破坏 CPU。我什至尝试添加一些我发现的“加速”想法，例如 .Calculation 和 .Screenupdating。我看到的问题在“Set test =”行中。有没有办法搜索数组、查找字符串的实例并提取特定信息？还是我做错了？

Function FindRef(lookupValue As Range, lookupRange As Range, resultsRange As Range) As String
Application.Calculation = xlCalculationManual
Application.ScreenUpdating = False

Dim OutputName1 As String
Dim OutputName2 As String
Dim r As Long
Dim test As Range
Dim working1() As String
Dim working2() As String

i = 0
For r = 1 To lookupRange.Rows.Count
  Set test = lookupRange.Cells(r, 1).Find(lookupValue.Value, LookIn:=xlValues, lookat:=xlPart)
  If Not test Is Nothing Then
    working1() = Split(lookupRange.Cells(r, 1), ", ")
    For j = LBound(working1) To UBound(working1)
      If working1(j) = CheckValue Then
        working2() = Split(resultsRange.Cells(r, 1), ", ")
        If UBound(working2) > 0 Then
          OutputName1 = working2(j)
        Else
          OutputName1 = resultsRange.Cells(r, 1)
        End If
      End If
    i = i + 1
    If i = 1 Then
      OutputName2 = OutputName1
    Else
      OutputName2 = OutputName2 & ", " & OutputName1
    End If
    OutputName1 = ""
    Next j
  End If
Next
FindRef = OutputName2

Application.Calculation = xlCalculationAutomatic
Application.ScreenUpdating = True
End Function

更新代码：

Function FindRef(lookupValue As Range, lookupRange As Range, resultsRange As Range) As String

Application.Calculation = xlCalculationManual
Application.ScreenUpdating = False

Dim OutputName1 As String
Dim OutputName2 As String
Dim r As Long
Dim test As Variant
Dim working1() As String
Dim working2() As String
Dim CheckValue As String
Dim data() As Variant
Dim data2() As Variant

CheckValue = lookupValue.Value2
data = lookupRange.Value2
data2 = resultsRange.Value2

i = 0
r = 0
For Each test In data
  r = r + 1
  If test = CheckValue Then
    working1() = Split(data(r, 1), ", ")
    For j = LBound(working1) To UBound(working1)
      If working1(j) = CheckValue Then
        working2() = Split(data2(r, 1), ", ")
        If UBound(working2) > 0 Then
          OutputName1 = working2(j)
        Else
          OutputName1 = data2(r, 1)
        End If
      End If
    i = i + 1
    If i = 1 Then
      OutputName2 = OutputName1
    Else
      OutputName2 = OutputName2 & ", " & OutputName1
    End If
    OutputName1 = ""
    Next j
  End If
Next
FindRef = OutputName2
Application.Calculation = xlCalculationAutomatic
Application.ScreenUpdating = True
End Function

Answer 1

使用 Range.Find 很慢。

使用变体数组要快得多。见我的Match vs Find vs Variant Array