【问题标题】:RecyclerView updates view upon object deletion except for last objectRecyclerView 在对象删除时更新视图,最后一个对象除外
【发布时间】:2020-08-23 08:27:50
【问题描述】:

在我的应用程序中,我有一个活动,它在 RecyclerView 中显示学生的 ArrayList。学生存储在 Firebase 实时数据库中。用户可以添加或删除学生。当用户删除一个学生时,RecyclerView 会更新并显示剩余的学生。

但是我有一个问题。例如,假设我有 5 个学生。我想删除所有 5 个,所以我将它们一个一个删除。 4 名学生正确删除,RecyclerView 更新并反映了这一点。只有当我删除最后一个学生时,RecyclerView 才不会更新并且学生 CardView 会留在那里。我收到一条确认学生删除的 toast 消息,我可以看到他们已在数据库中删除。如果我导航回仪表板并返回学生列表,CardView 就会消失。奇怪。

我尝试在每次删除后再次调用 onStart,但这没有帮助。有什么想法吗?

我的活动:

public class StudentListActivity extends AppCompatActivity {

//firebase auth
private FirebaseAuth mAuth;

//public variables
public String currentUserAccount;
public String teacherAccountNav = "Teacher";
public String currentUserId;

//recyclerView variables
DatabaseReference ref;
ArrayList<Student> list;
RecyclerView recyclerView;
SearchView searchView;

@RequiresApi(api = Build.VERSION_CODES.KITKAT)
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_student_list);

    //get current user
    mAuth = FirebaseAuth.getInstance();
    FirebaseUser user = mAuth.getCurrentUser();
    //assert current user is not null and get current users id
    assert user != null;
    currentUserId = user.getUid();

    //getting firebase reference of current users students
    ref = FirebaseDatabase.getInstance().getReference().child("students").child(currentUserId);

    //initialise views
    recyclerView = findViewById(R.id.rv);
    recyclerView.setHasFixedSize(true);
    searchView = findViewById(R.id.searchView);

}

@Override
protected void onStart() {
    super.onStart();
    if(ref != null){
        ref.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {

                //add students from firebase to an array list
                if(dataSnapshot.exists()){
                    list = new ArrayList<>();
                    for(DataSnapshot ds : dataSnapshot.getChildren()){
                        list.add(ds.getValue(Student.class));
                    }

                    //sort by name
                    Collections.sort(list, Student.myName);

                    //make recycler view
                    recyclerView.setLayoutManager(new LinearLayoutManager(StudentListActivity.this));
                    StudentAdapterClass studentAdapterClass = new StudentAdapterClass(list);
                    recyclerView.setAdapter(studentAdapterClass);

                    //click listeners for buttons
                    studentAdapterClass.setOnItemClickListener(new StudentAdapterClass.OnItemClickListener() {

                        @Override
                        public void onUpdateClick(int position) {
                            //handle update click in here
                            Student student = list.get(position);

                            //show update dialog here
                            showUpdateDialog(student.getStudentId(), student.getStudentName(), student.getStudentEmail());
                        }

                        @Override
                        public void onDeleteClick(int position){
                            //handle delete click in here
                            Student student = list.get(position);

                            //show delete dialog here
                            showDeleteDialog(student.getStudentId());
                        }

                    });

                }
            }

            @Override
            public void onCancelled(@NonNull DatabaseError databaseError) {
                Toast.makeText(StudentListActivity.this, databaseError.getMessage(), Toast.LENGTH_SHORT).show();
            }
        });
    }//if

  
}


//dialog box for deleting student
private void showDeleteDialog(final String studentId){
    AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(this);

    LayoutInflater inflater = getLayoutInflater();

    //dialog XML
    final View dialogView = inflater.inflate(R.layout.delete_student_dialog, null);

    dialogBuilder.setView(dialogView);

    final ImageButton buttonNo = dialogView.findViewById(R.id.imageButtonNo);
    final ImageButton buttonYes = dialogView.findViewById(R.id.imageButtonYes);

    final AlertDialog alertDialog = dialogBuilder.create();
    alertDialog.show();

    buttonNo.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            alertDialog.dismiss();
        }
    });

    buttonYes.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {

            deleteStudent(studentId);

            alertDialog.dismiss();
        }
    });
}

//delete student method
private void deleteStudent(String id){
    //get current user
    mAuth = FirebaseAuth.getInstance();
    FirebaseUser user = mAuth.getCurrentUser();
    //assert current user is not null and get current users id
    assert user != null;
    currentUserId = user.getUid();

    DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference("students").child(currentUserId).child(id);

    databaseReference.removeValue();

    Toast.makeText(this, "Student Deleted", Toast.LENGTH_LONG).show();

    //clear and get new list
    onStart();

}

我的适配器:

public class StudentAdapterClass extends RecyclerView.Adapter<StudentAdapterClass.MyViewHolder> {

private ArrayList<Student> list;

private OnItemClickListener mListener;

public interface OnItemClickListener{
    //click method for update button
    void onUpdateClick(int position);
    //click method for delete button
    void onDeleteClick(int position);

}

public void setOnItemClickListener(OnItemClickListener listener){
    mListener = listener;
}

public StudentAdapterClass(ArrayList<Student> list){

    this.list = list;
}


@NonNull
@Override
public MyViewHolder onCreateViewHolder(@NonNull ViewGroup viewGroup, int i) {
     View view = LayoutInflater.from(viewGroup.getContext()).inflate(R.layout.card_holder, viewGroup, false);
     return new MyViewHolder(view, mListener);
}

@Override
public void onBindViewHolder(@NonNull MyViewHolder myViewHolder, int i) {
    myViewHolder.name.setText(list.get(i).getStudentName());
    myViewHolder.email.setText(list.get(i).getStudentEmail());

}

@Override
public int getItemCount() {

    return list.size();
}

static class MyViewHolder extends RecyclerView.ViewHolder {
    TextView name, email;
    ImageButton update, delete;
    MyViewHolder(@NonNull View itemView, final OnItemClickListener listener) {
        super(itemView);
        name = itemView.findViewById(R.id.studentName);
        email = itemView.findViewById(R.id.studentEmail);
        update = itemView.findViewById(R.id.updateButton);
        delete = itemView.findViewById(R.id.deleteButton);

        //update click listener
        update.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                if (listener != null){
                    int position = getAdapterPosition();
                    if(position != RecyclerView.NO_POSITION){
                        listener.onUpdateClick(position);
                    }
                }

            }
        });

        delete.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                if (listener != null){
                    int position = getAdapterPosition();
                    if(position != RecyclerView.NO_POSITION){
                        listener.onDeleteClick(position);
                    }
                }
            }
        });
    }
}

【问题讨论】:

  • 上次调用 onStart() 时是否调用了 onDataChanged?将日志语句放入两者中以找出答案。
  • 你最好不要在 deleteStudent() 结束时调用 onStart()。
  • 我不明白,如果您的数据库中有五个学生并开始您的活动,则会调用 onStart 并且您设置了一个将调用 onDataChange 的侦听器。如果没有,您将不会设置您的回收视图。
  • list = new ArrayList&lt;&gt;(); 您应该始终创建一个新列表。不仅在您拥有数据快照的情况下。

标签: java android firebase-realtime-database arraylist android-recyclerview


【解决方案1】:

每次RecyclerView数据发生变化,都必须调用适配器方法notifyDataSetChanged(),否则RecyclerView无法正确刷新。 您可以像这样在deleteStudent() 方法中调用它。

recyclerView.getAdapter().notifyDataSetChanged()

【讨论】:

  • 感谢您的建议,但它不起作用。同样的行为仍在发生。
  • 因为您还需要将列表设置为适配器。不知道你是怎么删除的,你需要把list里的那个项目删掉再更新到adapter。
  • 啊,是的!我没有从列表和数据库中删除学生,这修复了它。谢谢!
  • 不,这不是问题,因为你说有四个学生正确删除。我相信。您没有依赖 notifyDataSetChanged 而是依赖 onDataChange 并构建了一个完整的新列表和适配器。只有第五个学生才能通过不创建新列表来保持列表不变。
  • 而且...如果您设置了一个新的适配器,那么您根本不需要调用 notifyDataSetChanged。
猜你喜欢
  • 2017-11-19
  • 1970-01-01
  • 1970-01-01
  • 1970-01-01
  • 2017-01-28
  • 2013-06-03
  • 2012-02-26
  • 1970-01-01
  • 2022-01-24
相关资源
最近更新 更多