【问题标题】:How to use struct self in member method closure如何在成员方法闭包中使用 struct self
【发布时间】:2018-07-20 22:22:36
【问题描述】:

如何在闭包中调用方法? get_access_token 方法可以根据self.get_base_url() 设置新的访问令牌:

fn fetch_access_token(_base_url: &String) -> String {
    String::new()
}

fn get_env_url() -> String {
    String::new()
}

pub struct App {
    pub base_url: Option<String>,
    pub access_token: Option<String>,
}

impl App {
    pub fn new() -> App {
        App {
            base_url: None,
            access_token: None,
        }
    }
    pub fn get_base_url(&mut self) -> &String {
        self.base_url.get_or_insert_with(|| get_env_url())
    }
    pub fn get_access_token(&mut self) -> &String {
        self.access_token
            .get_or_insert_with(|| fetch_access_token(self.get_base_url()))
    }
}

fn main() {}

错误:

Rust 2015

error[E0500]: closure requires unique access to `self` but `self.access_token` is already borrowed
  --> src/main.rs:26:33
   |
25 |         self.access_token
   |         ----------------- borrow occurs here
26 |             .get_or_insert_with(|| fetch_access_token(self.get_base_url()))
   |                                 ^^                    ---- borrow occurs due to use of `self` in closure
   |                                 |
   |                                 closure construction occurs here
27 |     }
   |     - borrow ends here

Rust 2018

error[E0501]: cannot borrow `self.access_token` as mutable because previous closure requires unique access
  --> src/main.rs:25:9
   |
25 | /         self.access_token
26 | |             .get_or_insert_with(|| fetch_access_token(self.get_base_url()))
   | |______________------------------_--____________________----________________^ second borrow occurs here
   |                |                  |                     |
   |                |                  |                     first borrow occurs due to use of `self` in closure
   |                |                  closure construction occurs here
   |                first borrow later used by call

error[E0500]: closure requires unique access to `self` but it is already borrowed
  --> src/main.rs:26:33
   |
24 |       pub fn get_access_token(&mut self) -> &String {
   |                               - let's call the lifetime of this reference `'1`
25 |           self.access_token
   |           -----------------
   |           |
   |  _________borrow occurs here
   | |
26 | |             .get_or_insert_with(|| fetch_access_token(self.get_base_url()))
   | |_________________________________^^____________________----________________- returning this value requires that `self.access_token` is borrowed for `'1`
   |                                   |                     |
   |                                   |                     second borrow occurs due to use of `self` in closure
   |                                   closure construction occurs here

【问题讨论】:

  • fn get_*(&amp;mut self) - 这不是 getter 通常的工作方式。如何将字段设为私有,并将它们初始化为您正在寻找的默认值?也不要使用&amp;String - 请改用&amp;str
  • 也许vorner.github.io/difficult.html#rust-is-different 对你来说是一本好书。 TLDR:你正试图以你习惯的方式解决问题,但它不适合 Rust - 如果你告诉我们更多关于实际问题的信息,你可能会得到关于 Rust 解决问题的更好的答案。
  • 谢谢大家。这是来自 IRC #rust-beginners 的解决方案。
    Rust Play Ground Code Link 的代码示例
  • @Aqrun 请不要将答案放在评论中。欢迎您在下面添加您自己的答案。如果你觉得你不应该把别人的答案归功于别人(例如 IRC 上的任何人),你可以选择将答案设为“社区 wiki”。

标签: rust closures borrow-checker mutability


【解决方案1】:

将您的数据和方法拆分为更小的组件,然后您可以在self 上对各个组件进行不相交的借用:

fn fetch_access_token(_base_url: &str) -> String { String::new() }
fn get_env_url() -> String { String::new() }

#[derive(Default)]
struct BaseUrl(Option<String>);

impl BaseUrl {
    fn get(&mut self) -> &str {
        self.0.get_or_insert_with(|| get_env_url())
    }
}

#[derive(Default)]
struct App {
    base_url: BaseUrl,
    access_token: Option<String>,
}

impl App {
    fn new() -> App {
        App::default()
    }

    fn get_access_token(&mut self) -> &str {
        let base_url = &mut self.base_url;
        self.access_token
            .get_or_insert_with(|| fetch_access_token(base_url.get()))
    }
}

fn main() {}

您可以更进一步,为这两个值执行此操作:

fn fetch_access_token(_base_url: &str) -> String { String::new() }
fn get_env_url() -> String { String::new() }

#[derive(Default)]
struct BaseUrl(Option<String>);

impl BaseUrl {
    fn get(&mut self) -> &str {
        self.0.get_or_insert_with(|| get_env_url())
    }
}

#[derive(Default)]
struct AccessToken(Option<String>);

impl AccessToken {
    fn get(&mut self, base_url: &str) -> &str {
        self.0.get_or_insert_with(|| fetch_access_token(base_url))
    }
}

#[derive(Default)]
struct App {
    base_url: BaseUrl,
    access_token: AccessToken,
}

impl App {
    fn new() -> App {
        App::default()
    }

    fn get_access_token(&mut self) -> &str {
        let base_url = self.base_url.get();
        self.access_token.get(base_url)
    }
}

fn main() {}

这让你看到你可以抽象出常见的功能:

fn fetch_access_token(_base_url: &str) -> String { String::new() }
fn get_env_url() -> String { String::new() }

#[derive(Default)]
struct StringCache(Option<String>);

impl StringCache {
    fn get<F>(&mut self, f: F) -> &str
    where
        F: FnOnce() -> String,
    {
        self.0.get_or_insert_with(f)
    }
}

#[derive(Default)]
struct App {
    base_url: StringCache,
    access_token: StringCache,
}

impl App {
    fn new() -> App {
        App::default()
    }

    fn get_access_token(&mut self) -> &str {
        let base_url = self.base_url.get(get_env_url);
        self.access_token.get(|| fetch_access_token(base_url))
    }
}

fn main() {}

然后你意识到抽象可以被通用化:

fn fetch_access_token(_base_url: &str) -> String { String::new() }
fn get_env_url() -> String { String::new() }

#[derive(Default)]
struct Cache<T>(Option<T>);

impl<T> Cache<T> {
    fn get<F>(&mut self, f: F) -> &T
    where
        F: FnOnce() -> T,
    {
        self.0.get_or_insert_with(f)
    }
}

#[derive(Default)]
struct App {
    base_url: Cache<String>,
    access_token: Cache<String>,
}

impl App {
    fn new() -> App {
        App::default()
    }

    fn get_access_token(&mut self) -> &str {
        let base_url = self.base_url.get(get_env_url);
        self.access_token.get(|| fetch_access_token(base_url))
    }
}

fn main() {}

另见:

【讨论】:

    【解决方案2】:

    Option&lt;T&gt; 中传递给get_or_insert_with 方法的闭包是FnOnce 类型 - 因此它消耗移动 捕获的变量。在这种情况下,self 被捕获,因为在闭包中使用了self.get_base_url()。然而,由于self 已经被借用,闭包不能消耗或移动self 的值以获得唯一访问权。

    这可以通过使用get_or_insert 方法来规避,但无论access_token 是否为None,每次调用get_access_token 时,它都需要您执行获取访问令牌的潜在昂贵操作.

    【讨论】:

    • 谢谢,但正如你所说,我认为必须有更有效的方法,或者其他代码结构来解决像这样的问题 rust 风格
    【解决方案3】:

    我会改用这样的东西:

    Playground

    fn fetch_access_token(base_url: &str) -> Result<String, ()> {
        let _url = format!("{}/v3/auth/token", base_url);
        // ...
        let token = String::from("test token");
        Ok(token)
    }
    
    fn get_env_url() -> String {
        String::from("http://www.test.com")
    }
    
    pub struct App {
        // private fields!
        base_url: String,
        access_token: Option<String>,
    }
    
    impl App {
        pub fn new() -> App {
            App {
                base_url: get_env_url(),
                access_token: None,
            }
        }
    
        /// set new base url; clears cached access token
        pub fn set_base_url(&mut self, base_url: String) {
            self.base_url = base_url;
            self.access_token = None;
        }
    
        pub fn get_base_url(&self) -> &str {
            &self.base_url
        }
    
        /// retrieve (possibly cached) access token. tries again if previous attempt failed.
        pub fn retrieve_access_token(&mut self) -> Result<&str, ()> {
            if self.access_token.is_none() {
                self.access_token = Some(fetch_access_token(&self.base_url)?);
            }
            Ok(self.access_token.as_ref().unwrap())
        }
    }
    
    fn main() {
        let mut app = App::new();
        println!("{}", app.retrieve_access_token().unwrap());
    }
    

    【讨论】:

    • 这行得通,但永远不会失败的unwrap 总是让我难过。
    猜你喜欢
    • 2019-08-28
    • 2015-04-20
    • 2017-08-10
    • 2012-03-08
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 2014-10-09
    相关资源
    最近更新 更多