在数组中插入元素的代码错误

Question

这里我写了一个代码，它接受一个适合用户的任何大小的数组，用户同意在集合中插入一个新整数的位置，并与要插入的整数坐标。

#include <stdio.h>
#include <stdlib.h>

void insert(int barray_size, int *A, int new_place, int new_int)
{
    for (int i = barray_size; i >= new_place; i = i - 1)
    {
        *(A + i) = *(A + i - 1); //copies value of cell A[i-1] to cell A[i]
        *(A + i - 1) = 0; //empties cell A[i-1] so that it can take the value A[i-2] in next loop
    }

    *(A + new_place - 1) = new_int; //putting the required integer at A[k]
}

int main()
{
    int n, k, l;
    printf("Please enter array size: ");
    scanf("%d", &n);
    printf("\n");
    int A[n + 1];

    for (int i = 0; i < n; i++)
    {
        int temp;
        printf("Enter [%d] element: ", i);
        scanf("%d", &temp);
        A[i] = temp;
        printf("\n");
    }

    A[n] = 0;
    printf("Enter the place where new integer is to be inserted: ");
    scanf("%d", &k);

    if (k < n + 1)
    {
        printf("Enter the integer to be inserted: ");
        scanf("%d", &l);
        int t = n + 1;
        insert(t, A, k, l);
        printf("The new array is: ");

        for (int i = 0; i < t; ++i)
        {
            printf("%d ", A[i]);
        }
    }
    else
    {
        printf("Please enter a valid address.");
    }
}

但是当我运行这段代码时，它在接受整数位置后终止，但不接受要插入的整数。 您介意帮助检测错误吗？

谢谢

编辑1：修正scanf中地址的小错误。

现在程序或多或少地将整数正确地添加到数组中（尽管如果在k 处请求，则在位置k + 1，但可以更正）。但是它会打印除A[i + 1] 之外的所有数组值以及垃圾值，尽管最后使用了 for 循环，它应该在A[n + 1] 处停止打印循环。为什么会这样？

（如果我的疑问是琐碎或愚蠢的，我深表歉意。我最近开始学习C语言，由于缺乏实践，我很容易出现这种琐碎的错误，并且在练习时需要帮助澄清这些疑问，我寻求在SO）

编辑2：在初始化A[n] = 0（之前缺少的）后，程序可以完美运行并正常终止。

感谢大家的帮助。

Answer 1

你忘记在scanf和你的中指定变量k和l的地址

变化：

scanf("%d", k);
scanf("%d", l);

收件人：

scanf("%d", &k);
scanf("%d", &l);

变化：

for (int i = 0; i < n+1; i++)

收件人：

for (int i = 0; i < n; i++)

下面是修改后的代码：

#include <stdio.h>
#include <stdlib.h>

void insert(int arrSize, int *A, int newPlace, int newInt)
{
    for(int i = arrSize; i > newPlace; i = i - 1)
    {
        *(A + i) = *( A + (i - 1));
        *(A + (i - 1)) = 0; 
    }
    *(A + newPlace) = newInt; 
}

int main()
{
    int no, place, newdata;
    printf("Please enter array size: ");
    scanf("%d", &no);
    printf("\n");
    int arr[no];
    for (int index = 0; index < no; index++)
    {
        int temp;
        printf("Enter [%d] element: ", index);
        scanf("%d", &temp);
        arr[index] = temp;
        printf("\n");
    }
    
    printf("Enter the place where new integer is to be inserted: ");
    scanf("%d", &place);
    
    if(place < no)
    {
        printf("Enter the integer to be inserted: ");
        scanf("%d", &newdata);
        
        insert(no, arr, place, newdata);
        printf("The new array is: ");
        for (int index2 = 0; index2 <= no; index2++)
        {
            printf("%d ", arr[index2]);
        }
    }
    else
    {
        printf("Please enter a valid address.");
    }
}

输出

Please enter array size: 7

Enter [0] element: 1

Enter [1] element: 2

Enter [2] element: 3

Enter [3] element: 4

Enter [4] element: 5

Enter [5] element: 6

Enter [6] element: 7

Enter the place where new integer is to be inserted: 5
Enter the integer to be inserted: 10
The new array is: 1 2 3 4 5 10 6 7 

Answer 2

在您的代码中，当您执行scanf("%d", ) 时，您需要传入变量的地址。不是变量本身。您可以尝试以下方法，看看是否有效：

int main()
{
    // CODE TO READ ARRAY AS YOU HAVE ALREADY WRITTEN
    printf(("Enter the place where new integer is to be inserted: ");
    scanf("%d", &k); // CHANGE HERE from k to &k
    printf("Enter the integer to be inserted: ");
    scanf("%d", &l); // CHANGE HERE FROM l to &l
    /* CHANGE HERE. 
    You don't need n+1 because when you create an array of size n+1, the indices are from 0 to n. 
    You are reading values only for 0 to n-1 in your loop.
    In your insert function, you are starting at i=n which is the last free space in the array.
    */
    insert(n, A, k, l)
    // REST OF YOUR CODE TO PRINT THE ARRAY
}