【问题标题】:My tic-tac-toe Python game doesn't end when a player wins当玩家获胜时,我的井字游戏 Python 游戏并未结束
【发布时间】:2015-08-22 20:01:37
【问题描述】:

美好的一天。我目前正在阅读 Michael Dawson 的书Python for the Absolute Beginner。我有第 6 章的代码,当我运行代码并在板上得到直的“X”时,它不会返回获胜者。程序继续执行,直到所有空格都标有“X”或“O”。这是我的代码:

#!/usr/bin/python3
X = "X"
O = "O"
EMPTY = " "
TIE = "TIE"
NUM_SQUARES = 9

def display_instruct():
    print(
          """
          Welcome to the greatest intellectual challenge of all time: Tic-Tac-Toe.
          This will be a showdown between your human brain and my silicon processor.

          You will make your move known by entering a number, 0 - 8. The number
          will correspond to the board position as illustrated:

                                      0 | 1 | 2
                                     -----------
                                      3 | 4 | 5
                                     -----------
                                      6 | 7 | 8

            Prepare your self, human. The ultimate battle is about to begin. \n
            """)

def ask_yes_no(question):
    response = None
    while response not in ("y", "n"):
        response = input(question).lower()
    return response

def ask_number(question, low, high):
    response = None
    while response not in range(low, high):
        response = int(input(question))
    return response

def pieces():
    go_first = ask_yes_no("Do you require the first move? (y/n): ")
    if go_first == "y":
        print( "\nThen take the first move. You will need it. ")
        human = X
        computer = O
    else:
        print("\nYour bravery will be your undoing... I will go first.")
        computer = X
        human = O
    return computer, human

def new_board():
    board = []
    for square in range(NUM_SQUARES):
        board.append(EMPTY)
    return board

def display_board(board):
    print("\n\t", board[0], "|", board[1], "|", board[2])
    print("\t", "---------")
    print("\t", board[3], "|", board[4], "|", board[5])
    print("\t", "---------")
    print("\t", board[6], "|", board[7], "|", board[8], "\n")

def legal_moves(board):
    moves = []
    for square in range(NUM_SQUARES):
        if board[square] == EMPTY:
            moves.append(square)
    return moves

def winner(board):
    WAYS_TO_WIN = ((0, 1, 2),
                   (3, 4, 5),
                   (6, 7, 8),
                   (0, 3, 6),
                   (1, 4, 7),
                   (2, 5, 8),
                   (0, 4, 8),
                   (2, 4, 6))

    for row in WAYS_TO_WIN:
        if board[row[0]] == board[row[1]] == board[row[2]] != EMPTY:
            winner = board[row[0]]
            return winner

        if EMPTY not in board:
            return TIE

        return None

def human_move(board, human):
    """Get human move."""
    legal = legal_moves(board)
    move = None
    while move not in legal:
        move = ask_number("Where will you move? (0 - 8): ", 0, NUM_SQUARES)
        if move not in legal:
            print("\nThat square is already occupied, foolish human. Choose another.\n")
    print("Fine....")
    return move

def computer_move(board, computer, human):
    """Make computer move."""
    #make a copy to work with since function will be changing list.
    board = board[:]
    BEST_MOVES = (4, 0, 2, 6, 8, 1, 3, 5, 7)
    print("I shall take square number")

    # if computer can win, take that move
    for move in legal_moves(board):
        board[move] = computer
        if winner(board) == computer:
            print(move)
            return move
        board[move] = EMPTY

    # if human can win, block that move
    for move in legal_moves(board):
        board[move] = human
        if winner(board) == human:
            print(move)
            return move
        # done checking this move, undo it
        board[move] =  EMPTY

    # since no one ca win on next move, pick best open square
    for move in BEST_MOVES:
        if move in legal_moves(board):
            print(move)
            return move

def next_turn(turn):
    if turn == X:
        return 0
    else:
        return X

def congrat_winner(the_winner, computer, human):
    if the_winner != TIE:
        print(the_winner, "won!\n")
    else:
        print("It's a tie!\n")
    if the_winner == computer:
        print("As I predicted, human, I am triumphant once more. \n" \
              "Proof that computers are superior to humans in all regards.\n")

    elif the_winner == human:
        print("No, no! It cannot be! Somehow you tricked me, human. \n" \
              "But never again! I, the computer, so swears it\n!")

    elif the_winner == TIE:
              print("You were most lucky, human, and somehow managed to tie me. \n" \
                    "Celebrate today... for this is the best you will ever achieve.\n")

def main():
    display_instruct()
    computer, human = pieces()
    turn = X
    board = new_board()
    display_board(board)

    while not winner(board):
        if turn == human:
            move = human_move(board, human)
            board[move] = human
        else:
            move = computer_move(board, computer, human)
            board[move] = computer

        display_board(board)
        turn = next_turn(turn)

    the_winner = winner(board)
    congrat_winner(the_winner, computer, human)

main()

input("Press enter to exit")

【问题讨论】:

  • 您好,先生!赞成礼貌的英语问候。
  • 我不太确定这会解决您的问题,但您可以尝试换行: if board[row[0]] == board[row[1]] == board[ row[2]] != EMPTY: to: if board[row[0]] == board[row[1]] == board[row[2]] and board[row[0]]!= EMPTY:
  • 感谢您给我的所有答案。我很感激。希望大家有一个美好的一天。
  • 最后一个问题。关于ways_to_win中的返回None。如果获胜者返回,它不会返回 None 对吗?为什么?最后输入返回 None 。我的理解是,当“返回获胜者”时,程序将继续执行,直到函数的最后一条语句“返回无”。为什么“回头客”不会变成“回头客”。对不起我的英语不好。如果你不明白。我再解释一遍。

标签: python tic-tac-toe


【解决方案1】:

检查胜负的函数不正确。目前你有这个:

def winner(board):
    WAYS_TO_WIN = ((0, 1, 2),
                   (3, 4, 5),
                   (6, 7, 8),
                   (0, 3, 6),
                   (1, 4, 7),
                   (2, 5, 8),
                   (0, 4, 8),
                   (2, 4, 6))

    for row in WAYS_TO_WIN:
        if board[row[0]] == board[row[1]] == board[row[2]] != EMPTY:
            winner = board[row[0]]
            return winner

        if EMPTY not in board:
            return TIE

        return None

请注意 return None 在循环内,因此当第一行匹配失败时,您将返回 None。除非板已满,在这种情况下,您正确返回 TIE,除非您可以在尝试匹配任何行之前检查板是否已满。

我们可以通过重新缩进return None 使函数正确,以便它在循环之后执行。此外,将TIE 检查移到循环之前是有意义的。

def winner(board):
    if EMPTY not in board:
        return TIE

    WAYS_TO_WIN = ((0, 1, 2),
                   (3, 4, 5),
                   (6, 7, 8),
                   (0, 3, 6),
                   (1, 4, 7),
                   (2, 5, 8),
                   (0, 4, 8),
                   (2, 4, 6))

    for row in WAYS_TO_WIN:
        if board[row[0]] == board[row[1]] == board[row[2]] != EMPTY:
            winner = board[row[0]]
            return winner

    return None

让我们回顾一下这个函数的作用。我们首先检查一个完整的董事会。然后我们继续考虑获胜的方法。如果它们都不匹配,我们返回None

您的代码中还有一个问题:

def next_turn(turn):
    if turn == X:
        return 0
    else:
        return X

为了使后面的测试 if turn == human: 在所有情况下都能正常工作,turn 的值必须是 XO,而不是 X0。这是快速修复:

def next_turn(turn):
    if turn == X:
        return O
    else:
        return X

解决此问题的更好方法是避免使用名为 O 的变量。

【讨论】:

  • 感谢先生非常有帮助的回答。先生,我可以问一些问题吗?你是在哪里学习使用 python 编程的?我可以问一些提示,我可以在哪里了解更多关于 python 的信息?尤其是关于类和 Tknter。
  • 我通过阅读 Python 的发明者 Guido van Rossum 撰写的 the tutorial 来学习 Python。它包括关于类的材料。我从Manning book 学习了 Tkinter。
  • 好的,谢谢。您还喜欢阅读哪些其他书籍或对您有很大帮助的书籍。谢谢!
  • 我读过的唯一一本关于 Python 的书是by Mark Pilgrim。这很好。我推荐它。
  • 谢谢先生。最后一个问题。关于ways_to_win中的返回None。如果获胜者返回,它不会返回 None 对吗?为什么?最后输入返回 None 。我的理解是,当“返回获胜者”时,程序将继续执行,直到函数的最后一条语句“返回无”。为什么“回头客”不会变成“回头客”。对不起我的英语不好。如果你不明白。我再解释一遍。
【解决方案2】:

你还在def(congrat_winner)中犯了一个缩进错误

正确的做法是:

    def congrat_winner(the_winner, computer, human):

        if the_winner != TIE:
            print(the_winner, "won!\n")
        else:
            print("It's a tie!\n")

        if the_winner == computer:
            print("As I predicted, human, I am triumphant once more. \n" \
                  "Proof that computers are superior to humans in all regards.\n")

        elif the_winner == human:
            print("No, no! It cannot be! Somehow you tricked me, human. \n" \
                  "But never again! I, the computer, so swears it\n!")

        elif the_winner == TIE:
            print("You were most lucky, human, and somehow managed to tie me. \n" \
                  "Celebrate today... for this is the best you will ever achieve.\n")

此外,最后一个elif 应替换为else

    def congrat_winner(the_winner, computer, human):

        if the_winner != TIE:
            print(the_winner, "won!\n")
        else:
            print("It's a tie!\n")

        if the_winner == computer:
            print("As I predicted, human, I am triumphant once more. \n" \
                  "Proof that computers are superior to humans in all regards.\n")

        elif the_winner == human:
            print("No, no! It cannot be! Somehow you tricked me, human. \n" \
                  "But never again! I, the computer, so swears it\n!")

        else:
            print("You were most lucky, human, and somehow managed to tie me. \n" \
                  "Celebrate today... for this is the best you will ever achieve.\n")

【讨论】:

    【解决方案3】:

    了解您已经有了答案,但有一条建议 - 尝试单独测试您的功能。

    在您的情况下,您已经预感到您的 winner 函数存在问题。我直接从你的问题中得到了这个,你提到“它不会返回赢家”。

    有很多测试方法,但让我们保持简单,获取该函数,将其复制到一个新的 Python 程序,向它扔一些游戏板,看看会发生什么。我的意思是“看”字面意思——在测试方面你最好的朋友是print。假设我们像这样修改你的函数:

    def winner(board):
        print("winner function entered")
        WAYS_TO_WIN = ((0, 1, 2),
                       (3, 4, 5),
                       (6, 7, 8),
                       (0, 3, 6),
                       (1, 4, 7),
                       (2, 5, 8),
                       (0, 4, 8),
                       (2, 4, 6))
    
        for row in WAYS_TO_WIN:
            print("for loop entered")
            if board[row[0]] == board[row[1]] == board[row[2]] != EMPTY:
                winner = board[row[0]]
                return winner
    
            if EMPTY not in board:
                return TIE
            return None
    

    这似乎太简单了,但我们立即注意到在所有情况下 for 循环只输入一次。关注一小段代码,用不了多久就会发现缩进错误。

    【讨论】:

      猜你喜欢
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      相关资源
      最近更新 更多