【问题标题】:How to mock HttpClient using Mockito如何使用 Mockito 模拟 HttpClient
【发布时间】:2021-02-11 04:15:32
【问题描述】:

这是我正在为其编写 junit 的实际课程。我有 HtpClient 作为私有和最终的。

 public class KMSHttpClientImpl implements KMSHttpClient
 {
/**
 * ObjectMapper Instance.
 */
private final ObjectMapper objectMapper = new ObjectMapper ();

/**
 * KMS ConnectionManager Instance.
 */
private final KMSHttpConnectionManager kmsHttpConnectionManager =
        new KMSHttpConnectionManagerImpl ();

/**
 * HttpClient object.
 */

private final HttpClient httpClient;

/**
 * KMSHttpClient constructor.
 */
public KMSHttpClientImpl ()
{
    // TODO PoolingHttpClientConnectionManager object should be closed after use.
    // TODO This needs to be either singleton or should be kept in static block
    final PoolingHttpClientConnectionManager connectionManager =
            kmsHttpConnectionManager.getConnectionManager();
    httpClient = HttpClients.custom()
            .setConnectionManager(connectionManager)
            .build();
}

@Override
public <T> T invokeGETRequest (final String url, final Class<T> clazz)
        throws KMSClientException
{
    final HttpGet httpGet = new HttpGet(url);
    try {
        final HttpResponse response = httpClient.execute(httpGet);
        return objectMapper.readValue(
                response.getEntity().getContent(), clazz);
    } catch (IOException e) {
        throw new KMSClientException("Unable to get the result", e);
    }
}

@Override
public <T> T invokePOSTRequest (final String url, final Object object, final Class<T> clazz)
        throws KMSClientException
{
    final HttpPost httpPost = new HttpPost(url);
    try {
        final HttpResponse response = httpClient.execute(httpPost);
        return objectMapper.readValue(
                response.getEntity().getContent(), clazz);
    } catch (IOException e) {
        throw new KMSClientException("Unable to create the request", e);
    }
}
 }

这是我的测试课。我正在尝试模拟 HttpClient,但由于它是最终的,我无法模拟它。如果我在我的 KMSHttpClientImpl.java 类中从 HttpClient 中删除 final。我收到 PMd 问题说 可以将私有字段“httpClient”设为最终字段;它仅在声明或构造函数中初始化。我该怎么做才能解决这个问题?

public class KMSHttpClientImplTest
{

/**
 * Injecting mocks KMSHttpClientImpl.
 */
@InjectMocks
private KMSHttpClientImpl kmsHttpClientImpl;

/**
 * Mock HttpClient.
 */
@Mock
private HttpClient httpClient;


/**
 * Initial SetUp Method.
 */
@Before
public void setUp ()
{
    initMocks(this);
}

/**
 * Method to test postRequest Method.
 * @throws KMSClientException
 */
@Test
public void testPostRequest () throws KMSClientException
{
    final OrganizationRequest request = getOrganizationRequest();
    final HttpResponse response = prepareResponse(HttpStatus.SC_OK);
    try {
        Mockito.when(httpClient.execute(Mockito.any())).thenReturn(response);
        final OrganizationResponse organizationResponse = kmsHttpClientImpl.invokePOSTRequest(
                ORG_TEST_URL, request, OrganizationResponse.class);
        assertEquals("Id should match", ORG_ID, organizationResponse.getId());
    } catch (IOException e) {
        throw new KMSClientException("Unable to create the request", e);
    }
      }

/**
 * Method to test getRequest Method.
 * @throws KMSClientException
 */
@Test
public void testGetRequest () throws KMSClientException
{
    try {
        final HttpResponse response = prepareResponse(HttpStatus.SC_OK);
        Mockito.when(httpClient.execute(Mockito.any())).thenReturn(response);
        final OrganizationResponse organizationResponse = kmsHttpClientImpl.invokeGETRequest
                (ORG_TEST_URL, OrganizationResponse.class);
        assertEquals("Id should match", ORG_ID, organizationResponse.getId());
    }  catch (IOException e) {
        throw new KMSClientException("Unable to create the request", e);
    }
}

/**
 * Method to organizationRequest Object.
 * @return OrganizationRequest object
 */
public OrganizationRequest getOrganizationRequest ()
{
    return OrganizationRequest.builder().id("test").build();
}

/**
 * Method to getOrganizationResponse String.
 * @return String Object
 */
public String getOrganizationResponse ()
{
    final Map obj=new HashMap();
    obj.put("id", ORG_ID);
    obj.put("uuid", ORG_UUID);
    obj.put("orgKeyId", ORG_KEYID);
    return JSONValue.toJSONString(obj);
}

/**
 * Method to prepare Response.
 * @param expectedResponseStatus
 * @return HttpResponse
 */
private HttpResponse prepareResponse (final int expectedResponseStatus)
{
    final HttpResponse response = new BasicHttpResponse(new BasicStatusLine(
            new ProtocolVersion("HTTP", 1, 1),
            expectedResponseStatus, ""));
    response.setStatusCode(expectedResponseStatus);
    final HttpEntity httpEntity = new StringEntity(getOrganizationResponse(),
            ContentType.APPLICATION_JSON);
    response.setEntity(httpEntity);
    return response;
     }
    }

【问题讨论】:

    标签: java junit mockito powermockito pmd


    【解决方案1】:

    测试 HTTP 客户端代码的方法之一是不模拟您的 HTTPClient 对象,而是为 http 调用创建模拟响应,然后让您的 HPPTClient 调用这些 URL。 看看 Wiremock。 http://wiremock.org/docs/ 它可以帮助您创建一个简单的模拟服务器,并且您可以为您的 URL 存根响应。 然后使用您的客户端调用您的 URL 进行测试。

    【讨论】:

    • 我不想使用 PowerMock。有没有办法抑制这个 PMD 警告 Private field 'httpClient' can be made final;它只在声明或构造函数中初始化
    • 我建议使用与 powermock 不同的库。但我明白你的意思。你想删除final。但是你被展示为一个问题,因为它是一个问题。我猜你正在使用 PMD 来分析你的代码。为什么在它做它应该做的时候抱怨。!无论如何,如果那是您想要的,您可以为文件添加例外,以便在源代码分析器中不报告某些文件的问题。这可能会有所帮助。 stackoverflow.com/questions/32272138/…
    • 我可以这样做@SuppressWarnings("PMD") 但不是 PMD,我正在寻找与此错误相关的特定代码.....这个 @SuppressWarnings("PMD") 有效,但我想要具体的代码。
    • 好吧,看起来我们缺少关于您正在寻找什么的上下文。请尝试使用更多详细信息更新问题。
    • 因此 PMD 向您发出警告,指出该字段 可能 是最终的。在这种情况下 PMD 是否正确取决于您作为开发人员。我会争辩说,在这种情况下,PMD 是正确的,你真正的问题是你正在尝试模拟你不应该模拟的东西(HTTPClient),正如 Shubham 所说,尝试使用类似 WireMock 的东西,这是一种更好的方法来测试一个调用的类在网络上,意味着您将拥有更好的结构化代码,并且 PMD 警告将消失,因为该字段是最终的。一切都解决了。
    【解决方案2】:

    在测试中使用模拟 HttpClient 的一种简单方法是添加第二个构造函数,该构造函数采用 HttpClient。

    public class KMSHttpClientImpl implements KMSHttpClient
    {
    
      private final HttpClient httpClient;
    
      public KMSHttpClientImpl ()
      {
        final PoolingHttpClientConnectionManager connectionManager =
                kmsHttpConnectionManager.getConnectionManager();
        httpClient = HttpClients.custom()
                .setConnectionManager(connectionManager)
                .build();
      }
    
      // This constructor is package private instead
      // of public so it is not accidentally used by
      // classes outside of this package. If your test
      // class is not in the same package, then you
      // need to make this a public constructor.
      KMSHttpClientImpl (final HttpClient httpClient)
      {
        this.httpClient = httpClient;
      }
    
    }
    

    然后,您使用此构造函数注入模拟的 HttpClient,并且在您的测试中既不需要 @InjectMocks 也不需要 @Mock

    @Test
    public void testPostRequest () throws KMSClientException
    {
      final HttpClient httpClient = Mockito.mock(HttpClient.class);
      final HttpResponse response = prepareResponse(HttpStatus.SC_OK);
      Mockito.when(httpClient.execute(Mockito.any())).thenReturn(response);
      final KMSHttpClientImpl kmsHttpClientImpl = new KMSHttpClientImpl(httpClient);
    
      // run your test...
    }
    

    【讨论】:

      【解决方案3】:

      您不能使用简单的模拟来模拟最终实例。你需要像PowerMock 这样的东西。

      请参阅this question的答案以了解实施情况。

      【讨论】:

      • 我不想使用 PowerMock。有没有办法抑制这个 PMD 警告 Private field 'httpClient' can be made final;它只在声明或构造函数中初始化
      • 要抑制 PMD 警告,请使用注释 - 请参阅 pmd.github.io/latest/pmd_userdocs_suppressing_warnings.html
      • PowerMock 是一个 hack,至少在这种情况下是这样。测试方法是问题所在,HTTPClient 根本不应该被嘲笑,需要一种替代方法。
      猜你喜欢
      • 2013-12-30
      • 1970-01-01
      • 2016-05-08
      • 2012-04-05
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      相关资源
      最近更新 更多