【发布时间】:2021-02-11 04:15:32
【问题描述】:
这是我正在为其编写 junit 的实际课程。我有 HtpClient 作为私有和最终的。
public class KMSHttpClientImpl implements KMSHttpClient
{
/**
* ObjectMapper Instance.
*/
private final ObjectMapper objectMapper = new ObjectMapper ();
/**
* KMS ConnectionManager Instance.
*/
private final KMSHttpConnectionManager kmsHttpConnectionManager =
new KMSHttpConnectionManagerImpl ();
/**
* HttpClient object.
*/
private final HttpClient httpClient;
/**
* KMSHttpClient constructor.
*/
public KMSHttpClientImpl ()
{
// TODO PoolingHttpClientConnectionManager object should be closed after use.
// TODO This needs to be either singleton or should be kept in static block
final PoolingHttpClientConnectionManager connectionManager =
kmsHttpConnectionManager.getConnectionManager();
httpClient = HttpClients.custom()
.setConnectionManager(connectionManager)
.build();
}
@Override
public <T> T invokeGETRequest (final String url, final Class<T> clazz)
throws KMSClientException
{
final HttpGet httpGet = new HttpGet(url);
try {
final HttpResponse response = httpClient.execute(httpGet);
return objectMapper.readValue(
response.getEntity().getContent(), clazz);
} catch (IOException e) {
throw new KMSClientException("Unable to get the result", e);
}
}
@Override
public <T> T invokePOSTRequest (final String url, final Object object, final Class<T> clazz)
throws KMSClientException
{
final HttpPost httpPost = new HttpPost(url);
try {
final HttpResponse response = httpClient.execute(httpPost);
return objectMapper.readValue(
response.getEntity().getContent(), clazz);
} catch (IOException e) {
throw new KMSClientException("Unable to create the request", e);
}
}
}
这是我的测试课。我正在尝试模拟 HttpClient,但由于它是最终的,我无法模拟它。如果我在我的 KMSHttpClientImpl.java 类中从 HttpClient 中删除 final。我收到 PMd 问题说 可以将私有字段“httpClient”设为最终字段;它仅在声明或构造函数中初始化。我该怎么做才能解决这个问题?
public class KMSHttpClientImplTest
{
/**
* Injecting mocks KMSHttpClientImpl.
*/
@InjectMocks
private KMSHttpClientImpl kmsHttpClientImpl;
/**
* Mock HttpClient.
*/
@Mock
private HttpClient httpClient;
/**
* Initial SetUp Method.
*/
@Before
public void setUp ()
{
initMocks(this);
}
/**
* Method to test postRequest Method.
* @throws KMSClientException
*/
@Test
public void testPostRequest () throws KMSClientException
{
final OrganizationRequest request = getOrganizationRequest();
final HttpResponse response = prepareResponse(HttpStatus.SC_OK);
try {
Mockito.when(httpClient.execute(Mockito.any())).thenReturn(response);
final OrganizationResponse organizationResponse = kmsHttpClientImpl.invokePOSTRequest(
ORG_TEST_URL, request, OrganizationResponse.class);
assertEquals("Id should match", ORG_ID, organizationResponse.getId());
} catch (IOException e) {
throw new KMSClientException("Unable to create the request", e);
}
}
/**
* Method to test getRequest Method.
* @throws KMSClientException
*/
@Test
public void testGetRequest () throws KMSClientException
{
try {
final HttpResponse response = prepareResponse(HttpStatus.SC_OK);
Mockito.when(httpClient.execute(Mockito.any())).thenReturn(response);
final OrganizationResponse organizationResponse = kmsHttpClientImpl.invokeGETRequest
(ORG_TEST_URL, OrganizationResponse.class);
assertEquals("Id should match", ORG_ID, organizationResponse.getId());
} catch (IOException e) {
throw new KMSClientException("Unable to create the request", e);
}
}
/**
* Method to organizationRequest Object.
* @return OrganizationRequest object
*/
public OrganizationRequest getOrganizationRequest ()
{
return OrganizationRequest.builder().id("test").build();
}
/**
* Method to getOrganizationResponse String.
* @return String Object
*/
public String getOrganizationResponse ()
{
final Map obj=new HashMap();
obj.put("id", ORG_ID);
obj.put("uuid", ORG_UUID);
obj.put("orgKeyId", ORG_KEYID);
return JSONValue.toJSONString(obj);
}
/**
* Method to prepare Response.
* @param expectedResponseStatus
* @return HttpResponse
*/
private HttpResponse prepareResponse (final int expectedResponseStatus)
{
final HttpResponse response = new BasicHttpResponse(new BasicStatusLine(
new ProtocolVersion("HTTP", 1, 1),
expectedResponseStatus, ""));
response.setStatusCode(expectedResponseStatus);
final HttpEntity httpEntity = new StringEntity(getOrganizationResponse(),
ContentType.APPLICATION_JSON);
response.setEntity(httpEntity);
return response;
}
}
【问题讨论】:
标签: java junit mockito powermockito pmd